[issue12808] Coverage of codecs.py

2019-03-15 Thread Mark Lawrence
Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue12808] Coverage of codecs.py

2015-04-07 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue12808] Coverage of codecs.py

2014-07-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also issue20420. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailin

[issue12808] Coverage of codecs.py

2014-06-28 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: The patch would have to be updated to 3.5 (part of it no longer applies), but other than that I think it's fine. It may make sense to readd the comment for .getstate() to keep the state as simple as possible ("The implementation should make sure that ``0``

[issue12808] Coverage of codecs.py

2014-06-28 Thread Walter Dörwald
Walter Dörwald added the comment: The requirement that getstate() returns a (buffer, int) tuple has to do with the fact that for text streams seek() and tell() somehow have to take the state of the codec into account. See _pyio.TextIOWrapper.(seek|tell|_pack_cookie|_unpack_cookie). However I

[issue12808] Coverage of codecs.py

2014-06-27 Thread Mark Lawrence
Mark Lawrence added the comment: Would someone who's commented previously do a commit review please? -- nosy: +BreamoreBoy ___ Python tracker ___

[issue12808] Coverage of codecs.py

2011-08-28 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- components: +Library (Lib), Tests versions: +Python 3.3 -Python 3.4 ___ Python tracker ___ ___ Python-b

[issue12808] Coverage of codecs.py

2011-08-26 Thread Tennessee Leeuwenburg
Tennessee Leeuwenburg added the comment: Here is a stab at updated documentation. I would suggest that if further changes are recommended to the documentation, that a core committer go ahead and make them. I'm absolutely more than happy to keep taking "stabs" at it, but ultimately I probably

[issue12808] Coverage of codecs.py

2011-08-23 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue12808] Coverage of codecs.py

2011-08-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Tennessee Leeuwenburg wrote: > > Tennessee Leeuwenburg added the comment: > > Thanks for the review. Here is a patch incorporating the two comments being > to move some comments. Hmm, the documentation patch doesn't appear to have changed. Did you uploa

[issue12808] Coverage of codecs.py

2011-08-22 Thread Tennessee Leeuwenburg
Tennessee Leeuwenburg added the comment: Thanks for the review. Here is a patch incorporating the two comments being to move some comments. -- Added file: http://bugs.python.org/file23007/codecs.diff ___ Python tracker

[issue12808] Coverage of codecs.py

2011-08-22 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Tennessee Leeuwenburg wrote: > > Tennessee Leeuwenburg added the comment: > > Some more tests, updated initial state of BufferedIncrementalEncoder to be > the correct type, updated rst file. Bit tired, hope I got it right! > > Thanks for the feedback ev

[issue12808] Coverage of codecs.py

2011-08-22 Thread Tennessee Leeuwenburg
Tennessee Leeuwenburg added the comment: Some more tests, updated initial state of BufferedIncrementalEncoder to be the correct type, updated rst file. Bit tired, hope I got it right! Thanks for the feedback everyone, helps me to get it done, even if it's more work for you... -- Adde

[issue12808] Coverage of codecs.py

2011-08-22 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Nick Coghlan wrote: > > As a separate, but related point, IncrementalDecoder.getstate() includes an > explanation on how to save arbitrary state as an integer, but no such > explanation (not even a reference to the IncrementalDecoder version) is > presen

[issue12808] Coverage of codecs.py

2011-08-21 Thread Nick Coghlan
Nick Coghlan added the comment: Tennessee, there were a few issues in the original patch - see the attached update (mostly the use of assert statements instead of methods and the overbroad scope of the context manager when checking for an expected exception). However, in getting ready to comm

[issue12808] Coverage of codecs.py

2011-08-21 Thread Tennessee Leeuwenburg
Tennessee Leeuwenburg added the comment: Also some pep8 compliance outside of the scope of the added lines of code. -- ___ Python tracker ___ ___

[issue12808] Coverage of codecs.py

2011-08-21 Thread Tennessee Leeuwenburg
New submission from Tennessee Leeuwenburg : Increases the coverage of codecs.py by about 3 lines... -- files: mywork.patch keywords: patch messages: 142661 nosy: ncoghlan, tleeuwenburg priority: normal severity: normal status: open title: Coverage of codecs.py versions: Python 3.4 Added