[issue12804] make test should not enable the urlfetch resource

Éric Araujo added the comment: I don’t have a flaky connection, I have none at all; until this change I could always run just use “make test” for all Python versions. OTOH, I agree with your point that testing networking facilities in the standard test suite makes sense, as most people proba

[issue12804] make test should not enable the urlfetch resource

Antoine Pitrou added the comment: Change reverted. "make test" should run a comprehensive test of Python's facilities, and that includes network facilities. We only exclude functionality where testing is hostile to the user (largefile,audio,gui). You could add "make offlinetest" if you care,

[issue12804] make test should not enable the urlfetch resource

Roundup Robot added the comment: New changeset 7fabd75a6ae4 by Antoine Pitrou in branch 'default': Backout of changeset 228fd2bd83a5 by Nadeem Vawda in branch 'default': http://hg.python.org/cpython/rev/7fabd75a6ae4 -- ___ Python tracker

[issue12804] make test should not enable the urlfetch resource

Antoine Pitrou added the comment: Please consider reverting this patch. If you have flaky network connection, you can override the test flags yourself. -- nosy: +brett.cannon, pitrou status: closed -> open ___ Python tracker

[issue12804] make test should not enable the urlfetch resource

Changes by Nadeem Vawda : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Pyt

[issue12804] make test should not enable the urlfetch resource

Roundup Robot added the comment: New changeset 228fd2bd83a5 by Nadeem Vawda in branch 'default': Issue #12804: Prevent "make test" from using network resources. http://hg.python.org/cpython/rev/228fd2bd83a5 -- nosy: +python-dev ___ Python tracker

[issue12804] make test should not enable the urlfetch resource

Éric Araujo added the comment: > Before the run_tests.py patch, the urlfetch resource was not enabled > by default. I’m referring to the addition of run_tests.py, not this patch. -- ___ Python tracker ___

[issue12804] make test should not enable the urlfetch resource

Éric Araujo added the comment: Yes, the machine did not have Internet access. Before the run_tests.py patch, the urlfetch resource was not enabled by default. I don’t want to disconnect to test the patch, but it looks good: /home/wok/python/3.3/python -W default -bb -E -m test -r -w -j 0 -u

[issue12804] make test should not enable the urlfetch resource

Nadeem Vawda added the comment: Are the failures because the machine you're running the test on doesn't have internet access? Or are there problems with some of the tests? The attached patch should solve the problem. -- keywords: +patch Added file: http://bugs.python.org/file22972/i128

[issue12804] make test should not enable the urlfetch resource

New submission from Éric Araujo : When I run make test on 3.3 now, I get failures because the tests try to make HTTP requests. -- messages: 142621 nosy: eric.araujo, nadeem.vawda priority: normal severity: normal status: open title: make test should not enable the urlfetch resource vers