[issue12682] Meaning of 'accepted' resolution as documented in devguide

Ezio Melotti added the comment: OK, I removed the resolution and its documentation from the devguide in 3f4710b6baf9. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Martin v. Löwis added the comment: > Martin, should we convert all the "accepted" to "fixed" before removing it? That's not strictly necessary. It would only be retired (roundup does not support true removal), and as such would then still show up in issues that currently use it, but not show up

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Terry J. Reedy added the comment: Only if the issue is closed, so that it actually means 'fixed'. Otherwise, just delete it. The following data suggests to me that 'accepted' is a de facto synonym for 'fixed' and therefore useless and might as well be removed. N Issue category 3290 fixed

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Ezio Melotti added the comment: +1 Martin, should we convert all the "accepted" to "fixed" before removing it? -- ___ Python tracker ___ ___

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Antoine Pitrou added the comment: I would say I find "accepted" little useful in practice. Removing it would avoid the confusion with its various (intended or not) meanings. -- nosy: +pitrou ___ Python tracker __

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Senthil Kumaran added the comment: RDM, yes, unfortunately the direction of the discussion changed from documentation issue to a process one. Instead of diverting further into catch all discussion about process/tracker, it would be good idea to settle this one. Your points definitely counts as y

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Terry J. Reedy added the comment: Changing the dev guide, which I think is definitely needed, is an issue for this tracker. Changing the tracker is an issue for the meta-tracker. Discussing a change might be an issue for python-dev. I was under the impression once that the tracker fields were

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Ezio Melotti added the comment: "patch accepted" can be marked with the "commit review" stage. That should mean "the patch is ready to go in, after a last quick review by the committer that will apply it", even though I've seen it used as "I made the commit but I'm leaving this open until I'm

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Éric Araujo added the comment: When we’ve talked about that a few times these last months on the ML or on IRC, the outcome was that accepted means patch is accepted, not bug report is valid. I’ve never seen accepted used to mean that a feature request is closed; I use fixed for solved bugs a

[issue12682] Meaning of 'accepted' resolution as documented in devguide

R. David Murray added the comment: I think we've moved from discussing a documentation issue to discussing a procedural issue in the development process. I'm not sure what forum that belongs in, though I believe in the past we have used tracker-discuss for that. That said, I'm really fine wi

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Senthil Kumaran added the comment: R. David Murray wrote: > If someone wants to re-engineer the interface, that would be fine with me :) Does that mean, that if vote for removing the 'accepted' keyword it becomes an issue for the meta-tracker? -- _

[issue12682] Meaning of 'accepted' resolution as documented in devguide

R. David Murray added the comment: Well, as long as 'accepted' is under 'resolution', I'm likely to keep using it for feature requests, I suppose because I'm too much of a precisonist. If someone wants to re-engineer the interface, that would be fine with me :) I personally don't mind other

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Ezio Melotti added the comment: FWIW that would be fine with me. Even if there's nothing broken in a feature request, "fixed" applied to feature could mean "the lack of this feature has been fixed". If the issue is valid, one can say so in a message without marking it as 'accepted'. ---

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Petri Lehtinen added the comment: Terry J. Reedy wrote: > Adding a feature 'fixes' the deficiency of its absence. I personally > have no use for 'accepted' and find it ambiguous. My best > understanding is what David has seen (accepted in principle). Ditto. Having separate resolutions for bugs

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Terry J. Reedy added the comment: Adding a feature 'fixes' the deficiency of its absence. I personally have no use for 'accepted' and find it ambiguous. My best understanding is what David has seen (accepted in principle). -- nosy: +terry.reedy ___

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Changes by Petri Lehtinen : -- nosy: +petri.lehtinen ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Martin v. Löwis added the comment: The "Accepted" Resolution was copied from SF. I recall seeing documentation on SF for the resolutions, but can't find that anymore. I also recall that on SF, the "accepted" resolution was used to indicate that a patch was accepted (be it a bug fix or a featu

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Senthil Kumaran added the comment: I thought "fixed" was enough. A kind of binary state where we say, okay we have it and otherwise no, we don't. I know for feature requests the terminology does not make sense, but I believe I have worked with bug trackers where fixed was the ultimate state w

[issue12682] Meaning of 'accepted' resolution as documented in devguide

R. David Murray added the comment: It is not ambigous. As I said, bugs are fixed, feature requests are accepted. -- ___ Python tracker ___ _

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Senthil Kumaran added the comment: I propose that we remove 'accepted' as the meaning seems ambiguous and it is of little practical (/tracking) use. -- nosy: +orsenthil ___ Python tracker _

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Brett Cannon added the comment: I say just go ahead and change it. I was probably just thinking how I wish we would use it when I wrote that. -- nosy: +brett.cannon ___ Python tracker __

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Ross Lagerwall added the comment: > Formally I believe that the 'accepted' resolution is for committed feature > requests That's what I also thought originally. Perhaps this should be discussed on Python-Dev to see what people think it should mean? -- nosy: +rosslagerwall _

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Changes by Daniel Stutzbach : -- nosy: +stutzbach ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue12682] Meaning of 'accepted' resolution as documented in devguide

Changes by Ezio Melotti : -- components: +Devguide -Documentation nosy: +ezio.melotti resolution: -> accepted stage: -> needs patch ___ Python tracker ___ _

[issue12682] Meaning of 'accepted' resolution as documented in devguide

New submission from R. David Murray : The devguide documents the 'accepted' resolution as follows: Submitted patch was applied, still needs verifying (for example by watching the buildbots) that everything went fine. At that point the resolution should be set to fixed and the stat