[issue12559] gzip.open() needs an optional encoding argument

Nadeem Vawda added the comment: I already fixed this without knowing about this issue; see 55202ca694d7. storchaka: > Why not use io.TextWrapper? I think it is the right answer for this issue. The proposed patch (and the code I committed) *do* use TextIOWrapper. Unless you mean that callers

[issue12559] gzip.open() needs an optional encoding argument

Serhiy Storchaka added the comment: Why not use io.TextWrapper? I think it is the right answer for this issue. -- nosy: +storchaka ___ Python tracker ___ ___

[issue12559] gzip.open() needs an optional encoding argument

Changes by Éric Araujo : -- nosy: +nadeem.vawda versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue12559] gzip.open() needs an optional encoding argument

Changes by Rasmus Ory Nielsen : -- nosy: +rasmusory ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue12559] gzip.open() needs an optional encoding argument

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue12559] gzip.open() needs an optional encoding argument

Daniel Urban added the comment: > If we go this way, the "errors" and "newline" argument should be added > as well. Yeah, I thought about that. I can make a new patch, that implement this, if needed. Though it seems there is a real problem, the one that Amaury Forgeot d'Arc mentioned. I can't

[issue12559] gzip.open() needs an optional encoding argument

Antoine Pitrou added the comment: If we go this way, the "errors" and "newline" argument should be added as well. -- nosy: +pitrou stage: -> patch review ___ Python tracker ___

[issue12559] gzip.open() needs an optional encoding argument

Changes by Raymond Hettinger : -- versions: -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue12559] gzip.open() needs an optional encoding argument

Amaury Forgeot d'Arc added the comment: There remains a difference between open() and gzip.open(): open(filename, 'r', encoding=None) is a text file (with a default encoding), gzip.open() with the same arguments returns a binary file. Don't know how to fix this though. -- nosy: +amaur

[issue12559] gzip.open() needs an optional encoding argument

Daniel Urban added the comment: Here is a patch. If the code changes are acceptable I can also make a documentation patch. (I'm surprised to see 3.2 in "Versions". I thought 3.2 only gets bugfixes...) -- keywords: +patch nosy: +durban Added file: http://bugs.python.org/file22661/issue

[issue12559] gzip.open() needs an optional encoding argument

New submission from Raymond Hettinger : gzip.open() should parallel file.open() so that that zipped files can be read in the same way as regular files: for line in gzip.open('notes.txt', 'r', encoding='latin-1'): print(line.rstrip()) -- components: Library (Lib) messages: 140341 no