[issue12416] packaging does not have hooks callable during distribution removal

2011-06-27 Thread Éric Araujo
Éric Araujo added the comment: The setup.cfg spec says only this: > The callables are executed in the order they’re found in the file; if > one of them cannot be found, tools should not stop, but for example > produce a warning and continue with the next line. packaging/commandhooks does not s

[issue12416] packaging does not have hooks callable during distribution removal

2011-06-27 Thread Tarek Ziadé
Tarek Ziadé added the comment: We need to make it crystal clear in the doc: developers need to understand this behavior. Also, for a fatal error, I am -1 for activating this for an uninstall hook because we want to uninstall wathever happens in the hooks, +1 for others (as long as it's coupl

[issue12416] packaging does not have hooks callable during distribution removal

2011-06-27 Thread Éric Araujo
Éric Araujo added the comment: Definitely, hooks do not stop operation. I’ll double-check that. We may want an option to turn hooks failures into fatal errors. -- ___ Python tracker

[issue12416] packaging does not have hooks callable during distribution removal

2011-06-27 Thread Tarek Ziadé
Tarek Ziadé added the comment: Sounds good. Also, we should make the assumption that this hook might be deactivated or might fail. So it should not break the uninstallation in this case (a warning seem fine) -- ___ Python tracker

[issue12416] packaging does not have hooks callable during distribution removal

2011-06-27 Thread Éric Araujo
Éric Araujo added the comment: I have no objection, but you may want to ask on the fellowship ML first. Should the hooks be run before the removal or just after? (Debian for example has both, which makes four hooks: preinst, postinst, prerm, postrm). Our setup_hooks (used with pysetup comma

[issue12416] packaging does not have hooks callable during distribution removal

2011-06-26 Thread Vinay Sajip
New submission from Vinay Sajip : In general it is possible for an installation to make certain system changes other than the record of files written during an installation (for example, under Windows, there may be distribution-specific Windows registry updates). There seems to be no hook that