[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

Roundup Robot added the comment: New changeset 3f30cfe51315 by Victor Stinner in branch '3.2': Issue #12363: increase the timeout of siginterrupt() tests http://hg.python.org/cpython/rev/3f30cfe51315 New changeset 423268537083 by Victor Stinner in branch 'default': (merge 3.2) Issue #12363: inc

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

Roundup Robot added the comment: New changeset 8250f04d5a41 by Victor Stinner in branch '3.2': Issue #12363: improve siginterrupt() tests http://hg.python.org/cpython/rev/8250f04d5a41 -- ___ Python tracker ___

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

STINNER Victor added the comment: All Python 3.x buildbots are green (except FreeBSD 7.2, but it's not related to this issue). Let close this issue. -- status: open -> closed ___ Python tracker __

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

STINNER Victor added the comment: > Apart from removing those tests, I don't see what we can do here. The previous version of the test rarely failed (only sometimes on the FreeBSD 6.4 buildbox). We may revert my commits to restore the previous test if the new tests fail more often. > the rea

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

Roundup Robot added the comment: New changeset aff0a7b0cb12 by Victor Stinner in branch 'default': Issue #12363: improve siginterrupt() tests http://hg.python.org/cpython/rev/aff0a7b0cb12 -- ___ Python tracker ___

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

Changes by Charles-François Natali : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

Changes by Charles-François Natali : Removed file: http://bugs.python.org/file22420/test_siginterrupt.diff ___ Python tracker ___ ___ Python-b

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

Changes by Charles-François Natali : Added file: http://bugs.python.org/file22421/test_siginterrupt.diff ___ Python tracker ___ ___ Python-bug

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

Charles-François Natali added the comment: Duh, don't know what I was thinking: the syscall is not restarted (even though ERESTARTSYS is displayed by strace): the real problem is that the 3s timeout to communicate is not enough, because spawning a new interpreter can take a long time (Antoine c

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

Charles-François Natali added the comment: The test still fails on FreeBSD 7.2, Tiger and Debian parallel: """ == FAIL: test_siginterrupt_on (test.test_signal.SiginterruptTest) --

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

STINNER Victor added the comment: > In the subprocess, why not use the standard 0 exit code > in case of success? Something outside my code may exit Python with the code 0. Even if it unlikely, I prefer to use uncommon exit codes, to ensure that the child process executed "correctly" my code.

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

Roundup Robot added the comment: New changeset 968b9ff9a059 by Victor Stinner in branch 'default': Close #12363: fix a race condition in siginterrupt() tests http://hg.python.org/cpython/rev/968b9ff9a059 -- nosy: +python-dev resolution: -> fixed stage: -> committed/rejected status: op

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

Charles-François Natali added the comment: The patch looks good to me. In the subprocess, why not use the standard 0 exit code in case of success? Also, points 1 and 3 could be handled simply by having the parent process send a signal to the child (but this wouldn't address the timeout issue).

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

STINNER Victor added the comment: I tried to patch the test to use a semaphore, but my patch was not reliable (don't remove completly the race condition). Here is a patch using a subprocess to: - have only one thread - have a timeout on the blocking read (select cannot be used in the test,

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

STINNER Victor added the comment: Seen also on OpenSolaris: test test_signal failed -- Traceback (most recent call last): File "/export/home/buildbot/64bits/3.x.cea-indiana-amd64/build/Lib/test/test_signal.py", line 399, in test_siginterrupt_on self.assertTrue(i) AssertionError: False i

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

New submission from STINNER Victor : == FAIL: test_siginterrupt_on (test.test_signal.SiginterruptTest) -- Traceback (most recent call last): File "/usr/home/d