[issue1225769] Proposal to implement comment rows in csv module

Changes by florian-rathgeber : -- nosy: +florian-rathgeber ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue1225769] Proposal to implement comment rows in csv module

Andrew McNamara added the comment: Note that there is one case that cannot easily be addressed via pre-processing: where the comment character coincidently appears at the start of a line within a multi-line quoted field. For example: # This is a comment 1, 2, "This is field^M #3" What this s

[issue1225769] Proposal to implement comment rows in csv module

Andrew McNamara added the comment: Okay, while I am sympathetic to the points raised by the people asking for this enhancement, I'm persuaded to reject it by the arguments that the potential benefit is outweighed by the increase in complexity (code and documentation). While the attached patch

[issue1225769] Proposal to implement comment rows in csv module

Senthil Kumaran added the comment: Here is another -1 for this proposed feature. Having a comments in the csv fields and providing a way to deal will complicate matters more than required. Different suggestions of how to accomplish it has been suggested here. As others, I too recommend closin

[issue1225769] Proposal to implement comment rows in csv module

Skip Montanaro added the comment: Antoine> Since the csv module returns you an iterator, it's easy enough Antoine> to wrap it in another iterator. I prefer to do this sort of stuff as a pre-processing step, so I generally wrap the file object input and use that iterator as the input "file"

[issue1225769] Proposal to implement comment rows in csv module

Antoine Pitrou added the comment: Agreed with Skip, Raymond and Amaury. Since the csv module returns you an iterator, it's easy enough to wrap it in another iterator. -- nosy: +pitrou ___ Python tracker ___

[issue1225769] Proposal to implement comment rows in csv module

Skip Montanaro added the comment: Amaury> Comment lines in csv data may be common in some areas, but they Amaury> are not part of any standard, and they are not the only possible Amaury> extension to csv files (for example: ignore empty lines, or a Amaury> terminal \ for line continu

[issue1225769] Proposal to implement comment rows in csv module

Amaury Forgeot d'Arc added the comment: > Shouldn't the comment char definition belong in a dialect class? The proposed patch does this correctly; then csv.reader automatically accepts the dialect parameters to override the selected dialect. I'm still -1 on the feature - not standard enough, a

[issue1225769] Proposal to implement comment rows in csv module

Éric Araujo added the comment: Hello Shouldn't the comment char definition belong in a dialect class? The reader would still have to be modified to skip these lines, but having this char in the dialect would not require a change to csv.reader signature. Kind regards -- nosy: +Merwok

[issue1225769] Proposal to implement comment rows in csv module

Amaury Forgeot d'Arc added the comment: Comment lines in csv data may be common in some areas, but they are not part of any standard, and they are not the only possible extension to csv files (for example: ignore empty lines, or a terminal \ for line continuation...) Currently all members of

[issue1225769] Proposal to implement comment rows in csv module

Mario Fasold added the comment: Comment lines are a *very* common case in scientific and statistical data. +1 for the change. -- nosy: +Mario.Fasold ___ Python tracker ___ __

[issue1225769] Proposal to implement comment rows in csv module

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: -1 on the change. Comments in CSV files are not a common use case. I'm less worried about cluttering the C code and more concerned about cluttering the API, making the module harder to learn and remember. Also, it is already trivial to

[issue1225769] Proposal to implement comment rows in csv module

Andrew McNamara <[EMAIL PROTECTED]> added the comment: I think it's a reasonable enough request - I've certainly had to process CSV files with comments. Iain - appologies for not looking at your request before now - 3 years is a pretty poor response time. Some thoughts: * this should target 2

[issue1225769] Proposal to implement comment rows in csv module

Skip Montanaro <[EMAIL PROTECTED]> added the comment: Assigning to Andrew (as the primary C lib author). Andrew, please comment ;-). -- assignee: skip.montanaro -> andrewmcnamara nosy: +andrewmcnamara _ Tracker <[EMAIL PROTECTED]>