[issue12112] The new packaging module should not use the locale encoding

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue12112] The new packaging module should not use the locale encoding

Éric Araujo added the comment: I can run LANG=C python -m test test_packaging successfully. Can we close this? -- ___ Python tracker ___ ___

[issue12112] The new packaging module should not use the locale encoding

Roundup Robot added the comment: New changeset a636cb1b7f84 by Victor Stinner in branch 'default': Issue #12112: fix the encoding of setup.py in the packaging module http://hg.python.org/cpython/rev/a636cb1b7f84 -- ___ Python tracker

[issue12112] The new packaging module should not use the locale encoding

Tarek Ziadé added the comment: That's not used anymore, I am going to strip it -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue12112] The new packaging module should not use the locale encoding

STINNER Victor added the comment: What is the MainProgram.inspect_file() function in packaging.create? Which kind of file should it process? => What is the encoding of the input files? -- ___ Python tracker _

[issue12112] The new packaging module should not use the locale encoding

Roundup Robot added the comment: New changeset fe740c1cee02 by Victor Stinner in branch 'default': Issue #12112: packaging reads and writes setup.cfg using UTF-8 http://hg.python.org/cpython/rev/fe740c1cee02 New changeset 01d61096140a by Victor Stinner in branch 'default': Issue #12112: packagi

[issue12112] The new packaging module should not use the locale encoding

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue12112] The new packaging module should not use the locale encoding

Antoine Pitrou added the comment: +if not isinstance(fileobject, StringIO): +encoding = codecs.lookup(fileobject.encoding).name IMO you should try to get the "encoding" attribute and silence the AttributeError instead. (also, I'm not even sure why you're adding this check)

[issue12112] The new packaging module should not use the locale encoding

STINNER Victor added the comment: I ported a distutils fix (for non-ASCII path) into packaging: New changeset cc5cfeaa4a8d by Victor Stinner in branch 'default': Issue #10419, issue #6011: port 6ad356525381 fix from distutils to packaging http://hg.python.org/cpython/rev/cc5cfeaa4a8d -

[issue12112] The new packaging module should not use the locale encoding

Tarek Ziadé added the comment: Looks good, please commit this -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue12112] The new packaging module should not use the locale encoding

STINNER Victor added the comment: See also issue #9561 (distutils: set encoding to utf-8 for input and output files) and #6011 (python doesn't build if prefix contains non-ascii characters). If you are curious, read also #8611 (Python3 doesn't support locale different than utf8 and an non-ASC

[issue12112] The new packaging module should not use the locale encoding

Changes by STINNER Victor : -- components: +Library (Lib) nosy: +eric.araujo, tarek ___ Python tracker ___ ___ Python-bugs-list mailin

[issue12112] The new packaging module should not use the locale encoding

New submission from STINNER Victor : The locale encoding is not portable, packaging should use UTF-8 instead. Attached patch is a draft to workaround "LANG=C ./python -m test test_packaging" failures. I'm not sure that my test in Metadata.write_file() of packaging.metadata is a good idea. Mor