[issue12034] check_GetFinalPathNameByHandle() suboptimal

2012-10-21 Thread Antoine Pitrou
Antoine Pitrou added the comment: Patch committed, thank you! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue12034] check_GetFinalPathNameByHandle() suboptimal

2012-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8afa3ce5ff3e by Antoine Pitrou in branch 'default': Issue #12034: Fix bogus caching of result in check_GetFinalPathNameByHandle. http://hg.python.org/cpython/rev/8afa3ce5ff3e -- nosy: +python-dev ___ Pyth

[issue12034] check_GetFinalPathNameByHandle() suboptimal

2012-07-26 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thank you, patch looks fine to me. It will have to wait for after the 3.3 release, though, since we are now in feature freeze. -- versions: +Python 3.4 -Python 3.2, Python 3.3 ___ Python tracker

[issue12034] check_GetFinalPathNameByHandle() suboptimal

2012-07-26 Thread Atsuo Ishimoto
Atsuo Ishimoto added the comment: Patch to cache result of check_GetFinalPathNameByHandle(). -- keywords: +patch nosy: +ishimoto Added file: http://bugs.python.org/file26535/issue12034.patch ___ Python tracker ___

[issue12034] check_GetFinalPathNameByHandle() suboptimal

2011-05-24 Thread Catalin Iacob
Catalin Iacob added the comment: I looked at providing a patch for this issue as an introductory step (this would be my first patch). But when following the code I discovered that the case that this issue is trying to optimize is never executed in current CPython. In that case, there isn't m

[issue12034] check_GetFinalPathNameByHandle() suboptimal

2011-05-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: Yes, it should be trivial to fix. I've stumbled on this simply because I needed to write similar code for another patch, so studied how it was done in posixmodule.c. -- ___ Python tracker

[issue12034] check_GetFinalPathNameByHandle() suboptimal

2011-05-16 Thread Sijin Joseph
Sijin Joseph added the comment: Is this related to some other issue? The fix seems trivial, however I am curious as to how you stumbled upon this? Is there more to this issue than just performance? -- ___ Python tracker

[issue12034] check_GetFinalPathNameByHandle() suboptimal

2011-05-11 Thread Sijin Joseph
Changes by Sijin Joseph : -- nosy: +sijinjoseph ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue12034] check_GetFinalPathNameByHandle() suboptimal

2011-05-08 Thread Antoine Pitrou
New submission from Antoine Pitrou : The code for check_GetFinalPathNameByHandle() goes like this: static int has_GetFinalPathNameByHandle = 0; [...] static int check_GetFinalPathNameByHandle() { HINSTANCE hKernel32; /* only recheck */ if (!has_GetFinalPathNameByHandle) {