[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

2015-05-14 Thread R. David Murray
R. David Murray added the comment: Given that several comments say "this should be done", and your analysis indicates it is done, I think it should be safe to close it :) Thanks for the nudge. -- nosy: +r.david.murray resolution: -> fixed stage: test needed -> resolved status: open ->

[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

2015-05-14 Thread Francis MB
Francis MB added the comment: Can this issue be closed? IMHO it's not clear what still needs to be done. The patch seems to be there already. Thanks in advance! -- nosy: +francismb ___ Python tracker

[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

2014-07-02 Thread Mark Lawrence
Mark Lawrence added the comment: Presumably the changes made in the default branch referred to in msg179037 will have automatically been carried forward to 3.4 and 3.5. -- nosy: +BreamoreBoy versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 _

[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

2013-01-04 Thread Brian Curtin
Brian Curtin added the comment: That's true of the default branch due to some changes I recently made in the implementation of the functions, but we should probably put tests into 3.2/3.3. -- ___ Python tracker __

[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

2013-01-04 Thread Ronald Oussoren
Ronald Oussoren added the comment: There are tests for samefile and sameopenfile in test_genericpath.GenericTest which is included by test_ntpath (NtCommonTest subclasses test_genericpath.CommonTest which again subclasses GenericTest). I cannot easily test on Windows (the only windows systems

[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

2013-01-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- components: +Tests -Library (Lib) ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

2011-05-16 Thread Sijin Joseph
Changes by Sijin Joseph : -- nosy: -sijinjoseph ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

2011-05-12 Thread Santoso Wijaya
Santoso Wijaya added the comment: Attaching a patch to test a use case for ntpath.samefile (looks like sameopenfile is already tested--or at least a use case of it). -- components: +Library (Lib) keywords: +patch nosy: +santa4nt versions: -Python 3.4 Added file: http://bugs.python.org

[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

2011-05-11 Thread Sijin Joseph
Changes by Sijin Joseph : -- nosy: +sijinjoseph ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

2011-05-06 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: +brian.curtin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue12018] No tests for ntpath.samefile, ntpath.sameopenfile

2011-05-06 Thread Ronald Oussoren
New submission from Ronald Oussoren : Python 3.2 introduced ntpath.samefile, but the implementation is not tested in test_ntpath.py. The same seems true of ntpath.sameopenfile. As noted in #10684 ntpath.samefile is broken on XP, which would have been caught by unittest. I've committed a fix fo