[issue11927] SMTP_SSL doesn't use port 465 by default

2011-05-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: The patch was committed in dev and maintenance branches. Thank you! -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___

[issue11927] SMTP_SSL doesn't use port 465 by default

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset bcf04ced5ef1 by Antoine Pitrou in branch '2.7': Issue #11927: SMTP_SSL now uses port 465 by default as documented. Patch by Kasun Herath. http://hg.python.org/cpython/rev/bcf04ced5ef1 -- ___ Python tra

[issue11927] SMTP_SSL doesn't use port 465 by default

2011-05-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset 20e9d3e49689 by Antoine Pitrou in branch '3.1': Issue #11927: SMTP_SSL now uses port 465 by default as documented. Patch by Kasun Herath. http://hg.python.org/cpython/rev/20e9d3e49689 New changeset 209744660b92 by Antoine Pitrou in branch '3.2':

[issue11927] SMTP_SSL doesn't use port 465 by default

2011-05-07 Thread Kasun Herath
Kasun Herath added the comment: I'm submitting another patch which includes a test in test_smtpnet. Would appreciate further feedback. -- Added file: http://bugs.python.org/file21927/smtp_default_port_with_smtpnet_test.patch ___ Python tracker

[issue11927] SMTP_SSL doesn't use port 465 by default

2011-05-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Should we add a unit test for this as well? True, a simple test could be added to test_smtpnet. -- ___ Python tracker ___ __

[issue11927] SMTP_SSL doesn't use port 465 by default

2011-04-27 Thread Sijin Joseph
Sijin Joseph added the comment: Should we add a unit test for this as well? -- nosy: +sijinjoseph ___ Python tracker ___ ___ Python-b

[issue11927] SMTP_SSL doesn't use port 465 by default

2011-04-27 Thread Kasun Herath
Kasun Herath added the comment: I did a quick patch based on the suggested solution. (pitrou, thanks for adding to the nosy list or could have missed this) -- keywords: +patch Added file: http://bugs.python.org/file21794/smtplib_default_ports.patch

[issue11927] SMTP_SSL doesn't use port 465 by default

2011-04-26 Thread Antoine Pitrou
New submission from Antoine Pitrou : The SMTP_SSL doc says “If port is omitted, the standard SMTP-over-SSL port (465) is used”, but actually port 25 is used by default. The fix is trivial: make "default_port" a class attribute (in both SMTP and SMTP_SSL) instead of setting it inside the constr