[issue1186900] nntplib shouldn't raise generic EOFError

Irit Katriel added the comment: nntplib is deprecated as per PEP 594, so there won't be further enhancements to it. -- nosy: +iritkatriel resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue1186900] nntplib shouldn't raise generic EOFError

Martin Panter added the comment: Quick survey of other communication protocol modules: ftplib: uses EOFError; not documented http.client: custom IncompleteRead exception imaplib: custom IMAP4.abort exception poplib: custom error_proto exception smtplib: SMTPServerDisconnected exception, subclass

[issue1186900] nntplib shouldn't raise generic EOFError

Lita Cho added the comment: Thank yo so much, Martin! I will incorporate these changes and add them soon! -- ___ Python tracker ___

[issue1186900] nntplib shouldn't raise generic EOFError

Martin Panter added the comment: PPS: Documentation should probably have the “New in version 3.5” tag as well -- ___ Python tracker ___

[issue1186900] nntplib shouldn't raise generic EOFError

Martin Panter added the comment: Some more points: * I suggest adding something like this to the documentation: exception nntplib.NNTPConnect[ion]Error Exception raised when the server unexpectedly shuts down the connection. * The tests should use BytesIO rather than StringIO. Other than tha

[issue1186900] nntplib shouldn't raise generic EOFError

Martin Panter added the comment: NNTPConnectError does still seem a slightly awkward name. I would go for NNTPConnectionError instead, but I’m also happy to put my bikeshed paint away let this patch be applied as is :) Handling of NNTPTemporaryError with a code of 400 is similar to handling of

[issue1186900] nntplib shouldn't raise generic EOFError

Lita Cho added the comment: I'ved changed the comment to say Connection closed unexpectedly. -- Added file: http://bugs.python.org/file36264/nntplib_error_v2.patch ___ Python tracker _

[issue1186900] nntplib shouldn't raise generic EOFError

Antoine Pitrou added the comment: Indeed, I find the description rather vague and potentially misleading. "Connection establishment" would usually refer to the TCP connection, but an EOFError is actually a high-level, logical error (it has nothing to do with networking per se: it's probably mo

[issue1186900] nntplib shouldn't raise generic EOFError

Martin Panter added the comment: I could be wrong, but isn’t this error raised when expecting a response from any command, not just during “connection establishment”? Perhaps change the docstring to say something like “Connection closed unexpectedly” instead. -- nosy: +vadmium ___

[issue1186900] nntplib shouldn't raise generic EOFError

Lita Cho added the comment: Here is an updated patch. -- Added file: http://bugs.python.org/file35941/nntplib_error.patch ___ Python tracker ___ ___

[issue1186900] nntplib shouldn't raise generic EOFError

Lita Cho added the comment: That's a good point. I can add that so the NNTPConnectError can inherit the EOFError -- ___ Python tracker ___

[issue1186900] nntplib shouldn't raise generic EOFError

Ezio Melotti added the comment: Wouldn't this be backward incompatible? Even if the EOFError that is raised is not documented explicitly, people might be catching it, and switching to a new exception would break their programs. Maybe NNTPConnectError should inherit from EOFError too?

[issue1186900] nntplib shouldn't raise generic EOFError

Berker Peksag added the comment: diff -r 8f85262fbe8a Lib/nntplib.py --- a/Lib/nntplib.pySun Jul 06 02:24:24 2014 -0400 +++ b/Lib/nntplib.pyThu Jul 10 16:10:38 2014 -0700 @@ -122,6 +122,9 @@ """Error in response data""" pass +class NNTPConnectError(NNTPError): +"""Error du

[issue1186900] nntplib shouldn't raise generic EOFError

Changes by Jessica McKellar : -- keywords: +needs review stage: test needed -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue1186900] nntplib shouldn't raise generic EOFError

Lita Cho added the comment: I have a fix and added some test coverage in order to make sure the NNTFConnectError was being called. However, in the test case, I am monkey patching. If there is a way to do this with mock, I would appreciate the feedback. -- keywords: +patch Added file:

[issue1186900] nntplib shouldn't raise generic EOFError

Lita Cho added the comment: I am going to fix it so that it raises the NNTPConnectionError rather than update the documentation. -- nosy: +Lita.Cho, jesstess ___ Python tracker __

[issue1186900] nntplib shouldn't raise generic EOFError

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue1186900] nntplib shouldn't raise generic EOFError

Changes by Ankur Ankan : -- nosy: +Ankur.Ankan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue1186900] nntplib shouldn't raise generic EOFError

Mark Lawrence added the comment: The OP would accept a documentation change if the code's not going to be changed. -- nosy: +BreamoreBoy versions: +Python 3.2 -Python 2.7 ___ Python tracker

[issue1186900] nntplib shouldn't raise generic EOFError

Changes by Daniel Diniz : -- stage: -> test needed versions: +Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list U