[issue11826] Leak in atexitmodule

Changes by Stefan Krah : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: -Python 3.2 ___ Python tracker ___ _

[issue11826] Leak in atexitmodule

Roundup Robot added the comment: New changeset 7c48bb929e6e by Stefan Krah in branch 'default': Issue #11826: Fix memory leak in atexitmodule. http://hg.python.org/cpython/rev/7c48bb929e6e -- nosy: +python-dev ___ Python tracker

[issue11826] Leak in atexitmodule

Stefan Krah added the comment: Actually _iomodule.c already has a freefunc with the same signature. atexit_free() is properly called in: static void module_dealloc(PyModuleObject *m) { PyObject_GC_UnTrack(m); if (m->md_def && m->md_def->m_free) m->md_def->m_free(m); if (m->m

[issue11826] Leak in atexitmodule

Stefan Krah added the comment: Antoine Pitrou wrote: > Well, if it doesn't crash, it's probably ok ;) > Perhaps check modstate->atexit_callbacks for non-NULL? > Or do we trust free() to do the right thing? I was initially surprised by this, but the docs state that it's safe: http://docs.pytho

[issue11826] Leak in atexitmodule

Antoine Pitrou added the comment: Well, if it doesn't crash, it's probably ok ;) Perhaps check modstate->atexit_callbacks for non-NULL? Or do we trust free() to do the right thing? -- nosy: +pitrou ___ Python tracker

[issue11826] Leak in atexitmodule

Amaury Forgeot d'Arc added the comment: It's the very first usage of PyModuleDef::m_free. Martin, do you agree with the path? -- nosy: +amaury.forgeotdarc, loewis ___ Python tracker ___

[issue11826] Leak in atexitmodule

New submission from Stefan Krah : Valgrind reports a leak (definitely lost) in atexitmodule.c. The patch fixes the problem. -- components: Extension Modules files: atexit-leak.patch keywords: patch messages: 133501 nosy: skrah priority: normal severity: normal stage: patch review status: