[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Changes by Berker Peksag : -- resolution: -> fixed stage: needs patch -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Changes by Doug Hellmann : -- nosy: +doughellmann ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Jason R. Coombs added the comment: The changes to the default branch seem to have cleaned up the test failures on most platforms (still waiting on the ARM results). So I've backported the test skips to the Python 2.7 branch as well. -- ___ Python t

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Roundup Robot added the comment: New changeset 9b681e0c04ed by Jason R. Coombs in branch '2.7': Limit test scope to those platforms that can save the target filenames. Reference #11638. http://hg.python.org/cpython/rev/9b681e0c04ed -- ___ Python tra

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Jason R. Coombs added the comment: I've limited the scope of the patch to attempt to only test on those platforms that can actually create unicode-named files. I'll watch the buildbots to see if that corrects the failures (since I don't have the failing platforms available to me). --

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Roundup Robot added the comment: New changeset a7744f778646 by Jason R. Coombs in branch 'default': Limit test scope to those platforms that can save the target filenames. Reference #11638. http://hg.python.org/cpython/rev/a7744f778646 -- ___ Python

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Jason R. Coombs added the comment: > That's a shame. I tested it in advance. I'll correct or revert tonight or > tomorrow. -- title: python setup.py sdist --formats tar* crashes if version is unicode -> python setup.py sdist --formats tar* crashes if versionis unicode Added file:

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Benjamin Peterson added the comment: f0fcb82a88e9 broke bots. See http://www.python.org/dev/buildbot/all/builders/x86%20Gentoo%203.x/builds/1374/steps/test/logs/stdio -- nosy: +benjamin.peterson ___ Python tracker

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Jason R. Coombs added the comment: Since the tests now pass, and the only changes were to the tests, I've pushed them to the master. And with that I'm marking this ticket as closed. -- status: open -> closed ___ Python tracker

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Roundup Robot added the comment: New changeset f0fcb82a88e9 by Jason R. Coombs in branch 'default': Ported some test cases from 2.7 for #11638 http://hg.python.org/cpython/rev/f0fcb82a88e9 -- ___ Python tracker __

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Roundup Robot added the comment: New changeset dc1045d08bd8 by Jason R. Coombs in branch '2.7': Issue #11638: Adding test to ensure .tar.gz files can be generated by sdist command with unicode metadata, based on David Barnett's patch. http://hg.python.org/cpython/rev/dc1045d08bd8 -- no

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Changes by Jason R. Coombs : Added file: http://bugs.python.org/file24095/dc1045d08bd8.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Jason R. Coombs added the comment: I've captured the cause of the UnicodeEncodeErrors as #13664. After rebasing the changes to include the fix for #13639, I found that the tests were still failing until I also reverted the patch to call tarfile.open with 'w:gz'. Now all the new tests pass (wi

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Jason R. Coombs added the comment: Thanks to Lars for suggesting the fix, replacing 'w|gz' with 'w:gz'. I attempted this change in the latest revision of my fork (774933cf7775.diff). While this change does address the issue if a unicode string is passed which can be encoded using the default

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Changes by Jason R. Coombs : -- keywords: +patch Added file: http://bugs.python.org/file24092/774933cf7775.diff ___ Python tracker ___ ___

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Lars Gustäbel added the comment: Just for the record: The gzip format (defined in RFC 1952) allows storing the original filename (without the .gz suffix) in an additional field in the header (the FNAME field). Latin-1 (iso-8859-1) is required. It is ironic that this causes so much trouble, b

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Jason R. Coombs added the comment: > > Encoding to 'utf-8' or the default file system encoding doesn't seem > > right (as the characters end up getting stored in the gzip archive itself). > I don’t understand. The characters are being stored in the gzip archive as part of the gzip header. The

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Éric Araujo added the comment: Lars: I will check the history to see if there is a reason (there is probably none) and apply your patch, thank you. Jason: Thanks for the input. > It's not obvious to me what the encoding should be. Python and the tarfile > module can > accept unicode filename

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Lars Gustäbel added the comment: Is there a good reason why the tarfile mode that is used is "w|gz"? It seems to me that this is not necessary, "w:gz" should be enough. "w|gz" is for special operations only (see the tarfile docs). -- nosy: +lars.gustaebel Added file: http://bugs.pytho

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Changes by Jason R. Coombs : Added file: http://bugs.python.org/file24059/9e9ea96eb0dd.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Jason R. Coombs added the comment: I've created a repo to continue this work. I've integrated David's patch (thanks). It's not obvious to me what the encoding should be. Python and the tarfile module can accept unicode filenames. It seems that only the gzip part of tarfile fails if a unicode

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Jason R. Coombs added the comment: I believe the underlying cause of this issue is #13639. -- ___ Python tracker ___ ___ Python-bugs-

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Jason R. Coombs added the comment: This error is also encountered if the package name is unicode. The error can be simply reproduced with this command: python -c "from setuptools import setup; setup(name=u'foo')" sdist --formats gztar The error also occurs with the bdist command, and probabl

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Jason R. Coombs added the comment: I meant to paste the repro with distutils.core: python -c "from distutils.core import setup; setup(name=u'foo')" sdist --formats gztar -- ___ Python tracker ___

[issue11638] python setup.py sdist --formats tar* crashes if version is unicode

Éric Araujo added the comment: > since the issue only applies when sdist --format gztar, I mention that here. bztar will probably have the same issue. > Also, issue8396 suggests encoding using sys.getfilesystemencoding(). Good one! -- title: python setup.py sdist crashes if version is