[issue11582] Boilerplate code replaced in Python/ceval.c

2015-07-03 Thread A.M. Kuchling
A.M. Kuchling added the comment: Closing, because neither Amaury nor Raymond likes the idea. Thanks for your work, anyway! -- nosy: +akuchling resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker

[issue11582] Boilerplate code replaced in Python/ceval.c

2014-10-04 Thread Francis MB
Changes by Francis MB : -- type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue11582] Boilerplate code replaced in Python/ceval.c

2011-03-17 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- priority: normal -> low versions: -Python 3.1, Python 3.2, Python 3.4 ___ Python tracker ___ ___ Py

[issue11582] Boilerplate code replaced in Python/ceval.c

2011-03-17 Thread Raymond Hettinger
Raymond Hettinger added the comment: -1 I think this will make the code harder to understand and maintain. -- nosy: +rhettinger ___ Python tracker ___ _

[issue11582] Boilerplate code replaced in Python/ceval.c

2011-03-17 Thread knickerkicker
knickerkicker added the comment: Creating a inline function would require passing the stackpointer variable so that the TOP() and POP() macros continue working, and creating variables for u, v and x. I am not sure if that will not have a performance impact - ideally it shouldn't, but can we tr

[issue11582] Boilerplate code replaced in Python/ceval.c

2011-03-17 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue11582] Boilerplate code replaced in Python/ceval.c

2011-03-17 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: Hmm, this kind of macros make it difficult to step line by line in a debugger. From this point of view, an inlined function would be better, I'm not sure if this can have a performance impact though. -- nosy: +amaury.forgeotdarc ___

[issue11582] Boilerplate code replaced in Python/ceval.c

2011-03-17 Thread knickerkicker
New submission from knickerkicker : Replaced boilerplate implementations of several BINARY_* and INPLACE_* opcodes with two macros. The result shaves off 154 lines from Python/ceval.c. -- components: Interpreter Core files: 20110317_ceval.patch keywords: patch messages: 131230 nosy: kni