[issue11563] test_urllibnet is triggering a ResourceWarning

2013-12-03 Thread Martin Panter
Martin Panter added the comment: I think the fix for this bug only works if it gets the server to respond with a “Connection: close” header itself. I opened Issue 19524 because I was seeing keep-alive responses using chunked encoding that still trigger a socket leak. -- nosy: +vadmium

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 53c8f2bd0316 by Senthil Kumaran in branch '3.2': Add NEWS for Issue #11563. http://hg.python.org/cpython/rev/53c8f2bd0316 -- ___ Python tracker _

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Victor - Issue9740 and Issue3566 talks about the need to have persistent connection. 3.3 would be a good target to have this feature in. Shall add the NEWS entry. Nadeem Vawda - Thanks for your patch. I committed the fix as part of another bug (Issue3566). I

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-19 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- Removed message: http://bugs.python.org/msg131456 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Victor - Issue9740 and Issue3566 talks about the need to have persistent connection. 3.3 would be a good target to have this feature in. Shall add the NEWS entry. Nadeen Wadwa - Thanks for your patch. I committed the fix as part of another bug (Issue3566). I

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-19 Thread Nadeem Vawda
Nadeem Vawda added the comment: urlopen_HttpTests.test_willclose() fails to call unfakehttp(), which breaks subsequent runs of test_urllib2_localnet, test_urllib2net and test_urllibnet. Fix attached. -- Added file: http://bugs.python.org/file21292/unfakehttp.diff

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-19 Thread STINNER Victor
STINNER Victor added the comment: @Senthil Kumaran: Because your patch touchs not only the test, can you document your change in Misc/NEWS? Sending a new HTTP header should be documented. Is there an issue to support persistent connections in AbstractHTTPHandler.do_open()? -- __

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-19 Thread Roundup Robot
efault': Closes issue11563 test_urllibnet is triggering a ResourceWarning. Patch by Jeff McNeil. http://hg.python.org/cpython/rev/dfceb98767c0 -- nosy: +python-dev resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed _

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-18 Thread Nadeem Vawda
Nadeem Vawda added the comment: issue10883 is related; test_urllib2net also leaves sockets open in several places. -- nosy: +haypo, nvawda ___ Python tracker ___ __

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-17 Thread Jeff McNeil
Jeff McNeil added the comment: Sounds good. I'll look at doing that, too. -- versions: +Python 3.3 ___ Python tracker ___ ___ Python-

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Thu, Mar 17, 2011 at 06:30:51PM +, Jeff McNeil wrote: > I went down the same path as AbstractHTTPHandler and added a Connection: > close header. This is fine for the moment, tough I wish that the TODO pending in urllib.request with HTTP1.1 persisten

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-17 Thread Jeff McNeil
Jeff McNeil added the comment: So, it turned out to be more complicated than that. The HTTPConnection object returns an HTTPResponse, but never closes the underlying socket after calling makesock. Since persistent connections aren't supported, nothing actually closes the socket itself, it

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, go ahead with the patch. -- nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list mail

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-16 Thread Jeff McNeil
Jeff McNeil added the comment: So, I've been meaning to get more into contributing back to Python and I found this one somewhat interesting. As it turns out, even the following simple script raises the same warning: [jeff@martian cpython]$ ./python -c 'import urllib.request; urllib.request.

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-16 Thread Jeff McNeil
Changes by Jeff McNeil : -- nosy: +mcjeff ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-15 Thread Brett Cannon
New submission from Brett Cannon : test.test_urllibnet.urlopenNetworkTests.test_getcode() is leaving a socket open. My guess is that the error condition being triggered is somehow leaving the socket open but I can't find where. -- components: Library (Lib) messages: 131059 nosy: brett.