[issue11557] Increase coverage in logging module

Changes by Vinay Sajip : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue11557] Increase coverage in logging module

Roundup Robot added the comment: New changeset 44139ece7a31 by Vinay Sajip in branch 'default': Closes issue #11557: removal of non-idiomatic code in test_logging. http://hg.python.org/cpython/rev/44139ece7a31 -- ___ Python tracker

[issue11557] Increase coverage in logging module

Changes by Éric Araujo : -- assignee: trentm -> vinay.sajip nosy: -trentm ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue11557] Increase coverage in logging module

Éric Araujo added the comment: I saw this commit pass by and noticed a few instances of non-idiomatic unittest code, like unnecessary lambdas or overuse of assertEqual where other methods would give more useful messages in case of failure. Here’s a patch to better it. -- assignee: v

[issue11557] Increase coverage in logging module

Vinay Sajip added the comment: Marking as closed, since d93e18e6a3e8 now appears to pass on all 3.x buildbots. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue11557] Increase coverage in logging module

STINNER Victor added the comment: > > This issue is not fixed: the test does still fail... sometimes. Recent > > example > >(AMD64 FreeBSD 8.2 3.x buildbot): > > Yes, I know it's not fixed yet - I'm still working on it. (...) I realized just after writing my message that the last (commit)

[issue11557] Increase coverage in logging module

Vinay Sajip added the comment: Hi Victor, - Original Message > From: STINNER Victor > To: vinay_sa...@yahoo.co.uk > Sent: Wed, 20 April, 2011 11:20:11 > Subject: [issue11557] Increase coverage in logging module > > > STINNER Victor added the comment: > &

[issue11557] Increase coverage in logging module

Roundup Robot added the comment: New changeset d93e18e6a3e8 by Vinay Sajip in branch 'default': Attempt fix of #11557 by refining test logic. http://hg.python.org/cpython/rev/d93e18e6a3e8 -- ___ Python tracker ___

[issue11557] Increase coverage in logging module

Roundup Robot added the comment: New changeset 0494afdc8615 by Vinay Sajip in branch 'default': Attempt fix of #11557 by refining setup/teardown logic. http://hg.python.org/cpython/rev/0494afdc8615 -- ___ Python tracker

[issue11557] Increase coverage in logging module

Roundup Robot added the comment: New changeset 31bb4788aa1c by Vinay Sajip in branch 'default': Attempt fix of #11557 by changing setup/teardown logic. http://hg.python.org/cpython/rev/31bb4788aa1c -- ___ Python tracker

[issue11557] Increase coverage in logging module

STINNER Victor added the comment: This issue is not fixed: the test does still fail... sometimes. Recent example (AMD64 FreeBSD 8.2 3.x buildbot): -- (...) [283/354] test_logging Warning -- logging._handlerList was modified by

[issue11557] Increase coverage in logging module

Roundup Robot added the comment: New changeset 41dc66528c4e by Vinay Sajip in branch 'default': Attempt fix of #11557 by changing teardown logic. http://hg.python.org/cpython/rev/41dc66528c4e -- ___ Python tracker

[issue11557] Increase coverage in logging module

STINNER Victor added the comment: test_logging.test_no_kwargs fails on AMD64 Snow Leopard 2 3.x, x86 Ubuntu Shared 3.x, sparc solaris10 gcc 3.x, AMD64 Leopard 3.x, x86 XP-4 3.x, x86 Windows7 3.x, x86 Tiger 3.x, PPC Tiger 3.x, ... I disabled the test because it became difficult to see new regr

[issue11557] Increase coverage in logging module

Roundup Robot added the comment: New changeset 024967cdc2f0 by Victor Stinner in branch 'default': Issue #11557: disable test_logging.test_no_kwargs (fail on most buildbots) http://hg.python.org/cpython/rev/024967cdc2f0 -- ___ Python tracker

[issue11557] Increase coverage in logging module

Natalia B. Bidart added the comment: I'll work on a fix during next weekend (sooner if I have an open slot). -- ___ Python tracker ___ __

[issue11557] Increase coverage in logging module

R. David Murray added the comment: This seems to be causing some issues on the buildbots: http://www.python.org/dev/buildbot/all/builders/AMD64%20Snow%20Leopard%202%203.x/builds/137 -- nosy: +r.david.murray status: closed -> open ___ Python tracker

[issue11557] Increase coverage in logging module

Vinay Sajip added the comment: Closing, thanks for the patch. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue11557] Increase coverage in logging module

Roundup Robot added the comment: New changeset c7f7672b70a9 by Vinay Sajip in branch 'default': Closes issue #11557: Added Natalia Bidart's patch to improve test coverage. http://hg.python.org/cpython/rev/c7f7672b70a9 -- nosy: +python-dev ___ Python

[issue11557] Increase coverage in logging module

Changes by Gennadiy Zlobin : -- nosy: +gennad ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue11557] Increase coverage in logging module

Changes by Vinay Sajip : -- nosy: +drakeol ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue11557] Increase coverage in logging module

Changes by Vinay Sajip : -- assignee: -> vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue11557] Increase coverage in logging module

Natalia B. Bidart added the comment: Attaching a patch that increases test coverage for logging/__init__.py by 12%. There are still a lot more to do, but this pacth is big enough. -- keywords: +patch Added file: http://bugs.python.org/file21249/pycon-issue11557.patch _

[issue11557] Increase coverage in logging module

Changes by R. David Murray : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue11557] Increase coverage in logging module

New submission from Natalia B. Bidart : Current coverage is: Name Stmts Miss Cover -- Lib/logging/__init__ 73916278% Lib/logging/config 571 9883% Lib/logging/handlers 60132546%