[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

Roundup Robot added the comment: New changeset 68a257ca6be6 by Benjamin Peterson in branch '3.3': improve set_tunnel docs (closes #11448) http://hg.python.org/cpython/rev/68a257ca6be6 New changeset 5cab0ada97b2 by Benjamin Peterson in branch 'default': merge 3.3 (#11448) http://hg.python.org/cpy

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

Nikolaus Rath added the comment: Apologies, I missed that. I'll be more careful in the future. I've attached an updated patch that also adds some extra Sphinx markup, but should IMO still be credited to Ryan and Karl. -- Added file: http://bugs.python.org/file33674/issue11448_r3.patch

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

karl added the comment: ooops right, my bad. s/on port 8080. We first/on port 8080, we first/ better? -- ___ Python tracker ___ ___

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

Georg Brandl added the comment: The first sentence of the second new paragraph is a bit ungrammatical, right? -- ___ Python tracker ___ __

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

Nikolaus Rath added the comment: The patches look fine to me. They are only docpatches, so no testcase is needed. I have rebased them on current hg tip to avoid fuzz, but otherwise left them unchanged. I think this is ready to be committed. -- nosy: +ezio.melotti, georg.brandl version

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

Changes by Nikolaus Rath : -- type: -> enhancement versions: +Python 3.4, Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mail

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

Nikolaus Rath added the comment: Is there anything that needs to be done to get this patch applied? It would be nice if this could be committed together with the patch in issue 7776. -- nosy: +Nikratio ___ Python tracker

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

karl added the comment: ok made a proper patch on the rst file with hg diff. See issue-11448-1.patch -- Added file: http://bugs.python.org/file29293/issue-11448-1.patch ___ Python tracker __

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

karl added the comment: Ah thanks Eric, I will fix that. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

Éric Araujo added the comment: > This is a possible additional example for set_tunnel, Thanks. In general, our tooling expects unified diffs, such as produced by hg diff. > modification of python3.3/html/_sources/library/http.client.txt That’s a copy for web hosting, the real source is in Doc

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

karl added the comment: This is a possible additional example for set_tunnel, modification of python3.3/html/_sources/library/http.client.txt Hope it helps. -- nosy: +karlcow Added file: http://bugs.python.org/file29243/http.client.patch ___ Python

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

Michael Stahn added the comment: I thought the same as Ryan when reading the API. The best way would have been to call "set_tunnel" -> "set_proxy" and to implement the behaviour you expect on this: setting a proxy. There are some more places at this code which are not quite clear eg: def puth

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

Ryan Kelly added the comment: Sorry, "endpoint" is just a noun that seemed to fit for me, I've no idea if there is a standard term for this. Perhaps "origin server" if you follow the terminology from the RFC? By way of example, suppose I'm running a proxy on localhost:3128 and I want to tun

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

Senthil Kumaran added the comment: I am not able to understand what you mean by 'endpoint'. Actually, when using tunnels people understand that they often 'tunnel through' the proxy server and here is an example code from the tests which is going to use the set_tunnel method. ph = urllib.req

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

New submission from Ryan Kelly : The docs for HTTPConnection.set_tunnel(host,port) are ambiguous. They simply say "Set the host and the port for HTTP Connect Tunnelling". But should I specify the address of the server *through* which I want to tunnel, or the address of the *endpoint* of the