[issue11390] doctest: add cmdline parameters

R. David Murray added the comment: Fixed for this test. It would probably be worthwhile to improve script_helpers, I'll open a new issue for that. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue11390] doctest: add cmdline parameters

Roundup Robot added the comment: New changeset 8f22e03f5f07 by R David Murray in branch 'default': #11390: fix test failures due to readline and windows lineneds. http://hg.python.org/cpython/rev/8f22e03f5f07 -- ___ Python tracker

[issue11390] doctest: add cmdline parameters

STINNER Victor added the comment: > Perhaps the dummy trick needs to be done by doctest itself? The issue really comes from the readline module. The workaround is to set an environment variable, which affects the whole process (all threads). Only setting TERM for test_CLI() is fine, because it

[issue11390] doctest: add cmdline parameters

STINNER Victor added the comment: > As for the windows failures, my apologies. I knew I would need to check > windows after the commit when I wrote the code, but I forgot to actually do > it. No problem, it's so easy to forget Windows :-) And we have buildbots for this task (detect regression

[issue11390] doctest: add cmdline parameters

R. David Murray added the comment: It is implemented as a doctest because everything else in that test module is implemented as a doctest. And clearly this reveals a bug of some sort. Perhaps the dummy trick needs to be done by doctest itself? (I will need to read your post over more carefu

[issue11390] doctest: add cmdline parameters

STINNER Victor added the comment: test_doctest.test_CLI() is also failing on Windows: http://buildbot.python.org/all/builders/x86%20Windows%20Server%202003%20%5BSB%5D%203.x/builds/1078/steps/test/logs/stdio It looks like an issue with Windows newline (\r\n) versus UNIX newline (\n). test_CLI()

[issue11390] doctest: add cmdline parameters

STINNER Victor added the comment: Attached doctest_term_dummy.patch: workaround the issue by setting TERM env var to "dummy". Why is test_CLI() implemented using a doctest? Why not reusing the unittest module to benefit from test.support and test.regrtest? (Hint: I don't like doctests :-)) -

[issue11390] doctest: add cmdline parameters

STINNER Victor added the comment: The new tests added in changeset ae802dc4dcd4 are failing on some buildbots. I can reproduce the issue on my Linux box (Fedora 18). First failure of "./python -m test test_doctest": [1/1] test_doctest ***

[issue11390] doctest: add cmdline parameters

R. David Murray added the comment: Committed. Thanks for the review, Barry. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue11390] doctest: add cmdline parameters

Roundup Robot added the comment: New changeset ae802dc4dcd4 by R David Murray in branch 'default': #11390: convert doctest CLI to argparse and add -o and -f options. http://hg.python.org/cpython/rev/ae802dc4dcd4 -- nosy: +python-dev ___ Python tracker

[issue11390] doctest: add cmdline parameters

R. David Murray added the comment: Patch updated per Barry's review comments. -- Added file: http://bugs.python.org/file30667/doctest_cli.patch ___ Python tracker ___ ___

[issue11390] doctest: add cmdline parameters

R. David Murray added the comment: I will probably commit this tomorrow if there are no objections. -- ___ Python tracker ___ ___ Pyth

[issue11390] doctest: add cmdline parameters

R. David Murray added the comment: Patch updated with documentation. -- stage: needs patch -> patch review Added file: http://bugs.python.org/file30655/doctest_cli.patch ___ Python tracker _

[issue11390] doctest: add cmdline parameters

Changes by R. David Murray : Removed file: http://bugs.python.org/file30654/doctest_cli.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue11390] doctest: add cmdline parameters

R. David Murray added the comment: Oh, a documentation update is still needed here, so I guess I'm not really ready for review yet :( -- stage: patch review -> needs patch ___ Python tracker __

[issue11390] doctest: add cmdline parameters

R. David Murray added the comment: Here is a patch that implements the ones I'm interested in (-o for any option, and -f as a shortcut for -o FAIL_FAST). It's a good question whether doctest should support other unittest options, but doing so is more complicated than supporting -o and -f. Ad

[issue11390] doctest: add cmdline parameters

Changes by Éric Araujo : -- stage: -> needs patch type: -> feature request versions: +Python 3.3 -Python 2.7, Python 3.2 ___ Python tracker ___

[issue11390] doctest: add cmdline parameters

New submission from anatoly techtonik : doctest module need to parse -h/--help parameters, and accept flags like ELLIPSIS from command line. Otherwise it very hard to debug tests like contained in the attached README. It is also worth to make it parameter compatible with unittest.main() Usage