[issue11335] Memory leak after key function failure in sort

Changes by Daniel Stutzbach : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue11335] Memory leak after key function failure in sort

Roundup Robot added the comment: New changeset 52fb7dc721ed by Daniel Stutzbach in branch '3.2': #11335: Fix memory leak after key function failure in sort http://hg.python.org/cpython/rev/52fb7dc721ed New changeset 18e43c6acfff by Daniel Stutzbach in branch 'default': #11335: Merge from 3.2: F

[issue11335] Memory leak after key function failure in sort

Georg Brandl added the comment: Sure, Wednesday will be fine. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue11335] Memory leak after key function failure in sort

Daniel Stutzbach added the comment: I checked in a fix to 3.3 just before the transition to hg. I confess that I've been procrastinating on getting hg set up properly, which is why I haven't gotten to checking this in to 3.2. Georg, if I get this in by Wednesday, will that be soon enough for

[issue11335] Memory leak after key function failure in sort

Daniel Stutzbach added the comment: I played around with this a little. That code path doesn't appear to be exercised during the existing unit tests. I'll add a test so the leak at least shows up when the tests are run under valgrind. -- ___ Pyth

[issue11335] Memory leak after key function failure in sort

Daniel Stutzbach added the comment: I meant "to *detect* leaked memory", of course. :-) -- ___ Python tracker ___ ___ Python-bugs-lis

[issue11335] Memory leak after key function failure in sort

Daniel Stutzbach added the comment: I'm not sure. What infrastructure do we have to leaked memory that was allocated with PyMem_MALLOC? -- ___ Python tracker ___ _

[issue11335] Memory leak after key function failure in sort

Antoine Pitrou added the comment: Valgrind perhaps? If the "keys" container was a list or tuple it would simply take a refleak run of the test suite. -- ___ Python tracker ___

[issue11335] Memory leak after key function failure in sort

Raymond Hettinger added the comment: Is there a way to test this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue11335] Memory leak after key function failure in sort

Benjamin Peterson added the comment: LGTM -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue11335] Memory leak after key function failure in sort

Daniel Stutzbach added the comment: Below is a link to the code where leak occurs and the patch goes: http://svn.python.org/view/python/branches/py3k/Objects/listobject.c?view=markup&pathrev=88554#l1944 -- keywords: +3.2regression, needs review, patch Added file: http://bugs.python.org

[issue11335] Memory leak after key function failure in sort

New submission from Daniel Stutzbach : In list.sort, if a key function throws an exception, the memory to store the keys is never freed. I introduced the bug in r86937. I'll upload a patch for review shortly. -- assignee: stutzbach components: Interpreter Core messages: 129574 nosy: