[issue11322] encoding package's normalize_encoding() function is too slow

Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue11322] encoding package's normalize_encoding() function is too slow

STINNER Victor added the comment: Oh, while reading Mercurial history, I found a note that I wrote: "It's not exactly the same than encodings.normalize_encoding(): the C function also converts to lowercase." IHMO it's fine to modify encodings.normalize_encoding() to also convert to lower-case

[issue11322] encoding package's normalize_encoding() function is too slow

STINNER Victor added the comment: It seems like encodings.normalize_encoding() currently has no unit test! Before modifying it, I would prefer to see a few unit tests: * " utf 8 " * "UtF 8" * "utf8\xE9" * etc. Since we are talking about an optimmization, I would like to see a benchmark result

[issue11322] encoding package's normalize_encoding() function is too slow

Marc-Andre Lemburg added the comment: Thanks for the patch. Victor has implemented the function in C, AFAIK, so an even better approach would be to expose that function at the Python level and use it in the encodings package. -- versions: +Python 3.7 -Python 3.4, Python 3.5 _

[issue11322] encoding package's normalize_encoding() function is too slow

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue11322] encoding package's normalize_encoding() function is too slow

Changes by INADA Naoki : -- keywords: +patch Added file: http://bugs.python.org/file45909/encoding_normalize_optimize.patch ___ Python tracker ___ ___

Re: [issue11322] encoding package's normalize_encoding() function is too slow

On 15.06.2014 15:02, Mark Lawrence wrote: > > What's the status of this issue, as we've lived with this really slow > implementation for well over three years? I guess it just needs someone to write a patch. Note that encoding lookups are cached, so the slowness only becomes an issue if you loo

[issue11322] encoding package's normalize_encoding() function is too slow

Mark Lawrence added the comment: What's the status of this issue, as we've lived with this really slow implementation for well over three years? -- nosy: +BreamoreBoy versions: +Python 3.4, Python 3.5 -Python 3.3 ___ Python tracker

[issue11322] encoding package's normalize_encoding() function is too slow

Serhiy Storchaka added the comment: > I don't know who changed the encoding's package normalize_encoding() function > (wasn't me), but it's a really slow implementation. See changeset 54ef645d08e4. -- nosy: +storchaka ___ Python tracker

[issue11322] encoding package's normalize_encoding() function is too slow

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue11322] encoding package's normalize_encoding() function is too slow

Changes by Steffen Daode Nurpmeso : -- nosy: +sdaoden ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue11322] encoding package's normalize_encoding() function is too slow

Marc-Andre Lemburg added the comment: STINNER Victor wrote: > > STINNER Victor added the comment: > > We should first implement the same algorithm of the 3 normalization functions > and add tests for them (at least for the function in normalization): > > - normalize_encoding() in encodings

[issue11322] encoding package's normalize_encoding() function is too slow

STINNER Victor added the comment: We should first implement the same algorithm of the 3 normalization functions and add tests for them (at least for the function in normalization): - normalize_encoding() in encodings: it doesn't convert to lowercase and keep non-ASCII letters - normalize_en

[issue11322] encoding package's normalize_encoding() function is too slow

Alexander Belopolsky added the comment: I don't think the normalize_encoding() function was the culprit for issue11303 because I measured timings with timeit which averages multiple runs while normalize_encoding() is called only the one time per encoding spelling due to caching. --

[issue11322] encoding package's normalize_encoding() function is too slow

Changes by Ezio Melotti : -- nosy: +belopolsky, ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue11322] encoding package's normalize_encoding() function is too slow

New submission from Marc-Andre Lemburg : I don't know who changed the encoding's package normalize_encoding() function (wasn't me), but it's a really slow implementation. The original version used the .translate() method which is a lot faster and can be adapted to work with the Unicode variant