[issue11259] asynchat does not check if terminator is negative integer

STINNER Victor added the comment: This issue is now fixed, thanks for the report. Sorry for the delay :-( Asy Mark wrote, asynchat is now deprecated: it's time to switch to the new shiny asyncio module! -- nosy: +haypo resolution: -> fixed status: open -> closed _

[issue11259] asynchat does not check if terminator is negative integer

Roundup Robot added the comment: New changeset f67df13dd512 by Victor Stinner in branch '3.4': Issue #11259: asynchat.async_chat().set_terminator() now raises a ValueError if http://hg.python.org/cpython/rev/f67df13dd512 New changeset d164fda9063a by Victor Stinner in branch 'default': (Merge 3.

[issue11259] asynchat does not check if terminator is negative integer

Mark Lawrence added the comment: I've no objection to people trying to take this forward but they should be aware that asyncio is recommended for new code. -- nosy: +BreamoreBoy versions: +Python 3.4, Python 3.5 ___ Python tracker

[issue11259] asynchat does not check if terminator is negative integer

Devin Cook added the comment: updating the patch to the current tip -- Added file: http://bugs.python.org/file34310/asynchat_tip.patch ___ Python tracker ___

[issue11259] asynchat does not check if terminator is negative integer

Changes by Devin Cook : Removed file: http://bugs.python.org/file29202/asynchat_tip.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue11259] asynchat does not check if terminator is negative integer

Devin Cook added the comment: I agree that this is probably a bug, but can't think of any instances where this in itself would cause a security issue. By sending something like a negative Content-Length, you do indeed get data returned that doesn't really match the data sent on the wire. If yo

[issue11259] asynchat does not check if terminator is negative integer

Марк Коренберг added the comment: > I've never used negative terminators in asynchat and I'm not even sure why > one would want to. no one wants :), but terminator numeric value may be achieved from the net, and hackers sometimes use such technique. attached shorttest.py do the test. If nega

[issue11259] asynchat does not check if terminator is negative integer

Giampaolo Rodola' added the comment: By "writing a test" I mean adding a unittest-based test case in Lib/test/test_asynchat.py which fails before fixing Lib/asynchat.py and succeeds afterwards. Now, I'm not even sure I properly understood your bug exactly. I've never used negative terminators

[issue11259] asynchat does not check if terminator is negative integer

Марк Коренберг added the comment: > actual patch which includes tests I do not understand you. Probably I can not write that patch. Do not know how to. Sorry :( -- ___ Python tracker _

[issue11259] asynchat does not check if terminator is negative integer

Changes by Марк Коренберг : Added file: http://bugs.python.org/file20987/z31.patch ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue11259] asynchat does not check if terminator is negative integer

Giampaolo Rodola' added the comment: Can you write an actual patch which includes tests? Also, I think the z.patch in attachment is targeted for python 2.x as it does not apply cleanly against the current trunk. -- ___ Python tracker

[issue11259] asynchat does not check if terminator is negative integer

Changes by Марк Коренберг : Added file: http://bugs.python.org/file20917/shorttest.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue11259] asynchat does not check if terminator is negative integer

Марк Коренберг added the comment: = ORIGINAL === $ ./qwe.py 10 read length: 10 read data: "xx" should read "test". read: "test" $ ./qwe.py -10 read length: -10 read data: "xx" should read "test". read: "test" = PATCHED === $ ./qwe.py 10 read length: 10 r

[issue11259] asynchat does not check if terminator is negative integer

Марк Коренберг added the comment: only first hunk is really the patch. 2 next hunks are optimizations. -- Added file: http://bugs.python.org/file20915/z.patch ___ Python tracker ___

[issue11259] asynchat does not check if terminator is negative integer

Changes by Марк Коренберг : Removed file: http://bugs.python.org/file20912/z.patch ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue11259] asynchat does not check if terminator is negative integer

Марк Коренберг added the comment: Real patch is the first hunk of attached file. Other 2 hunks are optimizations.. -- keywords: +patch Added file: http://bugs.python.org/file20912/z.patch ___ Python tracker __

[issue11259] asynchat does not check if terminator is negative integer

Giampaolo Rodola' added the comment: Can you provide a patch including a test case? -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue11259] asynchat does not check if terminator is negative integer

Марк Коренберг added the comment: asynchat.py: class async_chat: handle_read(): --- elif isinstance(terminator, int) or isinstance(terminator, long): # numeric terminator n = terminator if lb < n:

[issue11259] asynchat does not check if terminator is negative integer

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue11259] asynchat does not check if terminator is negative integer

Giampaolo Rodola' added the comment: What do you mean by "constructions like self.ac_in_buffer[:n] will lead to misbehaviour."? Please try to be more precise (e.g. by providing a piece of code which demonstrates the issue). -- ___ Python tracker <

[issue11259] asynchat does not check if terminator is negative integer

Changes by Antoine Pitrou : -- assignee: -> giampaolo.rodola nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mail

[issue11259] asynchat does not check if terminator is negative integer

Changes by Марк Коренберг : -- title: asynchat -> asynchat does not check if terminator is negative integer ___ Python tracker ___ ___