[issue11235] Source files with date modifed in 2106 cause OverflowError

Antoine Pitrou added the comment: Committed, thanks. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue11235] Source files with date modifed in 2106 cause OverflowError

Roundup Robot added the comment: New changeset a2f3d6986bfa by Antoine Pitrou in branch '3.2': Issue #11235: Fix OverflowError when trying to import a source file whose modification time doesn't fit in a 32-bit timestamp. http://hg.python.org/cpython/rev/a2f3d6986bfa New changeset cb13d8cff050

[issue11235] Source files with date modifed in 2106 cause OverflowError

Brett Cannon added the comment: LGTM -- assignee: -> pitrou stage: patch review -> commit review ___ Python tracker ___ ___ Python-b

[issue11235] Source files with date modifed in 2106 cause OverflowError

Changes by Antoine Pitrou : -- keywords: +patch Added file: http://bugs.python.org/file24310/imptimestampoverflow.patch ___ Python tracker ___ ___

[issue11235] Source files with date modifed in 2106 cause OverflowError

Antoine Pitrou added the comment: Here is a patch for 3.2. importlib doesn't have the issue, so I just added a test. -- stage: -> patch review ___ Python tracker ___ _

[issue11235] Source files with date modifed in 2106 cause OverflowError

Antoine Pitrou added the comment: Fixing this is much easier than Victor's suggestion, we just have to ignore the higher bits of the timestamp (that is, store it modulo 2**32). This is enough for the purposes of testing the freshness of a pyc file. And by avoiding modifying the pyc format, we

[issue11235] Source files with date modifed in 2106 cause OverflowError

STINNER Victor added the comment: By the way, a simpler fix would be just to not fail if the .pyc file cannot be created (but emit a warning / write an error to stderr). -- ___ Python tracker

[issue11235] Source files with date modifed in 2106 cause OverflowError

STINNER Victor added the comment: > To support bigger timestamps, we have to change the file format > of .pyc files. write_compiled_module(), check_compiled_module() and other functions use the marshal module to read/write binary file, but marshal has no function for int64_t, only for long (

[issue11235] Source files with date modifed in 2106 cause OverflowError

STINNER Victor added the comment: The problem occurs on import (import bla reads bla.py), when Python tries to create bla.pyc. The problem is that Python stores the timestamp as 4 bytes in .pyc files, whereas time_t is 64 bits on Windows (at least on Windows XP with Visual Studio). To suppor

[issue11235] Source files with date modifed in 2106 cause OverflowError

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue11235] Source files with date modifed in 2106 cause OverflowError

Changes by Antoine Pitrou : -- nosy: +barry, ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue11235] Source files with date modifed in 2106 cause OverflowError

New submission from Guy Kisel : Tested in Python 2.7.1 (r271:86832, Nov 27 2010, 18:30:46) [MSC v.1500 32 bit (Intel)] on win32 Exception thrown: OverflowError: modification time overflows a 4 byte field Steps to reproduce: 1. Set system time to 2/8/2106 or later and modify a .py file (or use