[issue11049] add tests for test.support

R. David Murray added the comment: Sure. It doesn't seem likely that I'll get back to it any time soon, and if I do I can open a new issue. -- stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue11049] add tests for test.support

Changes by Brett Cannon : -- nosy: -brett.cannon status: pending -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue11049] add tests for test.support

Brett Cannon added the comment: Can this be closed, David? -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mail

[issue11049] add tests for test.support

Eli Bendersky added the comment: Vinay, great news. Thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11049] add tests for test.support

Vinay Sajip added the comment: Eli, test_support is now completing on my system without errors. -- ___ Python tracker ___ ___ Python-

[issue11049] add tests for test.support

Eli Bendersky added the comment: Vinay, I can't reproduce your problem here (tried installing Python and running from there), but I suspect it's a sys.path issue (you don't have os.curdir on it, I do). Please let me know if it works now. -- ___ Pyt

[issue11049] add tests for test.support

Roundup Robot added the comment: New changeset 07d94cf3521e by Eli Bendersky in branch 'default': Issue #11049: fix test_forget on installed Python - add os.curdir to sys.path http://hg.python.org/cpython/rev/07d94cf3521e -- ___ Python tracker

[issue11049] add tests for test.support

Vinay Sajip added the comment: test_forget still doesn't work using my installed Python: test test_support failed -- Traceback (most recent call last): File "/usr/local/lib/python3.3/test/test_support.py", line 62, in test_forget mod = __import__(TESTFN) ImportError: No module named '@tes

[issue11049] add tests for test.support

Roundup Robot added the comment: New changeset 1a978892a105 by Eli Bendersky in branch 'default': Issue #11049: fix test_forget to work on installed Python, by using a temporary module for import/forget http://hg.python.org/cpython/rev/1a978892a105 -- _

[issue11049] add tests for test.support

Vinay Sajip added the comment: test_support fails in my environment, only when run from an installed Python, due to permissions issues: == ERROR: test_forget (test.test_support.TestSupport)

[issue11049] add tests for test.support

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue11049] add tests for test.support

Roundup Robot added the comment: New changeset 0f09b7f90060 by Eli Bendersky in branch 'default': Issue #11049: added test_support to regrtest.STDTESTS list http://hg.python.org/cpython/rev/0f09b7f90060 -- ___ Python tracker

[issue11049] add tests for test.support

Brett Cannon added the comment: On Fri, Jul 22, 2011 at 22:47, Eli Bendersky wrote: > > Eli Bendersky added the comment: > > Brett, what do you mean by "listed as an essential test in regrtest". The > regrtest.STDTESTS list? > Yes -- Added file: http://bugs.python.org/file22763/unna

[issue11049] add tests for test.support

Eli Bendersky added the comment: OK, the bots are green again after the last push. Sorry about that, folks. I tested this on two different machines (Ubuntu & Win XP) before pushing the original commit. -- ___ Python tracker

[issue11049] add tests for test.support

Roundup Robot added the comment: New changeset 0018a28583f4 by Eli Bendersky in branch 'default': Issue #11049: skip a test that fails on some buildbots http://hg.python.org/cpython/rev/0018a28583f4 -- ___ Python tracker

[issue11049] add tests for test.support

Ezio Melotti added the comment: Several buildbot are failing after the commit: == FAIL: test_get_original_stdout (test.test_support.TestSupport) -- Traceback (

[issue11049] add tests for test.support

Eli Bendersky added the comment: This changeset incorporates Giampaolo's patch with a minor fix in `test.support.python_is_optimized` (which returned '' for False sometimes). -- ___ Python tracker ___

[issue11049] add tests for test.support

Roundup Robot added the comment: New changeset be558ad15789 by Eli Bendersky in branch 'default': Issue #11049: adding some tests to test.support http://hg.python.org/cpython/rev/be558ad15789 -- nosy: +python-dev ___ Python tracker

[issue11049] add tests for test.support

Eli Bendersky added the comment: Brett, what do you mean by "listed as an essential test in regrtest". The regrtest.STDTESTS list? -- ___ Python tracker ___ ___

[issue11049] add tests for test.support

Eli Bendersky added the comment: Alright, since *some* tests are better than no tests at all, I will try to combine the patches currently attached to the issue, port them to the Hg repo and commit. -- ___ Python tracker

[issue11049] add tests for test.support

Eli Bendersky added the comment: Any news on this? Can you check that your patches apply for latest trunk and commit them? -- ___ Python tracker ___ ___

[issue11049] add tests for test.support

Changes by Sandro Tosi : -- nosy: +sandro.tosi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue11049] add tests for test.support

Changes by R. David Murray : -- assignee: -> r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue11049] add tests for test.support

R. David Murray added the comment: Gah. I always check to see if the patch uploaded before I delete my working copy, but this time I didn't :( :( I guess I'll come back to this during the sprints. -- ___ Python tracker

[issue11049] add tests for test.support

R. David Murray added the comment: I agree that the docs for import_fresh_module are confusing. The code says there are sanity checks in test_heapq and test_warnings, so that code could presumably be used as a model for someone to develop a more complete stand-alone test (I haven't looked fo

[issue11049] add tests for test.support

Giampaolo Rodola' added the comment: Can we commit this patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue11049] add tests for test.support

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue11049] add tests for test.support

Giampaolo Rodola' added the comment: > * class TestCase(unittest.TestCase): -> why not give the test class a > more useful name? done > * import_fresh_module is tested similarly to import_module - can't a > test be added that it indeed performs its "special sauce"? Even by reading the sourc

[issue11049] add tests for test.support

Antoine Pitrou added the comment: +os.mkdir(os.path.join(TESTFN, TESTFN)) Please don't. This will break the day TESTFN becomes a non-trivial path. +def test_make_bad_fd(self): +fd = support.make_bad_fd() +self.assertRaises(OSError, os.write, fd, b"foo") You should

[issue11049] add tests for test.support

Nick Coghlan added the comment: test_warnings actually includes sanity checks for import_fresh_module - they could be adapted into a separate unit test easily enough. -- ___ Python tracker ___

[issue11049] add tests for test.support

Eli Bendersky added the comment: Giampaolo, The patch looks good. Some minor comments below: * class TestCase(unittest.TestCase): -> why not give the test class a more useful name? * import_fresh_module is tested similarly to import_module - can't a test be added that it indeed performs its

[issue11049] add tests for test.support

Changes by Eli Bendersky : -- stage: needs patch -> patch review type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailin

[issue11049] add tests for test.support

Changes by Eli Bendersky : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue11049] add tests for test.support

Eli Bendersky added the comment: Giampaolo, FYI I'm also working (issue 11015) in parallel on documenting some of the undocumented functions in Doc/library/test.rst that look useful to me. I think we can collaborate here to make sure they're both documented and tested. I'll review your patch

[issue11049] add tests for test.support

Giampaolo Rodola' added the comment: Attached is a patch which tests about half the API. Certain functions are not documented and/or it's not clear what they do, for others it seems unlikely they are actually used nowadays (although I haven't checked). Also, it probably makes sense to get rid

[issue11049] add tests for test.support

Brett Cannon added the comment: I should note that I am not suggesting that test.support suddenly be considered a module with a stable API that the public can use. Simply that we take the proper measures to make sure the code in there does what is expected. -- ___

[issue11049] add tests for test.support

New submission from Brett Cannon : It seems a little negligent that test.support has no tests. The test.test_support name is available in py3k and backporting issues to 2.7 shouldn't be a problem (rare chance something does happen it can be handling manually). There doesn't seem to be any reas