[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Py

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

miss-islington added the comment: New changeset d5409eb6c26c6bca2686762ce0fd5223bb845e8a by Miss Islington (bot) (Tzu-ping Chung) in branch '2.7': [2.7] bpo-1104: msilib.SummaryInfo.GetProperty() truncates the string by one character (GH-4517) (GH-11749) https://github.com/python/cpython/com

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Change by Tzu-ping Chung : -- pull_requests: +11678, 11679, 11680, 11681 stage: backport needed -> patch review ___ Python tracker ___ __

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Change by Tzu-ping Chung : -- pull_requests: +11678, 11679, 11680 stage: backport needed -> patch review ___ Python tracker ___ ___ P

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Change by Tzu-ping Chung : -- pull_requests: +11678, 11679 stage: backport needed -> patch review ___ Python tracker ___ ___ Python-b

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Change by Tzu-ping Chung : -- pull_requests: +11678 stage: backport needed -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

miss-islington added the comment: New changeset 56f84117a766d21045349f0217ce740831aef0dc by Miss Islington (bot) in branch '3.7': bpo-1104: msilib.SummaryInfo.GetProperty() truncates the string by one character (GH-4517) https://github.com/python/cpython/commit/56f84117a766d21045349f0217ce74

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Steve Dower added the comment: As expected, the 2.7 backport needs more work. Leaving this open for anyone who wants to handle it. I'll happily click merge for you if CI passes. -- stage: patch review -> backport needed ___ Python tracker

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Steve Dower added the comment: New changeset 2de576e16d42ce43698d384d0dd46ba6cf165424 by Steve Dower (Tzu-ping Chung) in branch 'master': bpo-1104: msilib.SummaryInfo.GetProperty() truncates the string by one character (GH-4517) https://github.com/python/cpython/commit/2de576e16d42ce43698d38

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Steve Dower added the comment: I resolved some conflicts and will merge this once CI completes. If the backport to 2.7 isn't automatic then it may wait until someone else comes in to do it. -- assignee: loewis -> steve.dower versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Tzu-ping Chung added the comment: I made a shot to address the free() call. Hopefully this makes sense. -- ___ Python tracker ___ ___

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Tzu-ping Chung added the comment: I have created a PR #4517 from the patch. Would it be better to track the malloc problem in a new issue? As for why this never caused any problems… msilib is pretty standalone, and not one of the most used modules. It is also pretty trivial to roll your own

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Change by Roundup Robot : -- pull_requests: +4454 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Eric V. Smith added the comment: Despite the fact that as of now (or 6+ years ago!) the only way to trigger the malloc() is via VT_LPSTR, I still think the way the free() call is written is bad. What if another type is added? If that were fixed, I still think the basic idea of this patch in i

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Change by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Change by Tzu-ping Chung : -- nosy: +uranusjr ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Changes by Mark Lawrence : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware versions: +Python 3.4, Python 3.5 -Python 3.1, Python 3.2 ___ Python tracker _

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Mark Mc Mahon added the comment: Responding to Eric's comments 1. There are only three valid property types returned by MsiInteger, String & FILETIME. (http://msdn.microsoft.com/en-us/library/aa372045%28v=VS.85%29.aspx) 2. That comment makes sense - I have entered a new issue (issue12202) for

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Eric V. Smith added the comment: This patch seems okay to me, as far as it goes. I'd like to hear Martin's feedback, but I think it should be committed. And I realize the rest of this message doesn't apply to the patch, but it does address other problems in summary_getproperty(). At least one

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Mark Mc Mahon added the comment: And fix the typo... (thanks Ezio) -- Added file: http://bugs.python.org/file21525/issue1104_msi_3.patch ___ Python tracker ___ __

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Ezio Melotti added the comment: +path, msilib.schema, "Ptyhon Tests", "product_code", "1.0", "PSF") s/Ptyhon/Python/ -- nosy: +ezio.melotti stage: test needed -> patch review ___ Python tracker

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Mark Mc Mahon added the comment: I have updated the patch for current trunk (though no real changes required). I also include a testcase. One thing to review is that I added functionality to the tests to create the MSI to be tested. (felt this was safer than touching one of the ones under %s

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Amaury Forgeot d'Arc added the comment: The patch looks correct, it's now a matter of unit tests. for example, I'd test the case where the length is around 1000.. -- nosy: +amaury.forgeotdarc ___ Python tracker ___

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Changes by Mark Lawrence : -- versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6, Python 3.0 ___ Python tracker ___ ___ Python-b

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Changes by Daniel Diniz : -- stage: -> test needed type: -> behavior versions: +Python 2.6, Python 3.0 -Python 2.5 ___ Python tracker ___ ___

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Changes by Sean Reifschneider: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

Changes by Martin v. Löwis: -- assignee: -> loewis nosy: +loewis __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscri

[issue1104] msilib.SummaryInfo.GetProperty() truncates the string by one character

New submission from Anthony Tuininga : Attached is a patch that fixes the truncation of the property values returned by msilib.SummaryInfo.GetProperty(). Unfortunately Microsoft has deemed it necessary to return the size of