[issue1098] decode_unicode doesn't nul-terminate

Georg Brandl added the comment: Committed r58814. -- resolution: -> fixed status: open -> closed __ Tracker <[EMAIL PROTECTED]> __ ___ Python-b

[issue1098] decode_unicode doesn't nul-terminate

Guido van Rossum added the comment: Also r58708 and r58707 in the py3k-pep3137 branch. See also bug 1359. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-b

[issue1098] decode_unicode doesn't nul-terminate

Guido van Rossum added the comment: Yes I did, in r58709, in the trunk. Please backport to 2.5.2. -- assignee: gvanrossum -> __ Tracker <[EMAIL PROTECTED]> __ __

[issue1098] decode_unicode doesn't nul-terminate

Georg Brandl added the comment: Guido, didn't you fix something about 0-termination in a DecodeUnicode function recently? I can't seem to find the commit now though... -- assignee: loewis -> gvanrossum nosy: +gvanrossum __ Tracker <[EMAIL PROTECTED]>

[issue1098] decode_unicode doesn't nul-terminate

Georg Brandl added the comment: The function in question is in Python/ast.c. Martin, does the string need to be null-terminated or does DecodeUnicodeEscape need to be fixed (since it takes an explicit length argument)? -- assignee: -> loewis nosy: +georg.brandl, loewis type: -> crash

[issue1098] decode_unicode doesn't nul-terminate

New submission from Adam Olsen: In the large else branch in decode_unicode (if encoding is not NULL or "iso-8859-1"), the new string it produces is not nul-terminated. This then hits PyUnicode_DecodeUnicodeEscape's octal escape case, which reads past the end of the string (but would stop if ther