[issue10740] sqlite3 module should allow DDL statements in transactions

Changes by mike bayer : -- nosy: +zzzeek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue10740] sqlite3 module should allow DDL statements in transactions

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue10740] sqlite3 module should allow DDL statements in transactions

Changes by Jeremy Banks : -- nosy: +Jeremy Banks ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue10740] sqlite3 module should allow DDL statements in transactions

Mark Bucciarelli added the comment: Opened http://bugs.python.org/issue12997 in case there is a way to solve the foreign_key PRAGMA issue with a less disruptive fix. -- nosy: +Mark.Bucciarelli ___ Python tracker

[issue10740] sqlite3 module should allow DDL statements in transactions

Torsten Landschoff added the comment: I updated the patch for upstream pysqlite2. Available at http://code.google.com/p/pysqlite/issues/detail?id=24 Patch over there is for Python 2 (tested with our production Python 2.6). -- ___ Python tracker

[issue10740] sqlite3 module should allow DDL statements in transactions

Torsten Landschoff added the comment: The attached patch is an updated version which adds a bit of documentation. -- Added file: http://bugs.python.org/file21479/sqlite_transaction_config_v2.diff ___ Python tracker

[issue10740] sqlite3 module should allow DDL statements in transactions

Torsten Landschoff added the comment: > Torsten basically you are suggesting that PRAGMA would never work at all with > my 'do not strcmp() the sql at all, always begin a transaction' approach? No. Most pragmas should still work and getting the current setting of a pragma should also work. I

[issue10740] sqlite3 module should allow DDL statements in transactions

dholth added the comment: Torsten basically you are suggesting that PRAGMA would never work at all with my 'do not strcmp() the sql at all, always begin a transaction' approach? -- ___ Python tracker

[issue10740] sqlite3 module should allow DDL statements in transactions

Changes by Torsten Landschoff : Added file: http://bugs.python.org/file21419/sqlite_transaction_config_py27.diff ___ Python tracker ___ ___ Py

[issue10740] sqlite3 module should allow DDL statements in transactions

Torsten Landschoff added the comment: Same patch for Python 3. In fact, this also adds a missing Py_XDECREF. -- Added file: http://bugs.python.org/file21418/sqlite_transaction_config_py3.diff ___ Python tracker __

[issue10740] sqlite3 module should allow DDL statements in transactions

Torsten Landschoff added the comment: The attached patch is my take on this issue. I ran into the problem that during schema upgrades dropping a table was not rolled back. In another instance, renaming a table was not rolled back. This greatly increases the risk of data loss for our applicati

[issue10740] sqlite3 module should allow DDL statements in transactions

dholth added the comment: I want transactional DDL too. I was tremendously surprised that I could not duplicate the way sqlite3 behaves on the command line from witin pysqlite. Instead of this patch, I would rather be able to instruct pysqlite to always begin a transaction for any kind of sta

[issue10740] sqlite3 module should allow DDL statements in transactions

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue10740] sqlite3 module should allow DDL statements in transactions

Scott Urban added the comment: I find the way that the sqlite3 module handles transactions pretty surprising in general, but I agree that someone who got used to DDL not rolling back could in theory find this patch surprising. We will apply this patch to our python build because having DDL cove

[issue10740] sqlite3 module should allow DDL statements in transactions

R. David Murray added the comment: See also Issue 8145. It would be nice if someone could sort all this out, but I'm not knowledgeable enough to do so. For this patch, it would be a significant change it behaviour. Therefore it would have to be a new feature controlled by a flag of some sor

[issue10740] sqlite3 module should allow DDL statements in transactions

Scott Urban added the comment: Here are some tests. -- Added file: http://bugs.python.org/file20119/test_sqlite_ddl.py ___ Python tracker ___ ___

[issue10740] sqlite3 module should allow DDL statements in transactions

New submission from Scott Urban : The python sqlite module automatically commits open transactions when it encounters a DDL statement. This is unnecessary; DDL is transactional in my testing (see attached). Attached patch addresses the issue. Patch is against 2.6.1, but looking at Trunk in svn,