[issue10611] sys.exit() in a test causes a test run to die

Change by Serhiy Storchaka : -- pull_requests: -26829 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue10611] sys.exit() in a test causes a test run to die

Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka nosy_count: 4.0 -> 5.0 pull_requests: +26829 pull_request: https://github.com/python/cpython/pull/28180 ___ Python tracker _

[issue10611] sys.exit() in a test causes a test run to die

Michael Foord added the comment: Allowing sys.exit() to end the test run was particularly a problem for testing command line tools, where improper patching / unexpected code paths would trigger a sys.exit. If a test framework author wants a way to end the test run I'm happy to provide that (a

[issue10611] sys.exit() in a test causes a test run to die

Robert Collins added the comment: Hmm, so testtools went in a different direction here - the same unification stuff, but see https://github.com/testing-cabal/testtools/commit/18bc5741cf277f7a0d601568be6dccacc7b0783c tl;dr - I think unittest should not prevent this causing the process to exit

[issue10611] sys.exit() in a test causes a test run to die

Michael Foord added the comment: Committed to py3k in revision 87390. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue10611] sys.exit() in a test causes a test run to die

Michael Foord added the comment: Committed to Python 2.7 in revision 87406. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue10611] sys.exit() in a test causes a test run to die

Ray.Allen added the comment: > I'd like to fix all these issues by moving the exception handling into a > single method and unifying the reporting of failure / error / expected > failure / skip test. This will fix all these issues and nicely simplify the > implementation. That sounds good.

[issue10611] sys.exit() in a test causes a test run to die

Michael Foord added the comment: At the moment exception handling for setUp / tearDown / testMethod and cleanUp functions are all handled separately. They all have to call addError and as a result we have inconsistent handling of skips, expected failures (etc). There are separate issues for h

[issue10611] sys.exit() in a test causes a test run to die

Éric Araujo added the comment: LGTM. -- stage: unit test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue10611] sys.exit() in a test causes a test run to die

Ray.Allen added the comment: Agreed. I think the "except Exception" in TestCase.run() should be "except BaseException", since BaseException could catch Exception, SystemExit, GeneratorExit, KeyboardInterrupt. The KeyboardInterrupt should be caught first. The remaining three is exactly what is

[issue10611] sys.exit() in a test causes a test run to die

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue10611] sys.exit() in a test causes a test run to die

Changes by Michael Foord : -- title: sys.exit() in a test causes the run to stp -> sys.exit() in a test causes a test run to die ___ Python tracker ___ _