[issue10560] Fixes for Windows sources

2013-03-17 Thread Martin v . Löwis
Martin v. Löwis added the comment: I'm rejecting the patch, on grounds of PEP 11. We only support MSVC compilers up to 3 years after the extended support by Microsoft has expired. For MSC 5, this is long past. For MSC 6, extended support was discontinued in 2005, for MSVC 2002, in 2009. For al

[issue10560] Fixes for Windows sources

2013-02-24 Thread Carlo Bramini
Carlo Bramini added the comment: Hello, no problem, the fix on GetModuleHandle() can be avoided without problems if you want. Anyways, although nowadays the "hybrid" operating systems like Windows 9x/ME are dead and burried, in this particular case I would still suggest to use directly GetModu

[issue10560] Fixes for Windows sources

2013-02-23 Thread STINNER Victor
STINNER Victor added the comment: -HINSTANCE hKernel32 = GetModuleHandleW(L"kernel32.dll"); +HINSTANCE hKernel32 = GetModuleHandle(TEXT("KERNEL32")); I prefer to be explicit and force the usage of the wide character API, espacially in Python 3. -- nosy: +haypo

[issue10560] Fixes for Windows sources

2013-02-23 Thread Roumen Petrov
Roumen Petrov added the comment: yes -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/

[issue10560] Fixes for Windows sources

2013-02-23 Thread Carlo Bramini
Carlo Bramini added the comment: I have downloaded the latest sources with HG and, with the only exception of the variable "cookie" now conditionally declared with an "#ifdef HAVE_SXS", yes, all these fixes are still actual. -- status: pending -> open _

[issue10560] Fixes for Windows sources

2013-02-22 Thread Ezio Melotti
Ezio Melotti added the comment: Is this issue still valid? -- nosy: +brian.curtin, ezio.melotti status: open -> pending ___ Python tracker ___ ___

[issue10560] Fixes for Windows sources

2010-11-28 Thread Carlo Bramini
Carlo Bramini added the comment: I modified the patch by using Py_LL() as suggested in a previous comment. I just would like to say that these fixes are not required to compiling under MSVC5: I was able to compile all the sources as they were, even without changes and this is a great thing. I

[issue10560] Fixes for Windows sources

2010-11-28 Thread Martin v . Löwis
Martin v. Löwis added the comment: > According to the instructions received at #python-dev, I'm posting a > new patch with the same fixes made on the most recent SVN sources > (py3k). Actually the new patch does not include the fixes made on the > GetFileAttributesEx wrappers since they have bee

[issue10560] Fixes for Windows sources

2010-11-28 Thread Roumen Petrov
Roumen Petrov added the comment: posix_module has to use Py_LL(...) -- nosy: +rpetrov ___ Python tracker ___ ___ Python-bugs-list mai

[issue10560] Fixes for Windows sources

2010-11-28 Thread Carlo Bramini
Carlo Bramini added the comment: According to the instructions received at #python-dev, I'm posting a new patch with the same fixes made on the most recent SVN sources (py3k). Actually the new patch does not include the fixes made on the GetFileAttributesEx wrappers since they have been remove

[issue10560] Fixes for Windows sources

2010-11-28 Thread Georg Brandl
Changes by Georg Brandl : -- assignee: -> loewis nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10560] Fixes for Windows sources

2010-11-28 Thread Carlo Bramini
New submission from Carlo Bramini : Hello, I was able to compile latest python sources with MSVC5, by importing and fixing a bit the project workspaces of MSVC6. During this action I received some messages, so I gave a look to the sources and I would like to suggest the following fixes: 1) in