[issue10451] memoryview can be used to write into readonly buffer

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue10451] memoryview can be used to write into readonly buffer

Antoine Pitrou added the comment: Patch with modified tests committed in r88097 (3.2), r88098 (3.1) and r88099 (2.7). Thank you! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: +Python 2.7 ___ Python tracker

[issue10451] memoryview can be used to write into readonly buffer

Georg Brandl added the comment: The patch looks trivial enough. You're the memoryview guru, so if you have no doubts about it, I would say it can go in. -- ___ Python tracker

[issue10451] memoryview can be used to write into readonly buffer

Antoine Pitrou added the comment: > So, does "critical" mean "should be release blocker"? It's up to you to decide. It's not a new bug AFAICT. -- ___ Python tracker ___ ___

[issue10451] memoryview can be used to write into readonly buffer

Georg Brandl added the comment: So, does "critical" mean "should be release blocker"? -- ___ Python tracker ___ ___ Python-bugs-list

[issue10451] memoryview can be used to write into readonly buffer

Ross Lagerwall added the comment: And a simple fix for the test_getargs2 test - it wraps the memoryview around a bytearray. -- Added file: http://bugs.python.org/file20441/testfix.patch ___ Python tracker ___

[issue10451] memoryview can be used to write into readonly buffer

Ross Lagerwall added the comment: Attached is an updated patch with a simpler test. -- Added file: http://bugs.python.org/file20440/i10451_v2.patch ___ Python tracker ___ __

[issue10451] memoryview can be used to write into readonly buffer

Changes by Antoine Pitrou : -- nosy: +georg.brandl priority: normal -> critical ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue10451] memoryview can be used to write into readonly buffer

Antoine Pitrou added the comment: The patch produces a failure in test_getargs2, but that test is wrong and should be fixed: == ERROR: test_w_star (test.test_getargs2.Bytes_TestCase) ---

[issue10451] memoryview can be used to write into readonly buffer

Changes by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue10451] memoryview can be used to write into readonly buffer

Ross Lagerwall added the comment: >From what I can see, this issue is in memoryview and allows memoryview to >export a readonly buffer as writable (because memoryview.getbuffer() removes >the writable flag from flags before calling the underlying buffer). This causes segfaults when using mmap

[issue10451] memoryview can be used to write into readonly buffer

Changes by Éric Araujo : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue10451] memoryview can be used to write into readonly buffer

New submission from Evgeny Kapun : This code crashes Python: import io, mmap io.BytesIO(b' ').readinto(memoryview(mmap.mmap(-1, 1, prot=mmap.PROT_READ))) -- components: Interpreter Core messages: 121446 nosy: abacabadabacaba priority: normal severity: normal status: open title: memoryvi