[issue10411] Pickle benchmark fails after converting Benchmark Suite to py3k

Antoine Pitrou added the comment: Pushed in 92088733aade and 8dd7a860a2fa, thanks. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue10411] Pickle benchmark fails after converting Benchmark Suite to py3k

Antoine Pitrou added the comment: Woops, sorry, wrong issue. -- resolution: fixed -> stage: committed/rejected -> patch review status: closed -> open ___ Python tracker ___ ___

[issue10411] Pickle benchmark fails after converting Benchmark Suite to py3k

Antoine Pitrou added the comment: Pushed in 2c5c6d3f399b, thanks. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue10411] Pickle benchmark fails after converting Benchmark Suite to py3k

Bobby Impollonia added the comment: Attached is a patch for perf.py that goes along with the previous patch for make_perf3.sh. This patch changes the py3k group to include everything in the 2n3 group since we can still run all those tests after converting. Previously, nqueens, unpack_sequance

[issue10411] Pickle benchmark fails after converting Benchmark Suite to py3k

Bobby Impollonia added the comment: Patch is attached for make_perf3.sh to have it not convert things that don't need to be converted. This fixes the issue and with the patch all the py3k benchmarks run successfully after running the script. -- Added file: http://bugs.python.org/file1

[issue10411] Pickle benchmark fails after converting Benchmark Suite to py3k

Antoine Pitrou added the comment: > Are there any files in performance/ that need 2to3? All the ones that require external libs (such as django, spambayes, etc.). Although, of course, since they require external libs it's not sure the translation will work either. I think I've converted all th

[issue10411] Pickle benchmark fails after converting Benchmark Suite to py3k

Bobby Impollonia added the comment: Are there any files in performance/ that need 2to3? -- ___ Python tracker ___ ___ Python-bugs-lis

[issue10411] Pickle benchmark fails after converting Benchmark Suite to py3k

Antoine Pitrou added the comment: Well, since this benchmark is already 3.x compatible, there's not much sense in making a 2to3 pass, is there? So perhaps "make_perf3.sh" (which I've never used) should be a bit smarter. -- ___ Python tracker

[issue10411] Pickle benchmark fails after converting Benchmark Suite to py3k

New submission from Bobby Impollonia : After checking out and converting the benchmark suite to py3k, the py3k benchmark set fails because of an ImportError in bm_pickle.py. Steps to reproduce: hg clone http://hg.python.org/benchmarks/ py2benchmarks mkdir py3benchmarks cd py3benchmarks ../py2