[issue10376] ZipFile unzip is unbuffered

2012-06-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Antoine, can you commit this? Ok, done. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue10376] ZipFile unzip is unbuffered

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0e8285321659 by Antoine Pitrou in branch 'default': On behalf of Nadeem Vawda: issue #10376: micro-optimize reading from a Zipfile. http://hg.python.org/cpython/rev/0e8285321659 -- nosy: +python-dev ___

[issue10376] ZipFile unzip is unbuffered

2012-06-23 Thread Nadeem Vawda
Nadeem Vawda added the comment: Patch looks fine to me. Antoine, can you commit this? I'm currently away from the computer that has my SSH key on it. -- ___ Python tracker ___

[issue10376] ZipFile unzip is unbuffered

2012-06-23 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- assignee: docs@python -> nosy: +nadeem.vawda stage: -> patch review ___ Python tracker ___ ___ Python

[issue10376] ZipFile unzip is unbuffered

2012-06-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Any chance to commit the patch before final feature freeze? -- ___ Python tracker ___ ___ Python-

[issue10376] ZipFile unzip is unbuffered

2012-06-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Martin, now the patch is good? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue10376] ZipFile unzip is unbuffered

2012-05-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch updated to reflect Martin's stylistic comments. Sorry for the delay, Martin. I have not received an email with your review from 2012-05-13, and only today accidentally discovered your comments in Rietveld. It seems to have been some bug in Rietvel

[issue10376] ZipFile unzip is unbuffered

2012-05-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you, Martin, now I understood why not work Rietveld review. -- ___ Python tracker ___ ___ P

[issue10376] ZipFile unzip is unbuffered

2012-05-13 Thread Martin v . Löwis
Changes by Martin v. Löwis : Added file: http://bugs.python.org/file25565/zipfile_optimize_read.patch ___ Python tracker ___ ___ Python-bugs-l

[issue10376] ZipFile unzip is unbuffered

2012-05-10 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue10376] ZipFile unzip is unbuffered

2012-05-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is not because zipfile module is unbuffered. This is the difference between expensive function call and cheap bytes slicing. Replace `zf.open(namelist [0])` to `io.BufferedReader(zf.open(namelist [0]))` to see the effect of a good buffering. In 3.2 zip

[issue10376] ZipFile unzip is unbuffered

2012-05-01 Thread James Hutchison
James Hutchison added the comment: See attached, which will open a zipfile that contains one file and reads it a bunch of times using unbuffered and buffered idioms. This was tested on windows using python 3.2 You're in charge of coming up with a file to test it on. Sorry. Example output: E

[issue10376] ZipFile unzip is unbuffered

2012-04-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Actually reading from the zip file is buffered (at least 4 KiB of uncompressed data at a time). Can you give tests, scripts and data, which show the problem? -- ___ Python tracker

[issue10376] ZipFile unzip is unbuffered

2012-04-07 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue10376] ZipFile unzip is unbuffered

2011-06-06 Thread Xuanji Li
Changes by Xuanji Li : -- nosy: +xuanji ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/

[issue10376] ZipFile unzip is unbuffered

2011-05-31 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- versions: +Python 3.2, Python 3.3 -Python 2.5, Python 2.6, Python 3.1 ___ Python tracker ___ ___ Python

[issue10376] ZipFile unzip is unbuffered

2010-11-09 Thread James Hutchison
James Hutchison added the comment: I should clarify that this is the zipfile constructor I am using: zipfile.ZipFile(filename, mode='r', allowZip64=True); -- ___ Python tracker ___

[issue10376] ZipFile unzip is unbuffered

2010-11-09 Thread James Hutchison
New submission from James Hutchison : The Unzip module is always unbuffered (tested v.3.1.2 Windows XP, 32-bit). This means that if one has to do many small reads it is a lot slower than reading a chunk of data to a buffer and then reading from that buffer. It seems logical that the unzip modu