[issue10265] Fix fd leak in sunau

Antoine Pitrou added the comment: Committed in r86067. Thank you Brian! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue10265] Fix fd leak in sunau

Brian Brazil added the comment: Currently, if you pass in a fd it'll be closed by the __del__. My patch no longer does this so any use of the module depending on this behaviour could leak an fd. However, noone seems to use the module that way. V2 attached. -- Added file: http://bugs.

[issue10265] Fix fd leak in sunau

Antoine Pitrou added the comment: > It's possible that this change will lead to fds leaking if someone is > passing in a fd I don't think so, why do you say that? That said, there's an indentation problem in your patch. -- nosy: +pitrou ___ Python

[issue10265] Fix fd leak in sunau

Brian Brazil added the comment: That'd help alright. -- keywords: +patch Added file: http://bugs.python.org/file19446/sunau_fd_leak.patch ___ Python tracker ___

[issue10265] Fix fd leak in sunau

Brian Curtin added the comment: Forget the attachment? -- nosy: +brian.curtin type: -> resource usage versions: +Python 3.2 -Python 3.3 ___ Python tracker ___ _

[issue10265] Fix fd leak in sunau

New submission from Brian Brazil : Please see attached. It's possible that this change will lead to fds leaking if someone is passing in a fd, however a) this is consistent with how other modules (e.g. uu) do it and b) of the 2 (!) uses of this module I found on Google Codesearch, both pass i