[issue10206] python program starting with unmatched quote spews spaces to stdout

R. David Murray added the comment: Thanks, Petri and Francisco. Eric, I'm closing this since we now have a minimal test. If you still want to go back and add more tests based on a deeper understanding of what was broken, feel free to reopen the issue. -- resolution: -> fixed stage:

[issue10206] python program starting with unmatched quote spews spaces to stdout

Roundup Robot added the comment: New changeset 2a4764376c51 by R David Murray in branch '3.2': #10206: add test for previously fixed bug. http://hg.python.org/cpython/rev/2a4764376c51 New changeset 5ec95f46bac5 by R David Murray in branch 'default': Merge #10206: add test for previously fixed b

[issue10206] python program starting with unmatched quote spews spaces to stdout

Francisco Martín Brugué added the comment: On 06/24/2011 06:07 PM, R. David Murray wrote: > self.assertRegex(err.decode('ascii', 'ignore'), 'SyntaxError') I understand that's the standard way to check if a given failure happened in the command line or there is also a helper for that case (may

[issue10206] python program starting with unmatched quote spews spaces to stdout

Francisco Martín Brugué added the comment: Just attaching the review patch -- Added file: http://bugs.python.org/file22443/issue10206v2.patch ___ Python tracker ___

[issue10206] python program starting with unmatched quote spews spaces to stdout

R. David Murray added the comment: I think that self.assertRegex(err.decode('ascii', 'ignore'), 'SyntaxError') would be fine. We are extremely unlikely to change the string representation of the name of SyntaxError or omit it from the error message, so I think this is a reliable test. If yo

[issue10206] python program starting with unmatched quote spews spaces to stdout

Francisco Martín Brugué added the comment: I've attached an alternative test case. I'm not sure if there is a more robust way to test: self.assert_('SyntaxError' in err.decode('ascii', 'ignore')) Due the use of 'SyntaxtError' directly as string. I would prefer something like str(SyntaxtError)

[issue10206] python program starting with unmatched quote spews spaces to stdout

R. David Murray added the comment: Hmm. I don't know that it is really necessary to cater to the particular failure mode, I was more interested in seeing a unit test that checked the correct behavior: that a syntax error is raised (by capturing the output using the tools in script_helper).

[issue10206] python program starting with unmatched quote spews spaces to stdout

Petri Lehtinen added the comment: Attached a test case. The patch is against the current default tip. -- Added file: http://bugs.python.org/file22427/issues10206_test.patch ___ Python tracker _

[issue10206] python program starting with unmatched quote spews spaces to stdout

Petri Lehtinen added the comment: By checking out the parent of r85904 I now can reproduce this. -- ___ Python tracker ___ ___ Python

[issue10206] python program starting with unmatched quote spews spaces to stdout

Stefan Krah added the comment: I remember that I could reproduce it at the time. The issue was indeed fixed in r85904. -- nosy: +skrah ___ Python tracker ___ ___

[issue10206] python program starting with unmatched quote spews spaces to stdout

Petri Lehtinen added the comment: I'm unable to reproduce this. I checked out the commit 65614:18989ad44636 (corresponding to r85814, right?), built and ran python -c "'", but didn't get a space flood on my face. Just a normal SyntaxError. -- nosy: +petri.lehtinen ___

[issue10206] python program starting with unmatched quote spews spaces to stdout

Changes by Éric Araujo : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue10206] python program starting with unmatched quote spews spaces to stdout

Changes by Eric Smith : Removed file: http://bugs.python.org/file19396/issue10206.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue10206] python program starting with unmatched quote spews spaces to stdout

Eric Smith added the comment: I think Benjamin fixed this in r85904. I'm going to verify and add some tests. -- priority: critical -> normal stage: patch review -> unit test needed ___ Python tracker _

[issue10206] python program starting with unmatched quote spews spaces to stdout

Eric Smith added the comment: Now that I think about it some more, I think my patch (although it fixes this issue and passes all tests) doesn't do what the original code does in the presence of multiple newlines. I'm going to rework it some more. I'll have another patch shortly. --

[issue10206] python program starting with unmatched quote spews spaces to stdout

Eric Smith added the comment: This patch fixes the issue, and makes print_error_text slightly more understandable (and efficient to boot, not that it matters). But I'm not convinced it's the correct solution. I think the real error might be the computation "offset" in the caller. I'm still lo

[issue10206] python program starting with unmatched quote spews spaces to stdout

Eric Smith added the comment: This is caused by r85814. I've got a fix, as soon as I get it in a presentable state I'll post it. -- nosy: +eric.smith ___ Python tracker ___ ___

[issue10206] python program starting with unmatched quote spews spaces to stdout

New submission from R. David Murray : To reproduce: python -c "'" (Hint: don't do this on a slow terminal) -- messages: 119646 nosy: r.david.murray priority: critical severity: normal stage: needs patch status: open title: python program starting with unmatched quote spews spaces to