[issue10141] SocketCan support

Change by Roundup Robot : -- pull_requests: +22650 pull_request: https://github.com/python/cpython/pull/23794 ___ Python tracker ___ ___

[issue10141] SocketCan support

R. David Murray added the comment: This issue is closed. Please open a new issue for your problem and proposal. -- nosy: +r.david.murray ___ Python tracker ___ _

[issue10141] SocketCan support

Riccardo Magliocchetti added the comment: I have an issue related to this while trying to compile statically Python 3.6.1 against a static musl. The problem is that i have AF_CAN defined because it's defined in linux/socket.h but by not having HAVE_LINUX_CAN_H defined in pyconfig.h the header

[issue10141] SocketCan support

Changes by Vinay Sajip : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue10141] SocketCan support

Martin Panter added the comment: Sounds like the last problem has been fixed, so can we close this? -- nosy: +martin.panter ___ Python tracker ___ ___

[issue10141] SocketCan support

Charles-François Natali added the comment: > That AF_CAN was undefined (even though HAVE_LINUX_CAN_H is). This is on Ubuntu Jaunty, which I use for my Python core development. How dear... The latest change should be OK. -- ___ Python tracker

[issue10141] SocketCan support

Roundup Robot added the comment: New changeset 9dc199b921eb by Vinay Sajip in branch '3.4': Issue #10141, Issue 20065: Changed #if to take CAN_RAW into account. http://hg.python.org/cpython/rev/9dc199b921eb New changeset 20cced06acdd by Vinay Sajip in branch 'default': Issue #10141, Issue 20065:

[issue10141] SocketCan support

Vinay Sajip added the comment: > What error were you getting? That AF_CAN was undefined (even though HAVE_LINUX_CAN_H is). This is on Ubuntu Jaunty, which I use for my Python core development. Note the change you made in d4ce850b06b7 to fix this problem when it occurred before - it's the same

[issue10141] SocketCan support

Charles-François Natali added the comment: > Are you saying that an additional clause for CAN_RAW being defined should be added around where it is used? Would that sort things out? Yes. > I'd rather not just revert my change, as that would mean I couldn't compile the SSL module. I don't get it

[issue10141] SocketCan support

Vinay Sajip added the comment: Sorry if I messed up - I just applied the same logic as I thought you had done earlier (replacing #ifdef HAVE_LINUX_CAN_H with #ifdef AF_CAN), and everything compiled OK after my changes. Are you saying that an additional clause for CAN_RAW being defined should b

[issue10141] SocketCan support

Charles-François Natali added the comment: Vinay, your change just reverted this: http://bugs.python.org/issue20065 Basically, AF_CAN being defined doesn't imply that CAN_RAW is defined. So compilation will now fail - again - on those hosts. -- status: closed -> open _

[issue10141] SocketCan support

Roundup Robot added the comment: New changeset df427bf067d7 by Vinay Sajip in branch '3.4': Issue #10141: updated new usages of AF_CAN to be in #ifdef AF_CAN rather than #ifdef HAVE_LINUX_CAN_H to allow compilation on older Linuxes. http://hg.python.org/cpython/rev/df427bf067d7 --

[issue10141] SocketCan support

Charles-François Natali added the comment: Working fine on the buildbots and Vinay's box, closing! -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker __

[issue10141] SocketCan support

Roundup Robot added the comment: New changeset d4ce850b06b7 by Charles-François Natali in branch 'default': Issue #10141: fix socketmodule compilation on Linux systems with http://hg.python.org/cpython/rev/d4ce850b06b7 -- ___ Python tracker

[issue10141] SocketCan support

Vinay Sajip added the comment: That did the trick - I can now build the socket module. Thanks! I noticed that the module initialisation code uses #ifdef AF_CAN and #ifdef PF_CAN rather than #ifdef HAVE_LINUX_CAN_H :-) -- ___ Python tracker

[issue10141] SocketCan support

Charles-François Natali added the comment: Here's a better patch. It only touches socketmodule.c, so no need for autoconf, just use make. If it works on your box, I'll test it on the custom buildbots before pushing it for good (if I learned one thing, it's to never underestimate the potential f

[issue10141] SocketCan support

Vinay Sajip added the comment: > Did you run autoconf (or autoreconf) before? D'oh! I didn't realise I had to, though in retrospect it should have been obvious ... autoconf isn't even installed on my system, and I can't install it at the moment because of some problem with the Ubuntu repos fo

[issue10141] SocketCan support

Antoine Pitrou added the comment: > Making the change in configure.in didn't lead to any change: no error > when I ran configure Did you run autoconf (or autoreconf) before? -- ___ Python tracker

[issue10141] SocketCan support

Vinay Sajip added the comment: PF_CAN is defined by #define PF_CAN AF_CAN in linux/socket.h :-( Making the change in configure.in didn't lead to any change: no error when I ran configure (which is ./configure --with-py-debug in my case), and when I build, the same error (AF_CAN und

[issue10141] SocketCan support

Charles-François Natali added the comment: > which would imply that on this system at least, the AF_CAN definition is > supposed to come from elsewhere. Yes, from . Looks like a crappy libc version: is present, but AF_CAN is not defined. Just for fun, is PF_CAN defined? You might try the fo

[issue10141] SocketCan support

Vinay Sajip added the comment: Ok, I found that linux/socket.h *is* actually included earlier, from /usr/include/linux/netlink.h. However, the AF_CAN definition appears only under the condition #if defined(__KERNEL__) || !defined(__GLIBC__) || (__GLIBC__ < 2) ... #define AF_CAN 29

[issue10141] SocketCan support

Vinay Sajip added the comment: Just to test, I added the full absolute path name in socketmodule.h: #ifdef HAVE_LINUX_CAN_H #include "/usr/include/linux/socket.h" #include #endif Now, the snippet from pre-processing is: # 182 "/usr/include/linux/tipc.h" 3 4 struct sockaddr_tipc { unsigned s

[issue10141] SocketCan support

Vinay Sajip added the comment: I added the line in the suggested place: #ifdef HAVE_LINUX_TIPC_H # include #endif #ifdef HAVE_LINUX_CAN_H #include /* the line I added - line 76 */ #include #endif #ifdef HAVE_LINUX_CAN_RAW_H #include #endif Strangely, it seems to make no difference! I co

[issue10141] SocketCan support

Charles-François Natali added the comment: >From python-dev: """ I work on Ubuntu Jaunty for my cpython development work - an old version, I know, but still quite serviceable and has worked well for me over many months. With the latest default cpython repository, however, I can't run the regress

[issue10141] SocketCan support

Charles-François Natali added the comment: Committed. Matthias, Tiago, thanks! -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue10141] SocketCan support

Roundup Robot added the comment: New changeset a4af684bb54e by Victor Stinner in branch 'default': Issue #10141: Don't use hardcoded frame size in example, use struct.calcsize() http://hg.python.org/cpython/rev/a4af684bb54e -- ___ Python tracker

[issue10141] SocketCan support

Roundup Robot added the comment: New changeset e767318baccd by Charles-François Natali in branch 'default': Issue #10141: socket: add SocketCAN (PF_CAN) support. Initial patch by Matthias http://hg.python.org/cpython/rev/e767318baccd -- nosy: +python-dev ___

[issue10141] SocketCan support

Antoine Pitrou added the comment: > I had never heard about it before this issue, but the protocol is really > simple. > > If you want to try it out (just for fun :-), you just have to do the > following: > # modprobe vcan > # ip link add dev vcan0 type vcan > # ifconfig vcan0 up Ah, thanks!

[issue10141] SocketCan support

Charles-François Natali added the comment: > I don't have much to say about the patch, given that I don't know > anything about CAN and my system doesn't appear to have a "vcan0" > interface. I had never heard about it before this issue, but the protocol is really simple. If you want to try it

[issue10141] SocketCan support

Antoine Pitrou added the comment: I don't have much to say about the patch, given that I don't know anything about CAN and my system doesn't appear to have a "vcan0" interface. I think it's ok to commit and refine later if something turns out insufficient. --

[issue10141] SocketCan support

Changes by Charles-François Natali : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue10141] SocketCan support

Charles-François Natali added the comment: So, Victor, what do you think of the last version? This patch has been lingering for quite some time, and it's really a cool feature. -- ___ Python tracker __

[issue10141] SocketCan support

Changes by Charles-François Natali : Removed file: http://bugs.python.org/file23225/socketcan_v4.patch ___ Python tracker ___ ___ Python-bugs-

[issue10141] SocketCan support

Charles-François Natali added the comment: > - dummy question: why an address is a tuple with 1 string instead of just > the string? Does AF_UNIX also uses a tuple of 1 string? I think the reason behind the tuple is future proofing. Here's the definition of `struct sockaddr_can` in my Linux bo

[issue10141] SocketCan support

STINNER Victor added the comment: socketcan_v4.patch: - dummy question: why an address is a tuple with 1 string instead of just the string? Does AF_UNIX also uses a tuple of 1 string? - the example should also use struct.pack() to create the frame, I don't like hardcoded BLOB - in test_sock

[issue10141] SocketCan support

Charles-François Natali added the comment: Here's an updated patch, with more tests. Please review! -- keywords: +needs review nosy: +haypo stage: patch review -> commit review Added file: http://bugs.python.org/file23225/socketcan_v4.patch ___ Pytho

[issue10141] SocketCan support

Tiago Gonçalves added the comment: I think that this time i have included almost every proposed changes. For the unitTest I did not included the condition "os.getuid() == 0" because of this information in the Linux documentation "3.3 network security issues (capabilities)" http://www.mjmwire

[issue10141] SocketCan support

Charles-François Natali added the comment: Thanks for updating your patch. I've done a review, available here: http://bugs.python.org/review/10141/show -- ___ Python tracker ___

[issue10141] SocketCan support

Tiago Gonçalves added the comment: This patch should be easy to verify and includes documentation and the test cases. ogait87@mypc:~/cpython$ hg sum parent: 71435:6f9d917df541 tip Fix test_multiprocessing failure under Windows. branch: default commit: 7 modified update: (current) --

[issue10141] SocketCan support

Changes by Miguel Luis : -- nosy: +mluis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org

[issue10141] SocketCan support

Charles-François Natali added the comment: The patch looks good to me. A couple remarks: - could you please post it as a Mercurial diff? (it makes it easier to review and apply) @@ -1151,6 +1151,25 @@ makesockaddr(int sockfd, struct sockaddr } + return Py_BuildValue("sh",

[issue10141] SocketCan support

Changes by Antoine Pitrou : -- nosy: +neologix, rosslagerwall versions: -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list maili

[issue10141] SocketCan support

Tiago Gonçalves added the comment: There is this "simple" program that can be easily adapted to test the interface. http://old.nabble.com/Socketcan-with-Python-td29286297.html#a29286297 -- nosy: +ogait87 ___ Python tracker

[issue10141] SocketCan support

Amaury Forgeot d'Arc added the comment: The patch looks good at first glance, but is there a way to test the feature? -- nosy: +amaury.forgeotdarc ___ Python tracker ___ ___

[issue10141] SocketCan support

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue10141] SocketCan support

instigatorirc added the comment: * PF_CAN family of sockets -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10141] SocketCan support

instigatorirc added the comment: forgot to include this: http://en.wikipedia.org/wiki/Socketcan SocketCan is the (currently) Linux-specific Berkley-socket CAN implementation created by Volkswagen. Alot of previous CAN implementations use a rather inferior (explained in can.txt in the Linux so

[issue10141] SocketCan support

Senthil Kumaran added the comment: Looks like an interesting feature request. What are the packages or external libraries which may rely on this and how do they deal with SocketCan support at moment for their requirements? (That thread mentions several, but some details may help further). BT

[issue10141] SocketCan support

New submission from instigatorirc : Python lacks support for the AF_CAN family of sockets ( http://en.wikipedia.org/wiki/Controller_area_network http://lwn.net/Articles/253425/) https://lists.berlios.de/pipermail/socketcan-users/2010-July/001456.html -- components: IO files: socketcan