higery added the comment:
>> What’s more practical for you, a review or a patch?
I think a review is better(thanks for your time:) ), because some changes maybe
needed after I have finished all the issues against the develop command.
--
___
Changes by higery :
Added file: http://bugs.python.org/file23387/adb2cb19ca9b.diff
___
Python tracker
<http://bugs.python.org/issue8668>
___
___
Python-bugs-list mailin
higery added the comment:
>> higery, can you give us a status update? Do you have the time to ...
Sorry to reply to you so late, I will read carefully these reviews asap and try
to make an updated patch before 12th.
--
___
Python tracker
higery added the comment:
>>I’ve just found another problem with MANIFEST files created in Windows: they
>>use CRLF.
One cann't let Python generate MANIFEST files taking Unix-style LF as newline
endings On Windows, I think.
So, does it mean even though we have already mad
higery added the comment:
I have run the 'test_install_lib' on cpython3.3(windows version), the
'test_install_error' failed.
The detail is:
*FAIL: test_install_error (__main__.InstallLibTestCase)
--
Tr
higery added the comment:
>>Here we try to see the distutils test_sdist problem on 2.7.
So sorry that there is not a developed cpython 2.7 on my pc, and my currently
installed Python2.7 has not installed the _msi module, so the running of the
tests does not wor
higery added the comment:
For test_distutils.py, there is not an 'os.link()' function on Windows
platform, so all the tests using this function will report error.
--
___
Python tracker
<http://bugs.python.o
higery added the comment:
>>higery: Would you have a bit of free time to help use here?
Certainly yes.
I have run the test_packaging.py, the main error message is about "ValueError:
path is on mount 'c:', start on mount 'D:'&quo
higery added the comment:
>>IOW, in my opinion, support for setuptools develop command is not needed in
>>packaging core
Then do you also mean support that for setuptools install is also not necessary
in packaging core?
>>and still be taken care directly be the users wan
higery added the comment:
Alexis Metaireau added the comment:
>>I'm not sure why you're talking about it in the context of develop, can you
>>clarify this?
My consideration is : if in Packaging we always convert .egg-info directory to
.dist-info directory, then my
higery added the comment:
Through discussing inside or outside the mailing list on this bug tracker,
current 'develop' has been made a kind of command other than an action. But
there still isn't a consensus of the concrete implemention way, so I keep this
command name as &#
Changes by higery :
Added file: http://bugs.python.org/file22932/af7d14ff129b.diff
___
Python tracker
<http://bugs.python.org/issue8668>
___
___
Python-bugs-list mailin
higery added the comment:
>>BTW higery, did you use any of the build-scripts functionality I developed in
>>the pythonv branch?
NO. I removed the 'copy_scripts' function, so I did not use your developed
functionality. After this change, Packaging module now just builds
higery added the comment:
>>IIUC the support for setup.py is transitional, i.e. "legacy support", for
>>existing packages transitioning from distutils/setuptools/Distribute to
>>packaging. New features should not rely on the existence of setup.py.
I know, the i
higery added the comment:
Current patch has removed old-style scripts support and just retain new-style
wrapper scripts generation support.
Now, it uses only dotted path string to support kind of 'console_scripts' of
setuptools, and uses dotted path with a 'window'
Changes by higery :
Added file: http://bugs.python.org/file22922/4be1917b2a9e.diff
___
Python tracker
<http://bugs.python.org/issue12394>
___
___
Python-bugs-list mailin
higery added the comment:
remote repository? It's just a configuration file under the .hg directory...
--
Added file: http://bugs.python.org/file22744/unnamed
___
Python tracker
<http://bugs.python.org/is
Changes by higery :
Added file: http://bugs.python.org/file22727/c5692393c621.diff
___
Python tracker
<http://bugs.python.org/issue12394>
___
___
Python-bugs-list mailin
higery added the comment:
>>Your test should catch stdout (see other packaging tests for how to do that),
>>so that people or buildbots running the tests don’t see “Hello world!”, and
>>so that you can run asserts for the output.
Thanks. Got it
higery added the comment:
>>The object with the name executable or options is bytes, which you should
>>explicitly convert to a string with decode. I also don’t like using
>>locals(), but that’s a personal style thing.
Thanks for your t
higery added the comment:
>>An octal literal in 3.x is 0o755. Decimal 755 means 0o1363, which is not
>>good :)
Thank you for your reminding. The reason I made this mistake is that I'm not
familiar with the right way to set permissio
higery added the comment:
>>IOError: [Errno 13] Permission denied:
>>'/tmp/user/1013/tmp2xp9qc/tmpwhzzmg/script1'
I have added an 'ensure_directory()' function to build_script.py, but I'm not
sure if it can fix this error.
--
_
higery added the comment:
>>In your Mercurial configuration file, you should set the git option so that
>>diffs can display editions to binary files. See
>>http://hgtip.com/tips/beginner/2009-10-22-always-use-git-diffs/
Thanks.
>>The new scripts feature should re
higery added the comment:
>>packaging.errors.PackagingOptionError: your specific entry
>>'script1=foo.bar.main1.main' does not exist!
I think you did not get the latest version of my code.
--
___
Python tracker
<http://b
higery added the comment:
I hope people can help me test this patch especially on non-Windows platforms.
The main implementation resides in build_scripts.py.
Usage: Just add a 'wrapper-scripts-entries' variable in setup.cfg, which takes
a list type as its value. For instance
Changes by higery :
--
keywords: +patch
Added file: http://bugs.python.org/file22711/6382acfb1685.diff
___
Python tracker
<http://bugs.python.org/issue12
Changes by higery :
Added file: http://bugs.python.org/file22632/2750cd9e2111.diff
___
Python tracker
<http://bugs.python.org/issue8668>
___
___
Python-bugs-list mailin
Changes by higery :
Removed file: http://bugs.python.org/file22630/unnamed
___
Python tracker
<http://bugs.python.org/issue8668>
___
___
Python-bugs-list mailin
higery added the comment:
2011/7/12 Michael Mulich
>
> Michael Mulich added the comment:
>
> The wiki page has been edited to note what the develop command will
> write to the file system. I'll restate it here as well...
>
> The develop command writes three pi
higery added the comment:
>
> ** After the package has been installed in-place (using the develop
> command), how does one identify it as an in development project (or in
> development mode)? -- Case 3 and 6 touch on this topic (case 3 is a little
> vague at this time), but doesn
higery added the comment:
Not yet tested.
--
___
Python tracker
<http://bugs.python.org/issue12344>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by higery :
--
keywords: +patch
Added file: http://bugs.python.org/file22390/6b68c2835d6e.diff
___
Python tracker
<http://bugs.python.org/issue12
higery added the comment:
>No, that’s why I did not close this report but asked you if you could make a
>patch to update this method.
OK, I think I can try to fix it later.
--
___
Python tracker
<http://bugs.python.org/i
higery added the comment:
But can the get_reinitialized_command function reinitialize a command with a
key-value pair? e.g. reinitialize_command('build_ext', inplace=1)
BTW,how to set the repository URI?
--
___
Python trac
Changes by higery :
--
hgrepos: +28
___
Python tracker
<http://bugs.python.org/issue12344>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
New submission from higery :
There is a 'reinitialize_command' function in setuptools' command class which
can initialize a command with a key-value pair, but it seems that
distutils2/packaging does not yet have this function. I think it's useful in
the condition that
Changes by higery :
Removed file: http://bugs.python.org/file22334/unnamed
___
Python tracker
<http://bugs.python.org/issue12279>
___
___
Python-bugs-list mailin
higery added the comment:
> Higery: Michael is willing to work with you on this bug.
>
OK. :)
--
Added file: http://bugs.python.org/file22334/unnamed
___
Python tracker
<http://bugs.python.org/i
Changes by higery :
Removed file: http://bugs.python.org/file22328/test_manifest_reading_sdist.diff
___
Python tracker
<http://bugs.python.org/issue828450>
___
___
Pytho
Changes by higery :
Removed file:
http://bugs.python.org/file21713/change_path_separator_in_MANIFEST.patch
___
Python tracker
<http://bugs.python.org/issue828
higery added the comment:
OK. I recreated a full version patch. I'll remove old patches.
--
Added file:
http://bugs.python.org/file22333/change_path_separator_fullversion.patch
___
Python tracker
<http://bugs.python.org/iss
higery added the comment:
I just recreated this patch against version 2.7, so I'm not sure it can be
applied to all the listed versions.
Note: there still are two pathes, one for sdist.py and another for test_sdist.py
--
Added file: http://bugs.python.org/file
Changes by higery :
Removed file:
http://bugs.python.org/file21764/test_manifest_reading_sdist_v2.diff
___
Python tracker
<http://bugs.python.org/issue828450>
___
___
Changes by higery :
Removed file: http://bugs.python.org/file21725/test_manifest_reading_sdist.diff
___
Python tracker
<http://bugs.python.org/issue828450>
___
___
Pytho
higery added the comment:
Now, the workaround of my code is just setting the 'distinfo-dir' option with
os.curdir value through calling a 'reinitialize_command(self, command,
reinit_subcommands=False, **kw)' function , which is added in packaging's
Command class
Changes by higery :
Added file: http://bugs.python.org/file21764/test_manifest_reading_sdist_v2.diff
___
Python tracker
<http://bugs.python.org/issue828450>
___
___
Pytho
higery added the comment:
>> I'm not sure it is necessary to use TempdirManager here to write tests
>> for MANIFEST reading.
>Well, the sdist command has to run on some directory where some files >exist,
>right? So it’s better to do it in a temp dir that will autom
higery added the comment:
I'm not sure it is necessary to use TempdirManager here to write tests for
MANIFEST reading.
The attachment is the test diff file against my last patch with the latest
version.
Detail:
Step 1: Write sample MANIFEST strings to the MANIFEST file with '/'
Changes by higery :
Added file:
http://bugs.python.org/file21713/change_path_separator_in_MANIFEST.patch
___
Python tracker
<http://bugs.python.org/issue828450>
___
___
Changes by higery :
Removed file:
http://bugs.python.org/file21697/change_path_separator_in_MANIFEST.patch
___
Python tracker
<http://bugs.python.org/issue828
Changes by higery :
Added file:
http://bugs.python.org/file21697/change_path_separator_in_MANIFEST.patch
___
Python tracker
<http://bugs.python.org/issue828450>
___
___
Changes by higery :
Removed file:
http://bugs.python.org/file21691/change_path_separator_in_MANIFEST.patch
___
Python tracker
<http://bugs.python.org/issue828
higery added the comment:
It may be just necessary to hack the write_manifest funtion in sdist.py-
replace all '\' in MANIFEST with '/', thus it will not have other bad side
effects, for instance, it would not change the content of self.filelist and
people can also
Changes by higery :
Removed file: http://bugs.python.org/file21667/test_sdist.diff
___
Python tracker
<http://bugs.python.org/issue828450>
___
___
Python-bugs-list mailin
higery added the comment:
OK. I used this method just because I thought '\' is a special character and if
it's in a file path line, then it must be the separator.
As you say, it may be not that clear for others to know what do
higery added the comment:
Yes, the test fails and the output msg is:
AssertionError: '\\' unexpectedly found in '# file GENERATED by distutils, do
NOT edit\nREADME\nsetup.py\nsomecode\\__init__.py\n'
It means that distutils generates MANIFEST with '\' as file pa
higery added the comment:
I will join GSOC2011 and I find this bug is a good test for me to submit my
patch as a scoring judgment.
I have created a diff file to confirm this bug, but setuptools may have already
fix it, because when using 'python setup.py sdist' to create
57 matches
Mail list logo
