Ray Chason added the comment:
It seems that I, or whoever writes any future test_nntplib.py, would
have to understand how existing tests such as test_smtplib.py work. It
looks like that one is setting up some kind of miniature mail server and
accepting a connection on localhost -- neat trick
Ray Chason added the comment:
Here's take 2.
The pre-patch NNTP class has a long and complicated constructor. Rather
than duplicate this constructor in NNTP_SSL, the patch converts most of
the NNTP class to a new class, NNTPBase, which takes an
already-connected socket as a parameter.
Ray Chason added the comment:
OK, I got a copy of the Subversion sources and the new SSL library looks
like just what is needed here. Examining the other protocol modules
that already support SSL, I find these things:
httplib has:
HTTPConnection(host[, port[, strict[, timeout
New submission from Ray Chason:
This patch adds SSL support to nntplib. It is a followup to issue
#1535659 and addresses the objections raised in the comments to that
issue; it also changes the default port to 563 (nntps) rather than 119
if SSL is requested.
--
components: Library (Lib
