[issue11281] smtplib: add ability to bind to specific source IP address/port

Paulo Scardine added the comment: Is there anything I should improve in order to get this patch commited? -- resolution: -> remind ___ Python tracker <http://bugs.python.org/issu

[issue11281] smtplib: add ability to bind to specific source IP address/port

Paulo Scardine added the comment: Sorry for the last post, I had the impression that I forgot to attach the patch. I'm slow this Monday. -- ___ Python tracker <http://bugs.python.org/is

[issue11281] smtplib: add ability to bind to specific source IP address/port

Paulo Scardine added the comment: oops... -- Added file: http://bugs.python.org/file20945/smtp_lib_source_address.patch ___ Python tracker <http://bugs.python.org/issue11

[issue11281] smtplib: add ability to bind to specific source IP address/port

Paulo Scardine added the comment: Patch attached. -- Added file: http://bugs.python.org/file20944/smtp_lib_source_address.patch ___ Python tracker <http://bugs.python.org/issue11

[issue11281] smtplib: add ability to bind to specific source IP address/port

Paulo Scardine added the comment: Giampaolo, Thanks for your kind review, I will send a patch with suggested changes this weekend. Grazie, -- Paulo -- ___ Python tracker <http://bugs.python.org/issue11

[issue11281] smtplib: add ability to bind to specific source IP address/port

Paulo Scardine added the comment: > There's no need to store the source address as an instance attribute. > Just pass it as-is to socket.create_connection() in __init__ and > connect methods and then get rid of it. Ok, what if user initialize with something like smtplib.SMTP(

[issue11281] smtplib: add ability to bind to specific source IP address/port

Changes by Paulo Scardine : Removed file: http://bugs.python.org/file20844/patch.diff ___ Python tracker <http://bugs.python.org/issue11281> ___ ___ Python-bugs-list m

[issue11281] smtplib: add ability to bind to specific source IP address/port

Paulo Scardine added the comment: Ok, I changed to a single parameter matching socket.create_connection(). I made my best to update tests and docs, but I don't have a clue if it is right. -- Added file: http://bugs.python.org/file20854/smtp_lib_source_address.

[issue11281] smtplib: add ability to bind to specific source IP address/port

Paulo Scardine added the comment: My first idea was to make the argument a tuple to match socket.create_connection(), but SMTP uses host and port arguments, for consistency it's better havin separate source_ip and source_port arguments. As a side effect, it makes easier to specify

[issue11281] smtplib: add ability to bind to specific source IP address/port

Paulo Scardine added the comment: @Giampaolo: should I change the text in Doc/library/smtplib.rst or it is infered from the docstrings? -- ___ Python tracker <http://bugs.python.org/issue11

[issue11281] smtplib: add ability to bind to specific source IP address/port

Paulo Scardine added the comment: Also, it is my first patch and I have no clue about what I'm doing, I don't expect to get it right in the first try - please point any mistakes. -- ___ Python tracker <http://bugs.python.o

[issue11281] smtplib: add ability to bind to specific source IP address/port

Paulo Scardine added the comment: Seems like the signature of Lib.test.mock_socket.create_connection does not match socket.create_connection since 2.7. I need help with the docs; the last argument is positional and optional, using the `[ ]' notation. What is the notation for the new ke

[issue11281] smtplib: add ability to bind to specific source IP address/port

New submission from Paulo Scardine : In smtplib there is now way to bind to an specific source address on a machine with multiple interfaces; also, there no way to control the source port for the connection. Since 2.7, socket.create_connection accepts a source_address parameter, a (host