Pathangi Jatinshravan added the comment:
New patch with code review comments incorporated.
--
Added file: http://bugs.python.org/file40919/patch_review.diff
___
Python tracker
<http://bugs.python.org/issue25
Pathangi Jatinshravan added the comment:
Just saw the code review comments now, didn't know that there was a separate
section for code review comments until now. Will take a look and implement them.
--
___
Python tracker
<http://bugs.py
Pathangi Jatinshravan added the comment:
Has there been any movement on this issue?
--
___
Python tracker
<http://bugs.python.org/issue25228>
___
___
Python-bug
Pathangi Jatinshravan added the comment:
Hi, if this is not too critical of a bug, can I be assigned to this issue?
--
nosy: +Pathangi Jatinshravan
___
Python tracker
<http://bugs.python.org/issue25
Pathangi Jatinshravan added the comment:
Hi, I've made the change to use str.find() and removed the while loop, can you
take a look at it?
--
Added file: http://bugs.python.org/file40717/patch.diff
___
Python tracker
<http://bugs.py
Pathangi Jatinshravan added the comment:
Oh not intentional. Must have clicked something by mistake
--
versions: +Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/issue25
Pathangi Jatinshravan added the comment:
Hi Tim, I have submitted a patch (patch_with_test.diff). Can you take a look at
this?
--
___
Python tracker
<http://bugs.python.org/issue25
Pathangi Jatinshravan added the comment:
Is this what you wanted?
--
Added file: http://bugs.python.org/file40709/patch_with_test.diff
___
Python tracker
<http://bugs.python.org/issue25
Pathangi Jatinshravan added the comment:
Added a patch where unit test has been modified to include the above case. I
have signed the agreement.
--
Added file: http://bugs.python.org/file40703/patch_unittest.diff
___
Python tracker
<h
Pathangi Jatinshravan added the comment:
Hi Tim, I have submitted a patch for this issue (patch_final.diff, the earlier
one failed a UT). Now all UTs are passing. Can you take a look at this?
--
Added file: http://bugs.python.org/file40701/patch_final.diff
Pathangi Jatinshravan added the comment:
Oops, sorry looks like a unit test is failing. I will fix it and submit another
one soon.
--
___
Python tracker
<http://bugs.python.org/issue25
Pathangi Jatinshravan added the comment:
Hi I have made a patch for this, can anyone review and let me know?
--
versions: -Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file40700/patch.diff
___
Python
Pathangi Jatinshravan added the comment:
This is the first ever bug I will be working on so there might be a bit of a
learning curve, but I'll do my best to come out with something by this week.
--
___
Python tracker
<http://bugs.py
Pathangi Jatinshravan added the comment:
Hi, can I be assigned to this behaviour issue?
--
nosy: +Pathangi Jatinshravan
___
Python tracker
<http://bugs.python.org/issue25
14 matches
Mail list logo