[issue31920] pygettext ignores directories as inputfile argument

2017-11-03 Thread Oleg Krasnikov
Oleg Krasnikov added the comment: Thanks for quite sensible notes Serhiy. I've fixed all that in recent commit and added a regression test. Still not sure about "testing conventions" here cause this is my first PR to python repository, so please let me know if something is wro

[issue31920] pygettext ignores directories as inputfile argument

2017-11-02 Thread Oleg Krasnikov
Change by Oleg Krasnikov : -- keywords: +patch pull_requests: +4193 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue31920> ___ ___ Py

[issue31920] pygettext ignores directories as inputfile argument

2017-11-02 Thread Oleg Krasnikov
New submission from Oleg Krasnikov : This happens because pygettext's `getFilesForName` calls `os.walk` as if it was `os.path.walk`. But the `walk` function has changed signature when moved from `os.path` to `os`. So now `_visit_pyfiles` is passed to `walk` as `topdown` argument whi