Nikolay Bogoychev added the comment:
Hey Serhiy,
The use of namedtuple was requested specifically at a review, I didn't
implement it like this initially: https://bugs.python.org/review/16099/#ps6205
I wasn't aware of the performance implications. Could you please explain to me
t
Nikolay Bogoychev added the comment:
Hey,
Friendly reminder that there has been no activity on this issue for more than
an year.
Cheers,
Nick
--
___
Python tracker
<http://bugs.python.org/issue16
Nikolay Bogoychev added the comment:
Hey,
Just a friendly reminder that the patch is pending for review and there has
been no activity for 3 months (:
--
___
Python tracker
<http://bugs.python.org/issue16
Nikolay Bogoychev added the comment:
Hey,
Just a friendly reminder that there has been no activity for a month and a half
and v3 is pending for review (:
--
___
Python tracker
<http://bugs.python.org/issue16
Nikolay Bogoychev added the comment:
Updated patch, all comments addressed, sorry for the 6 months delay. Please
review
--
Added file: http://bugs.python.org/file35377/robotparser_v3.patch
___
Python tracker
<http://bugs.python.org/issue16
Nikolay Bogoychev added the comment:
Hey,
Just a reminder friendly reminder that there hasn't been any activity for a
month and I have released a v2, pending for review (:
--
___
Python tracker
<http://bugs.python.org/is
Nikolay Bogoychev added the comment:
Oh... Sorry for the spam, could you please verify my documentation link syntax.
I'm not entirely sure I got it right.
--
___
Python tracker
<http://bugs.python.org/is
Nikolay Bogoychev added the comment:
Thank you for the review!
I have addressed your comments and release a v2 of the patch:
Highlights:
No longer crashes when provided with malformed crawl-delay/robots.txt
parameter.
Returns None when parameter is missing or syntax is invalid.
Simplified
Nikolay Bogoychev added the comment:
Hey,
it has been more than an year since the last activity.
Is there anything else I should do in order for someone of the python devs team
to review my changes and perhaps give some feedback?
Nick
Nikolay Bogoychev added the comment:
Reformatted patch
--
Added file: http://bugs.python.org/file27477/robotparser_reformatted.patch
___
Python tracker
<http://bugs.python.org/issue16
Nikolay Bogoychev added the comment:
Okay, here's a proper patch with documentation entry and test cases.
Please review and comment
--
Added file: http://bugs.python.org/file27476/robotparser.patch
___
Python tracker
<http://bugs.py
Nikolay Bogoychev added the comment:
Okay, sorry didn't know that (:
Here's the same patch (Same functionality) for python3
Feedback is welcome, as always (:
--
Added file: http://bugs.python.org/file27374/robotparser.patch
___
Python trac
New submission from Nikolay Bogoychev:
Robotparser doesn't support two quite important optional parameters from the
robots.txt file. I have implemented those in the following way:
(Robotparser should be initialized in the usual way:
rp = robotparser.RobotFileParser()
rp.set_url(..)
rp
13 matches
Mail list logo