[issue17607] missed peephole optimization (unnecessary jump at end of function after yield)

2013-03-31 Thread Neal Norwitz
New submission from Neal Norwitz: >>> def foo(): ... if x: ... yield None ... >>> dis.dis(foo) 2 0 LOAD_GLOBAL 0 (x) 3 POP_JUMP_IF_FALSE 14 3 6 LOAD_CONST 0 (None) 9 YIELD_VALUE

[issue17430] missed peephole optimization

2013-03-15 Thread Neal Norwitz
New submission from Neal Norwitz: >>> def fo(): ... if a: ... if b: ... if c: ...print ... >>> dis.dis(fo) 2 0 LOAD_GLOBAL 0 (a) 3 POP_JUMP_IF_FALSE 28 3 6 LOAD_GLOBAL 1 (

[issue17335] FieldStorageClass is messed up

2013-03-01 Thread Neal Norwitz
New submission from Neal Norwitz: This problem goes back to 2.6 at least. In Lib/cgi.py FieldStorageClass = None def read_multi(self, environ, keep_blank_values, strict_parsing): """Internal: read a part that is itself multipart.""" ib =

[issue17068] peephole optimization for constant strings

2013-01-28 Thread Neal Norwitz
New submission from Neal Norwitz: I was looking through code like this: foo = '%s%s%s' % ('https://', host, uri) and realized this could be rewritten by the interpreter as: foo = 'https://%s%s' % (host, uri) I tried to determine how much code this might

[issue13764] Misc/build.sh is outdated... talks about svn

2012-01-13 Thread Neal Norwitz
Neal Norwitz added the comment: If this script isn't used any more, it should be removed. On Fri, Jan 13, 2012 at 8:31 AM, Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > > I think the script was used by the "period regression test" crontask that >

[issue10399] AST Optimization: inlining of function calls

2010-11-20 Thread Neal Norwitz
Neal Norwitz added the comment: There is some precedent for allowing minor differences in -O mode. http://mail.python.org/pipermail/python-dev/2008-February/077193.html I think we should push this to see how practical we can make it. Dave, this is great work, I'm really interested to se

[issue4970] test_os causes delayed failure on x86 gentoo buildbot: Unknown signal 32

2010-04-13 Thread Neal Norwitz
Neal Norwitz added the comment: Thanks for taking care of this guys. Sorry, I got swamped with mail and had to archive 3,000+ messages. It looks like it's in good hands. Let me know if there's anything you need. I may not have access to the box anymore, however, I can always co

[issue7008] str.title() misbehaves with apostrophes

2009-09-28 Thread Neal Norwitz
Neal Norwitz added the comment: I don't recall anything specifically wrt removing capwords. Most likely it was something that struck me as not widely used or really necessary--a good candidate to be removed. Applications could then write the fucntion however they chose which would avoi

[issue5023] Segfault in datetime.time.strftime("%z")

2009-01-27 Thread Neal Norwitz
Neal Norwitz added the comment: Can you debug this problem any further? What is the C call stack? Does the problem occur if you build in debug mode (./configure --with-pydebug)? Does the problem occur with a different compiler (if you have access to another one on the same box

[issue4597] EvalFrameEx fails to set 'why' for some exceptions

2008-12-08 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: The patch looks good. These problems also apply to 2.5 I assume? You might want to ping MvL to let him know since he's about to cut that release. -- keywords: -needs review nosy

[issue4582] type of __builtins__ changes if in main module or not

2008-12-07 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: This happens on 2.4 and 3.0, probably all versions: When running this simple program (save to a file): print(type(__builtins__)) __import__(__file__.split('/')[-1][:-3]) I get: I would expect the type to be consiste

[issue4264] Patch: optimize code to use LIST_APPEND instead of calling list.append

2008-11-05 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Interesting approach. I was surprised to see the change to the AST, but I understand why you did it. I think if the AST optimization approach works out well, we will want to have some more general mechanism to communicate these optimi

[issue3660] reference leaks in 3.0

2008-09-04 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: The only one that is probably an issue based on Antoine's info is: test_unicode leaked [1, 1] references, sum=2 I've seen test_urllib2_localnet leak 3 before. I don't know that it's a real leak. I'm pretty sur

[issue1210] imaplib does not run under Python 3

2008-08-26 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: This may not be a real release blocker, but I want to raise the priority. It is a regression and we should try to fix it, especially if it's easy. -- priority: normal -> release blocker

[issue3657] pickle can pickle the wrong function

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: It seems that if the tests are run in this order: ./python -E -tt ./Lib/test/regrtest.py -u all test_xmlrpc test_ctypes test_json test_bsddb3 test_pickletools The error will trigger consistently. That is in 2.6 with a debug build on

[issue3673] bsddb module leaks memory

2008-08-24 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: The attached patch against 2.6 fixes the memory leaks reported against the bsddb module. There are still (probably) reference leaks. Jesus, it would be great if you can look at this before the release. -- assignee: jcea comp

[issue3657] pickle can pickle the wrong function

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Indeed. The problem was an incorrect conversion of str -> unicode, instead of converting to bytes. On getting the buffer from unicode, it tried to read data which was uninitialized. Hmmm, this fix is for 3.0 only, but the p

[issue3651] eval() leaks 1 reference every time

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Also there should be a Misc/NEWS entry added. Also check the doc to see it needs updating wrt ownership. -- type: -> resource usage ___ Python tracker <[EMAIL PROTECTED]> <http

[issue3651] eval() leaks 1 reference every time

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: With the latest patch (and the one addition PyBuffer_Release() I noted above), valgrind is happy wrt memory leaks. The only problem valgrind found is a read of uninitialized memory. See http://bugs.python.org/issue3657 . I don'

[issue3657] pickle can pickle the wrong function

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: The valgrind errors below are possibly related. Conditional jump or move depends on uninitialised value(s) PyUnicodeUCS2_EncodeUTF8 (unicodeobject.c:2216) _PyUnicode_AsString (unicodeobject.c:1417) save (_pickle.c:930) Pickle

[issue1838] Ctypes C-level infinite recursion

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- assignee: -> theller components: +ctypes -Extension Modules nosy: +theller ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2562] Cannot use non-ascii letters in disutils if setuptools is used.

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2562> ___ ___

[issue2747] Documentation of new gobject types fails

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2747> ___ ___

[issue1840] Tools/i18n/msgfmt.py fixes for Python 3.0

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Is this still a problem? -- nosy: +nnorwitz type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue1658] "RuntimeError: dictionary changed size during iteration" in Tkinter

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1658> ___ ___

[issue1210] imaplib does not run under Python 3

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Is this still a problem? -- nosy: +nnorwitz type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2456] Make sysmodule.c compatible with Bazaar

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- type: crash -> feature request ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2456> ___ _

[issue1375] hotshot IndexError when loading stats

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- type: crash -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1375> ___ ___

[issue3662] _fileio._FileIO segfaults

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Daniel, thanks for running the fuzzer! It would be great if you could keep running it and find any more problems before releasing 2.6 and 3.0. I agree with Benjamin and Amaury. PyArg_ParseTupleAndKeywords() shouldn't update the po

[issue3304] invalid call to PyMem_Free() in fileio_init()

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: In 3.0 the free is necessary, though see http://bugs.python.org/issue3662 . -- nosy: +nnorwitz status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3651] eval() leaks 1 reference every time

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Another PyBuffer_Release(&pin); looks necessary at @@ -805,6 +807,7 @@. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.p

[issue3610] Fix gdbinit for Python 3.0

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: I fixed some problems in r66016. This patch seems like it has other things which might be useful, so I'll keep it open until it's handled. -- nosy: +nnorwitz ___ Python tracker &

[issue3660] reference leaks in 3.0

2008-08-24 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: Even after adding the current patch in http://bugs.python.org/issue3651 there are many reference leaks. This bug can be a placeholder for all the reference leaks returned from: ./python ./Lib/test/regrtest.py -R 3:2 -uall,-bsddb

[issue2744] Fix test_cProfile

2008-08-24 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3651] eval() leaks 1 reference every time

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Even with the patch, there are still tons of leaks. I don't know if it's due to the same problem or not. So far there is: test_unittest leaked [124, 124] references, sum=248 test_array leaked [110, 110] references, sum=

[issue3627] apple security patches need to be forward ported to py3k

2008-08-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Committed revision 66009. -- assignee: -> nnorwitz resolution: -> fixed status: open -> closed type: -> security ___ Python tracker <[EMAIL PROTECTED]> <http:

[issue3657] pickle can pickle the wrong function

2008-08-24 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: test_pickletools fails sporadically on at least two platforms I've seen. http://www.python.org/dev/buildbot/all/x86%20gentoo%20trunk/builds/4120/step-test/0 http://www.python.org/dev/buildbot/all/ppc%20Debian%20unstable%20trunk/

[issue3656] unicode encoding has lots of leaks of bytes

2008-08-23 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: This is a partial (or complete) duplicate of 3651. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3651] eval() leaks 1 reference every time

2008-08-23 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: This is a partial (or complete) duplicate of 3656. -- nosy: +nnorwitz ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3656] unicode encoding has lots of leaks of bytes

2008-08-23 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: There are also tons of reference leaks when running regrtest.py with -R. Even code as simple as this leaks: >>> eval('1') 1 [40731 refs] >>> eval('1') 1 [40732 refs] >>> eval('1

[issue3656] unicode encoding has lots of leaks of bytes

2008-08-23 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: Some of these leaks reported by valgrind are likely duplicates. I don't know how many individual cases of these leaks there are. 11,119 bytes in 14 blocks are possibly lost in loss record 86 of 119 realloc (vg_replace_m

[issue3627] apple security patches need to be forward ported to py3k

2008-08-20 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: The trunk revision was 65335. -- components: Interpreter Core messages: 71608 nosy: nnorwitz priority: release blocker severity: normal status: open title: apple security patches need to be forward ported to py3k versions: Pyth

[issue2620] Multiple buffer overflows in unicode processing

2008-07-27 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Committed revision 65261 for 2.5 Committed revision 65262 for 2.4. -- status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue1574217] isinstance swallows exceptions

2008-05-19 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: > I'd like to clarify the approach to fixing these types of problems. > ... > However, I like constricting it to AttributeError only as that would > make it much less confusing. This might be something to bring up on &

[issue2222] Memory leak in os.rename?

2008-05-07 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- priority: normal -> critical __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue> __ ___ Pyt

[issue2772] Add PendingDeprecationWarning for % formatting

2008-05-06 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Why not use the normal recursion check mechanism? Specifically, if (Py_EnterRecursiveCall("unicode % ")) return NULL; // err = Warn(); Py_LeaveRecursiveCall(); I don't see where the

[issue1496032] test_float segfaults with SIGFPE on FreeBSD 6.0 / Alpha

2008-04-24 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: I think `uname -m` will be equal to "alpha" in this case. There are several uses of `uname -m` in configure.in. You might need to add a new section. It might also be possible to clean up various special cases to make a g

[issue2601] [regression] reading from a urllib2 file descriptor happens byte-at-a-time

2008-04-15 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: So if the fix was applied to 2.5 branch and 2.6 (3.0 should have picked up from 2.6 automatically), can we close this bug? __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2601] [regression] reading from a urllib2 file descriptor happens byte-at-a-time

2008-04-14 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Bumping the priority. I'd like to see this fixed before the next release. What version(s) does this problem apply to: 2.5, 2.6, 3.0? -- nosy: +nnorwitz priority: critical -> release blocker

[issue2541] Unicode escape sequences not parsed in raw strings.

2008-04-14 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: What is the status of this bug? AFAICT, the code is now correct. Have the doc changes been applied? The resolution on this report should be updated too. It's currently rejected. -- nosy

[issue2235] __eq__ / __hash__ check doesn't take inheritance into account

2008-04-14 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- assignee: amaury.forgeotdarc -> gvanrossum __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2235> __ __

[issue2611] Extend buildbot web interface to allow for forced tests to be run on a slave in verbose mode.

2008-04-14 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: > I think this will be fairly difficult to set up. If the clean buildstep > had been executed, you would have to rerun configure and compile before > you can run any tests. We could re-order and do clean first. That woul

[issue2550] SO_REUSEADDR doesn't have the same semantics on Windows as on Unix

2008-04-06 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Trent, go ahead and try this out. We should definitely be moving in this direction. So I'd rather fix the problem than keep suffering with the current problems of not being able to run the test suite concurrently. I think bind_po

[issue2538] memoryview of bytes is not readonly

2008-04-04 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Travis, could you take a look? -- assignee: -> teoliphant nosy: +nnorwitz, teoliphant __ Tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2548] Undetected error in exception handling

2008-04-04 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Brett, didn't you have a similar problem you fixed a while ago? I assigned to you for more input, feel free to reset to nobody. -- assignee: -> brett.cannon nosy: +brett.cannon, nnorwitz priority: ->

[issue2546] Python-2.5.2: crash in visit_decref () at Modules/gcmodule.c:270

2008-04-04 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: I'm setting the priority to release blocker for now. George, please provide a way for us to reproduce with a stock python (ie, no third party extensions). Thanks. -- nosy: +nnorwitz priority: -> r

[issue2526] str.format() :n format does not appear to work

2008-04-04 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Eric, could you take a look? -- assignee: -> eric.smith nosy: +eric.smith, nnorwitz priority: -> high __ Tracker <[EMAIL PROTECTED]> <http://bugs

[issue2515] Segfault while operating on closed sqlite3 cursor.

2008-04-04 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- priority: -> release blocker __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2515> __ ___ Pyt

[issue2515] Segfault while operating on closed sqlite3 cursor.

2008-04-04 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Gerhard, could you take a look? -- assignee: -> ghaering nosy: +ghaering, nnorwitz __ Tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue1179] [CVE-2007-4965] Integer overflow in imageop module

2008-04-04 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: I think this was a module that I skipped. I think Anthony might have had a patch, but if we have a fix, I'm not sure it matters. We need to fix this for 2.5.3, upping the priority. -- nosy: +anthonybaxter priority: high

[issue1631171] implement warnings module in C

2008-04-01 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: On Tue, Apr 1, 2008 at 6:14 AM, Brett Cannon <[EMAIL PROTECTED]> wrote: > > Brett Cannon <[EMAIL PROTECTED]> added the comment: > > Neal's issues are addressed in this patch. I also finally filled out &

[issue1631171] implement warnings module in C

2008-03-31 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: I didn't realize this was waiting for me. You should have just checked it in, that would have gotten me to review faster. :-) pythonrun.c: * Should PyModule_GetWarningsModule() return a valid pointer? * The code below crashe

[issue2477] parser support for future import of unicode_strings

2008-03-28 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Christian checked this in a few days ago in r61953 and a few other revisions. -- resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs

[issue1503] test_xmlrpc is still flakey

2008-03-27 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Ugh. The manpage for accept on Ubuntu 6.10 says: """ On Linux, the new socket returned by accept() does not inherit file status flags such as O_NONBLOCK and O_ASYNC from the listening socket. This behaviour diffe

[issue2459] speedup loops with better bytecode

2008-03-26 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Antoine, I hope to look at this patch eventually. Unfortunately, there are too many build/test problems that need to be resolved before the next release. If you can help out with those, I will be able to review this patch

[issue2491] io.open() handles errors differently on different platforms

2008-03-25 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: The attached file has a snapshot of the python.org homepage that was causing test_urllibnet to fail on some platforms (2 sparc, and ia64 at least), but not other platforms. This should be handled consistently. I don't know i

[issue2477] parser support for future import of unicode_strings

2008-03-24 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: This is a patch that modifies the parser to allow getting the future import flags into the AST. There are 2 approaches that are embedded within the patch. Both approaches can be seen in Python/pythonrun.c. 1) update_flags_fro

[issue2470] Need fixer for dl (removed) -> ctypes module

2008-03-23 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: r61837 removed the dl module. It needs a 2to3 fixer written to use ctypes. -- assignee: collinwinter components: 2to3 (2.x to 3.0 conversion tool) messages: 64394 nosy: collinwinter, nnorwitz priority: critical severity:

[issue1068881] TclError not a subclass of StandardError

2008-03-20 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: StandardError has been removed from Python 3.0. It's use is deprecated. Instead of catching StandardError, do: try: # ... except Exception: # ... -- assignee: loewis -> nnorwitz nosy: +nnorwitz resoluti

[issue2183] optimize list comprehensions

2008-03-19 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Ya, I'll get around to it...hopefully soon. But if someone wants to do it for me, I won't complain. :-) __ Tracker <[EMAIL PROTECTED]> <http://

[issue2403] Add figleaf coverage metrics

2008-03-18 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: > * ../../python.exe changed to sys.executable. > * Figleaf is 69kb. It seems to work fine doing it all in one read() > call. Should it be chunked? At 69kb, nah. It should be good enough for the first cut. > * O

[issue2409] regrtest should not just skip imports that fail

2008-03-18 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: Guido mentioned this in python-3000-checkins. I agree the problem should be fixed. """ I think the automatic skip on ImportError is harmful. We should add a helper function to test_support so that

[issue2403] Add figleaf coverage metrics

2008-03-18 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Thanks for the patch. It would be nice to get more instrumentation like coverage, performance, etc. Here are some things I noticed while reviewing the patch: * This won't work on unix other than OSX. Can you change ../../py

[issue2400] from .foo import * should work

2008-03-18 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: Explicit relative imports using from .foo import * should work. http://mail.python.org/pipermail/python-3000/2008-March/012564.html -- components: Interpreter Core messages: 63942 nosy: nnorwitz priority: critical severity:

[issue2332] Renaming of attributes on functions need to be backported.

2008-03-17 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Committed revision 61492. -- resolution: -> fixed status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs

[issue2321] return more memory from unicode objects to system

2008-03-17 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2321> __ ___ Python-bugs-list mailing list Unsubscribe: http

[issue2321] return more memory from unicode objects to system

2008-03-17 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- assignee: -> nnorwitz resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://b

[issue2321] return more memory from unicode objects to system

2008-03-17 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: After discussing this with MvL, I'll check this patch into trunk and 2.5. Alec, if you find other issues, please create a new patch. Committed revision 61458. Committed revision 61485. (2.5) __ Trac

[issue2375] PYTHON3PATH environment variable to supersede PYTHONPATH for multi-Python environments

2008-03-17 Thread Neal Norwitz
Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- assignee: -> nnorwitz nosy: +nnorwitz priority: -> urgent __ Tracker <[EMAIL PROTECTED]> <http://bugs

[issue2321] return more memory from unicode objects to system

2008-03-17 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: On Mon, Mar 17, 2008 at 11:55 AM, Alec Thomas <[EMAIL PROTECTED]> wrote: > > Alec Thomas <[EMAIL PROTECTED]> added the comment: > > Hi Neal, > > This seems to be a more general problem than just unicode.

[issue2321] return more memory from unicode objects to system

2008-03-17 Thread Neal Norwitz
New submission from Neal Norwitz <[EMAIL PROTECTED]>: This patch returns more memory to the system when doing: >>> x = [unicode(i) for i in xrange(100)] >>> del x If the above code is done, the memory before and after is quite different. After this patch, the

[issue2185] code objects should conserve memory

2008-03-15 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Marshal is the wrong place for this sort of thing (the code object is where it should be done). I botched the analysis. The case is common, but only for the empty tuple which I forgot to ignore. (None,) was a common case when I measu

[issue2291] Catching all exceptions with 'object'

2008-03-15 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: See PEP 352. Currently this is slated for python 2.8. Perhaps the schedule should be sped up a bit in light the current release schedule. Brett, any comments? We should add all the warnings from PEP 352 with the -3 flag

[issue2262] Helping the compiler avoid memory references in PyEval_EvalFrameEx

2008-03-09 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: Can't next_instr and stack_pointer move inside the for loop too? __ Tracker <[EMAIL PROTECTED]> <http://bugs.

[issue2262] Helping the compiler avoid memory references in PyEval_EvalFrameEx

2008-03-09 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: I bet with just a little more work, you could get rid of t and stream. t is only used for a single set of opcodes (STORE_SLICE+n). stream is only used for the PRINT opcodes. The code in print could be moved to a function which might

[issue2181] optimize out local variables at end of function

2008-02-27 Thread Neal Norwitz
Neal Norwitz added the comment: > I suppose you are aware that performing this optimization in general > would break a lot of existing code that uses inspect.getstack() or > sys._getframe() to peek at the caller's local variables. I know this Yes, with this optimization the

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

2008-02-26 Thread Neal Norwitz
Neal Norwitz added the comment: On Tue, Feb 26, 2008 at 12:51 AM, Christian Heimes <[EMAIL PROTECTED]> wrote: > > > * Verify that it's faster by compiling python in a release build > > It's roughly the same speed. :/ The variation between timeit runs is >

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Neal Norwitz
Neal Norwitz added the comment: Can you add more tests? It seems that almost all the examples given in this thread are good examples. Also something like: while 1: if cond: return 1 return 2 return 3 There are a bunch more cases that could be added for where the code should be

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

2008-02-25 Thread Neal Norwitz
Changes by Neal Norwitz: -- assignee: nnorwitz -> tiran _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1691070> _ ___ Python-bugs-li

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

2008-02-25 Thread Neal Norwitz
Neal Norwitz added the comment: I looked over the new patch Christian uploaded and I think I understand what's going on. I didn't do a through comparison, but if all the tests pass, I think that's good enough. Good work! Here are the issues I would like to see fixed before chec

[issue2168] gdbm needs to be iterable

2008-02-25 Thread Neal Norwitz
Neal Norwitz added the comment: Thomas, thanks for fixing this. I didn't see any specific problems with the patch, but I'm wondering why the code doesn't just call has_key in both cases? -- nosy: +nnorwitz __ Tracker <[EMAIL

[issue1518] Fast globals/builtins access (patch)

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: I've gone over this at a high-level and looked for various outstanding issues. Below are my comments. I didn't delve into this in detail. There are a lot of questions too. I think this is very interesting and hope that we can get it working, 100% r

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: Christian, Could you clean this patch up? Specifically: * Put everything into one patch * Eliminate unnecessary changes (changing variable name or whitespace) * Conform to the style in the file * Verify all the tests run with regrtest.py -u all when built

[issue2181] optimize out local variables at end of function

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: Guido says to do it only with -O. http://mail.python.org/pipermail/python-dev/2008-February/077193.html __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/

[issue2185] code objects should conserve memory

2008-02-24 Thread Neal Norwitz
New submission from Neal Norwitz: Various bits are often duplicated in code objects. For example, sometimes names and varnames are equal. In this case, we don't need two objects since they are both const. This patch implements a trivial fix for this case. However, there are more cases

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: It would be great to see test cases with this change. That would help answer Alexander's question too. -- nosy: +nnorwitz __ Tracker <[EMAIL PROTECTED]> <http://bugs.python

[issue2181] optimize out local variables at end of function

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: I forgot to mention that if another loop was added to PyCode_Optimize that kept track of the # of times each local variable was LOAD_FAST/STORE_FAST/DELETE_FAST and that the count was 2, we could perform a similar optimization without requiring the return. Bonus

[issue2183] optimize list comprehensions

2008-02-24 Thread Neal Norwitz
New submission from Neal Norwitz: Optimize list comprehensions by using the list on the stack, rather than storing in a (local/global) variable. This reduces the size of the stack by one pointer, reduces the bytecode size by 8, and reduces the iterations in the eval loop by 2 + # of iterations

[issue2181] optimize out local variables at end of function

2008-02-24 Thread Neal Norwitz
Neal Norwitz added the comment: I forgot to mention that if another loop was added to PyCode_Optimize that kept track of the # of times each local variable was LOAD_FAST/STORE_FAST/DELETE_FAST and that the count was 2, we could perform a similar optimization without requiring the return. Bonus

[issue2181] optimize out local variables at end of function

2008-02-24 Thread Neal Norwitz
New submission from Neal Norwitz: This patch optimizes code like: x = any_expression return x to: return any_expression Currently it only optimizes out the local variable if there is a return because it can't determine if this is the last use of the variable or not. This shou

  1   2   >