Michael Henry added the comment:
David,
Your patch looks fine to me. I like putting the logic is a
separate class as you've done. I looked in itertools for
something to perform the job of the each_last() generator I'd
had in my patch, but I didn't see anything. I l
New submission from Michael Henry :
The email module's body_encode() function (found in
quoprimime.py) can generate oversized encoded lines that exceed
the maximum line length specified by the maxlinelen parameter.
The attached test case
'test_encode_trailing_space_at_maxlinelen
New submission from Michael Henry :
The attached patch adds unit tests and some minor fixes for the email
module's quoprimime.py file. The header_encode() function did not
properly return an empty string when given an empty string. The
decode() function did not properly detect the
New submission from Michael Henry :
The attached patch includes additional unit tests for the email module,
and splits pre-existing test_header_encode() and test_decode() functions
into individual test functions.
--
components: Library (Lib)
files: test_email_additional_tests.patch
Michael Henry added the comment:
Issue #5633 contains two additional unit tests that can't be added until
that ticket's bug is fixed.
--
nosy: +rhettinger
resolution: accepted ->
status: closed -> open
___
Python tracker
<htt
Michael Henry added the comment:
Issue #11578 added unit tests for timeit.py. Because of this bug, two tests
were omitted. In the attached patch are the previously withheld unit tests
and an alternate method of fixing the bug (developed before Tim's fix was
noticed). It's not c
New submission from Michael Henry :
The timeit.py module has no specific tests. The attached patch adds
Lib/test/test_timeit.py for unit testing, along with slight modifications
to timeit.py to support predictable unit testing.
--
components: Library (Lib)
files: timeit_unit_test.patch
New submission from Michael Henry :
The attached test program, test_email_attach_to_string.py, demonstrates the
desire for email.message.Message.attach to raise a more helpful exception when
the user incorrectly invokes attach() after setting the payload to a string.
--
components
New submission from Michael Henry :
In email.Message.get_payload, there is the following out-of-date comment:
"""
# payload can be bytes here, (I wonder if that is actually a bug?)
"""
The code can actually handle bytes payloads.
--
components: Libra
New submission from Michael Henry :
The function email.Message.as_string has an out-of-date comment:
"""
This is a convenience method and may not generate the message exactly
as you intend because by default it mangles lines that begin with
"From ". For more fle
New submission from Michael Henry :
test_email_codecs.py in the email module should be ported to Python 3.
The attached patch ports test_email_codecs.py and hooks it into the email test
suite.
--
components: Library (Lib)
files: port-test_email_codecs.py.patch
keywords: patch
messages
11 matches
Mail list logo