[issue30767] logging must check exc_info correctly

2017-10-13 Thread Matthew Patton
Matthew Patton added the comment: I've triggered it which is why I looked for the problem and offered the defensive patch. As API writers you can NEVER assume your parameters are what you think they should be and just blindly pr

[issue30767] logging must check exc_info correctly

2017-10-12 Thread Matthew Patton
Change by Matthew Patton : -- pull_requests: +3950 ___ Python tracker <https://bugs.python.org/issue30767> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31763] Add NOTICE level to the logging module

2017-10-12 Thread Matthew Patton
Matthew Patton added the comment: syslog(3) is cited in the code as inspiration and has been the goto definition for logging levels for 40 years across many, many projects. NOTICE is incredibly useful especially to those of us who are sysadmins. Why would Python not implement the full suite

[issue30767] logging must check exc_info correctly

2017-10-12 Thread Matthew Patton
Matthew Patton added the comment: I believe this diff addresses the failure of formatException() to check it's parameter's datatype. I still maintain this should be re-opened since it's guaranteed to raise an exception when someone sets 'exc_info=TruthyValue' in k

[issue30767] logging must check exc_info correctly

2017-10-12 Thread Matthew Patton
Matthew Patton added the comment: And the reason to stomp on the "Level " is because by not doing so the message that is a single field (regex/awk) has been converted non-deterministically into two. This is very bad behavior. If emitting the string/int as-is looks wrong then &q

[issue30767] logging must check exc_info correctly

2017-10-12 Thread Matthew Patton
Matthew Patton added the comment: Additionally (probably should have separate PR) the _checkLevel was full of holes. First, it's allowing any Integer which if you're claiming to "check" things is rather silly. At least bounds-check it to GE to NOTSET and LE to CRITICAL (

[issue30767] logging must check exc_info correctly

2017-10-12 Thread Matthew Patton
Matthew Patton added the comment: "exc_info which, if it does not evaluate as false", so we provide '1' or 'True'. The IF passes and immediately the formatter tries to dereference it blindly assuming it's Tuple and throws an Exception. Either the Formatter

[issue30767] logging must check exc_info correctly

2017-10-11 Thread Matthew Patton
Change by Matthew Patton : -- nosy: +mp5023 ___ Python tracker <https://bugs.python.org/issue30767> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30767] logging must check exc_info correctly

2017-10-11 Thread Matthew Patton
Change by Matthew Patton : -- versions: +Python 3.7 ___ Python tracker <https://bugs.python.org/issue30767> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31763] Add NOTICE level to the logging module

2017-10-11 Thread Matthew Patton
Change by Matthew Patton : -- keywords: +patch pull_requests: +3932 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue31763> ___ ___ Py

[issue31763] Add TRACE level to the logging module

2017-10-11 Thread Matthew Patton
New submission from Matthew Patton : This was inspired by 31732. The logging module has 5 log levels: CRITICAL, ERROR, WARNING, INFO, DEBUG per https://docs.python.org/dev/library/logging.html#logging-levels However syslog(3) has for decades defined NOTICE and I can't think of a good r

[issue30767] logging must check exc_info correctly

2017-10-04 Thread Matthew Patton
Change by Matthew Patton : -- keywords: +patch pull_requests: +3863 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue30767> ___ ___ Py