Manuel Barkhau added the comment:
This issue cropped up recently in the black project:
https://github.com/psf/black/issues/1631
It appears to me that PR 7666 was closed without being merged.
I created https://github.com/python/cpython/pull/21971 before I had found this
issue
Change by Manuel Barkhau :
--
nosy: +mbarkhau
nosy_count: 6.0 -> 7.0
pull_requests: +21079
pull_request: https://github.com/python/cpython/pull/21971
___
Python tracker
<https://bugs.python.org/issu
Manuel Barkhau added the comment:
> If you pass a string, you will get a string, so existing code will continue
> to work as before.
Somebody might have code that is running against a flat directory and have
written their ignore function expecting to get a pathlib.Path, because that&
Manuel Barkhau added the comment:
> For completeness, a similar problem is present also on python < 3.8
Fair point. I'll have a look.
--
___
Python tracker
<https://bugs.python.
Change by Manuel Barkhau :
--
pull_requests: +17554
pull_request: https://github.com/python/cpython/pull/18168
___
Python tracker
<https://bugs.python.org/issue39
Change by Manuel Barkhau :
--
pull_requests: +17509
pull_request: https://github.com/python/cpython/pull/18122
___
Python tracker
<https://bugs.python.org/issue39
Manuel Barkhau added the comment:
Unless somebody else wants to, I could have a go at an PR to update shutil.py
--
___
Python tracker
<https://bugs.python.org/issue39
Manuel Barkhau added the comment:
Is there anything I can do to help move this forward?
--
___
Python tracker
<https://bugs.python.org/issue39390>
___
___
Pytho
Manuel Barkhau added the comment:
> This looks like a backward incompatible change in 3.8.
Indeed.
> Should not copytree convert arguments of the ignore callback to str and list
> correspondingly?
Well, since any existing code probably expects that behavior (or at least
probably
Change by Manuel Barkhau :
--
keywords: +patch
pull_requests: +17462
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18069
___
Python tracker
<https://bugs.python.org/issu
Change by Manuel Barkhau :
--
title: shutil.copytree - ignore callback behaviour change -> shutil.copytree -
3.8 changed argument types of the ignore callback
___
Python tracker
<https://bugs.python.org/issu
New submission from Manuel Barkhau :
In Python 3.8, the types of the parameters to the ignore callable appear to
have changed.
Previously the `src` parameter was a string and the `names` parameter was a
list of strings. Now the `src` parameter appears to be either a `pathlib.Path`
or an
12 matches
Mail list logo