[issue13359] urllib2 doesn't escape spaces in http requests

Mads Kiilerich added the comment: Yes, the url sent by urllib2 must not contain spaces. In my opinion the only way to handle that correctly is to not pass urls with spaces to urlopen. Escaping the urls is not a good solution - even if the API was to be designed from scratch. It would be

[issue13359] urllib2 doesn't escape spaces in http requests

Mads Kiilerich added the comment: FWIW, I don't think it is a good idea to escape automatically. It will change the behaviour in a non-backward compatible way for existing applications that pass encoded urls to this function. I think the existing behaviour is better. The documentatio

[issue6774] socket.shutdown documentation: on some platforms, closing one half closes the other half

Mads Kiilerich added the comment: I was scared by the note in the documentation and wondered if the socket Python API was completely incapable of handling half-closed connections cross platform. pitrou helped me on IRC to track the note down to this issue. IMO the bug report should have

[issue13721] ssl.wrap_socket on a connected but failed connection succeeds and .peer_certificate gives AttributeError

Mads Kiilerich added the comment: I would find ValueError surprising here. socket.error or SSLError would be less surprising ... even though it technically isn't completely true. But isn't it more like a kind of RuntimeError to call getpeercert after the socket has be

[issue13721] ssl.wrap_socket on a connected but failed connection succeeds and .peer_certificate gives AttributeError

Mads Kiilerich added the comment: > I'm a bit wary of API bloat here. Yes, but explicit is better than magic ... > Thanks. So fixing how getpeercert behaves and either raise a dedicated > error or return None would improve things here, right? Well ... that would at

[issue13721] ssl.wrap_socket on a connected but failed connection succeeds and .peer_certificate gives AttributeError

Mads Kiilerich added the comment: I won't claim to know more about socket error codes than what the Linux man pages says. According to them only send() can fail with ECONNRESET, even though POSIX Programmer's Manual man pages mentions many others. getpeername() is however not doc

[issue13721] ssl.wrap_socket on a connected but failed connection succeeds and .peer_certificate gives AttributeError

Mads Kiilerich added the comment: I think it would be confusing if getpeercert returned None both for valid connections without certificates and also for invalid connections. I would almost prefer the current behaviour (AttributeError) if just it was documented and there was a documented way

[issue13724] socket.create_connection and multiple IP addresses

New submission from Mads Kiilerich : Forked from issue13721 where I was too lazy to report it separately: http://docs.python.org/release/2.7.2/library/socket#socket.create_connection doesn't describe how it loops over all IP addresses. That seems to be the functions main advantage (

[issue13721] ssl.wrap_socket on a connected but failed connection succeeds and .peer_certificate gives AttributeError

New submission from Mads Kiilerich : According to http://docs.python.org/release/2.7.2/library/ssl wrap_socket can be used either on connected sockets or on un-connected sockets which then can be .connect'ed. In the latter case SSLSocket.connect() will (AFAIK) always raise a nice exce

[issue12833] raw_input misbehaves when readline is imported

Changes by Mads Kiilerich : -- nosy: +kiilerix ___ Python tracker <http://bugs.python.org/issue12833> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12786] subprocess wait() hangs when stdin is closed

Changes by Mads Kiilerich : -- nosy: +kiilerix ___ Python tracker <http://bugs.python.org/issue12786> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12000] SSL certificate verification failed if no dNSName entry in subjectAltName

Mads Kiilerich added the comment: Nicolas Bareil wrote, On 05/07/2011 09:48 AM: > Do you think this test should fail? Until now I have considered this behaviour OK but undocumented and officially unsupported in Python. One (the best?) reason for considering it OK is that if some

[issue12000] SSL certificate verification failed if no dNSName entry in subjectAltName

Mads Kiilerich added the comment: In my opinion the RFCs are a bit unclear about how iPAddress subjectAltNames should be handled. (I also don't know if Python currently do the right thing by accepting and matching IP addresses if specified in commonName.) Until now Python failed to the

[issue12000] SSL certificate verification failed if no dNSName entry in subjectAltName

Changes by Mads Kiilerich : -- nosy: +kiilerix ___ Python tracker <http://bugs.python.org/issue12000> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11725] httplib and urllib2 failed ssl connection httplib.BadStatusLine

Mads Kiilerich added the comment: I have filed issue11736 as a more or less related (or bogus) issue. -- nosy: +kiilerix ___ Python tracker <http://bugs.python.org/issue11

[issue11736] windows installers ssl module / openssl broken for some sites

New submission from Mads Kiilerich : (Probably the same root cause as issue11725 and using the same test case and analysis, but it seems like it isn't just somebody elses problem.) Expected behaviour: C:\Python26>python --version Python 2.6.4 C:\Python26>python -c "import u

[issue10795] standard library do not use ssl as recommended

Mads Kiilerich added the comment: The response I got to this issue hinted that it was a lame issue I filed. I haven't had time/focus to investigate further and give constructive feedback. I think it is kind of OK to require explicit specification of the ca_certs as long as it is made

[issue10795] standard library do not use ssl as recommended

New submission from Mads Kiilerich : As discussed on issue1589 it is now possible to create decent ssl connections with the ssl module - assuming ca_certs is specified and it is checked that the certificates matches. The standard library do however neither do that nor make it possible to do

[issue10618] regression in subprocess.call() command quoting

Changes by Mads Kiilerich : -- nosy: +kiilerix ___ Python tracker <http://bugs.python.org/issue10618> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1589] New SSL module doesn't seem to verify hostname against commonName in certificate

Mads Kiilerich added the comment: > So I know the current patch doesn't support IP addresses Not exactly. The committed patch do not consider IP addresses - especially not iPAddress entries in subjectAltName. But Python only distinguishes resolvable names from IP addresses at a

[issue1589] New SSL module doesn't seem to verify hostname against commonName in certificate

Mads Kiilerich added the comment: Can you confirm that the exception raised both on "too early" and "too late" is something like "...SSL3_GET_SERVER_CERTIFICATE:certificate verify failed"? (If so: It would be nice if a slightly more helpful message could be g

[issue1589] New SSL module doesn't seem to verify hostname against commonName in certificate

Mads Kiilerich added the comment: > Indeed. But, strictly speaking, there are no tests for IPs, so it > shouldn't be taken for granted that it works, even for commonName. > The rationale is that there isn't really any point in using an IP rather > a host name. I don'

[issue1589] New SSL module doesn't seem to verify hostname against commonName in certificate

Mads Kiilerich added the comment: I'm sorry to make the discussion longer ... >From a Python user/programmers point of view it would be nice if >http://docs.python.org/library/ssl.html also clarified what "validation" means >(apparently that the cert chain all the

[issue1589] New SSL module doesn't seem to verify hostname against commonName in certificate

Mads Kiilerich added the comment: I added some extra verification to Mercurial (http://www.selenic.com/hg/rev/f2937d6492c5). Feel free to use the following under the Python license in Python or elsewhere. It could be a separate method/function or it could integrated in wrap_socket and

[issue9698] When reusing an handler, urllib(2)'s digest authentication fails after multiple regative replies

Changes by Mads Kiilerich : -- nosy: +kiilerix ___ Python tracker <http://bugs.python.org/issue9698> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8797] urllib2 basicauth broken in 2.6.5: RuntimeError: maximum recursion depth exceeded in cmp

Mads Kiilerich added the comment: On 08/27/2010 03:47 AM, Senthil Kumaran wrote: > I agree with you respect to the other error codes, there is already > another bug open to handle this. The reset counter is reset on success > too, in another part of the code. FWIW: From Mercurial

[issue8797] urllib2 basicauth broken in 2.6.5: RuntimeError: maximum recursion depth exceeded in cmp

Mads Kiilerich added the comment: Senthil, can you tell us why this fix is correct - and convince us that it is the Final Fix for this issue? Not because I don't trust you, but because this issue has a bad track record. Some comments/questions to this patch: Why do 401 require such sp

[issue8797] urllib2 basicauth broken in 2.6.5: RuntimeError: maximum recursion depth exceeded in cmp

Mads Kiilerich added the comment: zenyatta: Which Mercurial version? We thought we had implemented a sufficiently ugly workaround in Mercurial. Please file an issue in http://mercurial.selenic.com/bts/ . -- ___ Python tracker <h

[issue8469] struct - please make sizes explicit

Mads Kiilerich added the comment: Thanks for improving the documentation! A couple of comments for possible further improvements: I think it would be helpful to also see an early notice about how to achieve platform independence, versus the default of the local platform. And perhaps the

[issue8797] urllib2 basicauth broken in 2.6.5: RuntimeError: maximum recursion depth exceeded in cmp

Mads Kiilerich added the comment: FYI: The regression was introduced in 2.6.5 with issue3819 . This also causes problems with Mercurial pushing to google code - see http://mercurial.selenic.com/bts/issue2179 . IIRC google code redirects to an url which then in turn requests authentication

[issue3819] urllib2 sends Basic auth across redirects

Mads Kiilerich added the comment: FYI, this change caused a regression in Mercurial - see http://mercurial.selenic.com/bts/issue2179. -- nosy: +kiilerix ___ Python tracker <http://bugs.python.org/issue3

[issue8469] struct - please make sizes explicit

Mads Kiilerich added the comment: The more times I read the documentation and your comments I can see that the implementation is OK and the documentation is "complete" and can be read correctly. Please take this as constructive feedback to improving the documentation to make it

[issue8469] struct - please make sizes explicit

New submission from Mads Kiilerich : The struct module is often used (at least by me) to implement protocols and binary formats. That makes the exact sizes (number of bits/bytes) of the different types very important. Please add the sizes to for example the table on http://docs.python.org

[issue8003] Fragile and unexpected error-handling in asyncore

New submission from Mads Kiilerich : I had an issue which seems to be very similar to issue4690 - but different. I created a subclass of asyncore.dispatcher, .create_socket added it to the channel map, but then .bind failed (because the port was in use - my bad), .listen wasn't called

[issue2622] Import errors in email.message.py

Mads Kiilerich added the comment: I have updated the patch. (Applied to 2.6 where it seems like some casings had been fixed, so I dropped all the rejects. Changes to test_email.py has been.) -- Added file: http://bugs.python.org/file14352/emailcasings2.patch

[issue6005] Bug in socket example

New submission from Mads Kiilerich : http://docs.python.org/library/socket.html says about socket.send: "Applications are responsible for checking that all data has been sent; if only some of the data was transmitted, the application needs to attempt delivery of the remaining data."

[issue1533164] Installed but not listed *.pyo break bdist_rpm

Mads Kiilerich added the comment: Ok, if you will keep bdist_rpm's new .pyo creation then you are right. FWIW I think it is a bit of an ugly hack and would prefer another solution. BTW: The "brp-python-bytecompile creates usr/bin/*.pyo" issue has been resolved, https://bugz

[issue1533164] Installed but not listed *.pyo break bdist_rpm

Mads Kiilerich added the comment: > IIUC, setting > > %define __os_install_post %{___build_post} > > should prevent invocation of brp-python-bytecompile. Ok. But preventing invocation of brp-python-bytecompile is IMHO not a solution. brp-python-bytecompile is needed for the re

[issue1533164] Installed but not listed *.pyo break bdist_rpm

Mads Kiilerich added the comment: Martin, What is the goal of bdist_rpm? I haven't seen that stated explicitly anywhere, but I assume the goal is to make a fair attempt to easily create usable RPMs for some software already using distutil, acknowledging that it might not work in all

[issue1533164] Installed but not listed *.pyo break bdist_rpm

Mads Kiilerich added the comment: The command "rpm" is (now, and in rpm.org version) for runtime and installation only. Rpm building is done by /usr/bin/rpm-build (from the package with the same name, run "yum install rpm-build"). /usr/lib/python2.5/distutils/command/bdis

[issue1533164] Installed but not listed *.pyo break bdist_rpm

Mads Kiilerich added the comment: Note that: This bug now is tracked in Fedora as https://bugzilla.redhat.com/show_bug.cgi?id=236535 The root of the problem on Fedora is that SElinux will give noisy warnings if python tries to to access or create non-existing foo.pyo for a packaged foo.py

[issue2916] urlgrabber.grabber calls setdefaulttimeout

Changes by Mads Kiilerich <[EMAIL PROTECTED]>: -- type: -> behavior __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2916> __ ___ Python-b

[issue2916] urlgrabber.grabber calls setdefaulttimeout

New submission from Mads Kiilerich <[EMAIL PROTECTED]>: Module docstring says """Setting this option causes urlgrabber to call the settimeout method on the Socket object used for the request.""" But actually it temporarily changes the global default time

[issue2622] Import errors in email.message.py

Mads Kiilerich <[EMAIL PROTECTED]> added the comment: Testing that email.message doesn't use the "wrong" casing email.Generator isn't enough. That would just test that this patch has been applied. It must also be tested that no other modules uses the wrong casing of

[issue2622] Import errors in email.message.py

Mads Kiilerich <[EMAIL PROTECTED]> added the comment: OK. I had assumed that backward compatibility was tested in the _renamed tests, so that these tests one day could be dropped together with backward compatibility. I didn't notice that my search'n'replaces showed me tha

[issue2622] Import errors in email.message.py

Mads Kiilerich <[EMAIL PROTECTED]> added the comment: This patch seems to fix the issue for me. The easiest way to verify might be to create another patch and compare them... -- keywords: +patch Added file: http://bugs.python.org/file10106/emailcasings

[issue2622] Import errors in email.message.py

Mads Kiilerich <[EMAIL PROTECTED]> added the comment: AFA I understand it the ImportError comes when running a py2exe/app'ed package where iterators.py hasn't been included. I was just about to file a report about (I think) the same issue, seen on XP when py2exe'ing code u

[issue1227748] subprocess: inheritance of std descriptors inconsistent

Mads Kiilerich added the comment: Note to others searching for a solution to this and similar problems: http://svn.python.org/view/python/trunk/Lib/subprocess.py?rev=60115&view=auto shows that this now (for 2.6?) has been changed so that close_fds now controls inheritance through