[issue28240] Enhance the timeit module: display average +- std dev instead of minimum

2016-10-18 Thread Maciej Fijalkowski
Changes by Maciej Fijalkowski : -- nosy: -fijall ___ Python tracker <http://bugs.python.org/issue28240> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27483] Expose HEAD_LOCK/HEAD_UNLOCK in pystate.c

2016-07-11 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: On windows the profiler runs in a separate thread and pauses/restarts other threads (hence the requirements are slightly different). HEAD_LOCK etc. are def not async-signal safe, but it's not an issue on

[issue27483] Expose HEAD_LOCK/HEAD_UNLOCK in pystate.c

2016-07-11 Thread Maciej Fijalkowski
New submission from Maciej Fijalkowski: Hi The use case here is for C-based statistical profilers. When running vmprof on linux/os x, you can get the current thread state from PyThreadState_GetUnchecked or a similar solution. However, on windows you need to walk all the interpreter state

[issue17580] ctypes: ARM hardfloat argument corruption calling functions with many float arguments

2016-03-01 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: The easiest way to check is to run the tests attached -- ___ Python tracker <http://bugs.python.org/issue17580> ___ ___ Pytho

[issue17580] ctypes: ARM hardfloat argument corruption calling functions with many float arguments

2016-03-01 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: Then maybe it's fixed, I have no idea -- ___ Python tracker <http://bugs.python.org/issue17580> ___ ___ Python-bugs-l

[issue17580] ctypes: ARM hardfloat argument corruption calling functions with many float arguments

2016-03-01 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: Apparently you can't have an opinion from ctypes experts. Can you please commit the upstream fix that has been committed 3 years ago or just stop vendoring random, old, broken version of ctypes if you can't maintain it enough to pull fixes fro

[issue26461] PyInterpreterState_Head(), PyThreadState_Next() etc can't be sanely used

2016-02-29 Thread Maciej Fijalkowski
New submission from Maciej Fijalkowski: All the internal uses of this API guard everything with HEAD_LOCK/HEAD_UNLOCK that's not exposed. It's not safe to traverse the whole API without holding those locks and those locks are static and module local -- messages: 261030 no

[issue26459] Windows build instructions are very inaccurate

2016-02-29 Thread Maciej Fijalkowski
New submission from Maciej Fijalkowski: I've tried following the dev guide (still not successful) to compile a debug version of cpython 2.7 and a couple issues that I run into: * The VS2010 vs VS2008 confustion - the docs say "most versions before 3.3 use VS2008" - what does i

[issue25130] Make tests more PyPy compatible

2015-09-16 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: Hi Looking through your comments, yes, maybe those tests or those things require fixing. We at pypy don't have enough will to fight python-dev most of the time, so the usual approach is to do "minimal hack that works" without trying to

[issue25106] Hash computation speedup for {buffer, string, unicode}object

2015-09-16 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: I find numbers really hard to believe. It would mean that over 40% of django templates is string hashing (assuming 2x speedup) which really sounds unbelievable. In fact in PyPy I never found string hashing to be significant while I would expect PyPy to

[issue25130] Make tests more PyPy compatible

2015-09-16 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: Hi I can answer precise questions, which tests are you asking about? Note that if the point is to unify the test suite, would be cool to make changes to both pypy and cpython and not just change cpython one

[issue19336] No API to get events from epoll without allocating a list

2013-10-21 Thread Maciej Fijalkowski
Changes by Maciej Fijalkowski : -- nosy: +fijall ___ Python tracker <http://bugs.python.org/issue19336> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17423] libffi on 32bit is broken on linux

2013-03-16 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: It's not "a copy for systems that don't provide libffi", since CPython makes zero effort to try to use system libffi if present. -- ___ Python tracker <http://bug

[issue17423] libffi on 32bit is broken on linux

2013-03-16 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: The issue is reported upstrem and is/will be fixed -- ___ Python tracker <http://bugs.python.org/issue17423> ___ ___ Pytho

[issue17245] ctypes libffi needs to align the x86 stack to 16 bytes

2013-03-14 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: This patch is not in the whatever version ubuntu supplies. Btw, this is code duplication, since there is already darwin alignment, see 17423 -- nosy: +fijall ___ Python tracker <http://bugs.python.

[issue17423] libffi on 32bit is broken on linux

2013-03-14 Thread Maciej Fijalkowski
Changes by Maciej Fijalkowski : -- keywords: +patch Added file: http://bugs.python.org/file29412/ffi.diff ___ Python tracker <http://bugs.python.org/issue17

[issue17423] libffi on 32bit is broken on linux

2013-03-14 Thread Maciej Fijalkowski
Changes by Maciej Fijalkowski : Added file: http://bugs.python.org/file29411/x.c ___ Python tracker <http://bugs.python.org/issue17423> ___ ___ Python-bugs-list mailin

[issue17423] libffi on 32bit is broken on linux

2013-03-14 Thread Maciej Fijalkowski
Changes by Maciej Fijalkowski : Removed file: http://bugs.python.org/file29409/x.c ___ Python tracker <http://bugs.python.org/issue17423> ___ ___ Python-bugs-list mailin

[issue17423] libffi on 32bit is broken on linux

2013-03-14 Thread Maciej Fijalkowski
Changes by Maciej Fijalkowski : Added file: http://bugs.python.org/file29410/x.py ___ Python tracker <http://bugs.python.org/issue17423> ___ ___ Python-bugs-list mailin

[issue17423] libffi on 32bit is broken on linux

2013-03-14 Thread Maciej Fijalkowski
New submission from Maciej Fijalkowski: The bug is a little tricky to reproduce. You need a 32bit linux. First compile x.c with: gcc -O3 -g -shared -o x.so x.c -std=c99 -msse3 -ftree-vectorize -mfpmath=sse and run x.py. It segfaults because the alignment of stack is not preserved (and it&#

[issue17232] Improve -O docs

2013-02-23 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: Also IMO -OO should stop talking about optimizations. Maybe "Do what -O does and discard docstrings"? -- ___ Python tracker <http://bugs.python.o

[issue17232] Improve -O docs

2013-02-19 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: There were not for at least 10 years. I would also be the first one to strongly object adding optimizations only under -O, because that already changes semantics. -- ___ Python tracker <http://bugs.python.

[issue17232] Improve -O docs

2013-02-18 Thread Maciej Fijalkowski
New submission from Maciej Fijalkowski: This is what the current documentation says: -O Turn on basic optimizations. This changes the filename extension for compiled (bytecode) files from .pyc to .pyo. See also PYTHONOPTIMIZE. -OO Discard docstrings in addition to the -O optimizations. As

[issue17231] Mark __del__ not being called in cycles as an impl detail

2013-02-18 Thread Maciej Fijalkowski
New submission from Maciej Fijalkowski: Here: http://docs.python.org/2/reference/datamodel.html, as per python-dev discussion -- assignee: docs@python components: Documentation messages: 182364 nosy: docs@python, fijall priority: normal severity: normal status: open title: Mark __del__

[issue1285086] urllib.quote is too slow

2013-02-13 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: As per discussion on python-dev, this bug should probably be reopened and the patch maybe reverted as relying on the refcounting hack is both dodgy and hurts other implementations, like PyPy. -- nosy: +fijall

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-21 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: Hi. This is what we did with Armin: http://bpaste.net/show/32123/ It seems there is still *some* information leaking via side-channels, although it's a bit unclear what. Feel free to play with it (try swapping, having different objec

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-15 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: On Fri, Jun 15, 2012 at 10:09 AM, Martin v. Löwis wrote: > > Martin v. Löwis added the comment: > > > Note that this does not relief you from using a time-independent > comparison > > function. If you call some hash function (wh

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-15 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: On Fri, Jun 15, 2012 at 9:55 AM, Hynek Schlawack wrote: > > Hynek Schlawack added the comment: > > >> and any other place that compares passwords, tokens, … > > > > No no no. Any sensible place to compare passwords woul

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-15 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: On Fri, Jun 15, 2012 at 9:47 AM, Martin v. Löwis wrote: > > Martin v. Löwis added the comment: > > > To repeat, the specific feature being proposed for retention is: > > To repeat, no use case has been demonstrated for that function

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-15 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: On Fri, Jun 15, 2012 at 9:41 AM, Nick Coghlan wrote: > > Nick Coghlan added the comment: > > To repeat, the specific feature being proposed for retention is: > > * a function called hmac.total_compare() that is clearly documente

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-14 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: Hi Christian. It's either secure or it's not. If it's not, there is no point in introducing it at all as I don't think it's a good idea to have a kind-of-secure-but-i-dont-know functions in stdlib. If you restrict input to by

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-14 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: For unicode at the very least it's not an improvement at all. With the patch mentioned that does encode it's also not an improvement at all. Prove as in reason about the function in C and make sure it does not do any conditionals depending on

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-14 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: export not explore. Why can't I edit my own post? -- ___ Python tracker <http://bugs.python.org/issue15061> ___ ___

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-14 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: Antoine, seriously? You want to explore a function that's called "secure" when the only thing you know about it is "probably secure"? This is extremely tricky business and I think it should be called secure only if you can prov

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-14 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: Ah unicodes. is encode('unicode-internal') independent on the string characters? I heavily doubt so. you leak at least some information through that function alone. -- ___ Python trac

[issue15061] hmac.secure_compare() leaks information of length of strings

2012-06-14 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: secure_compare leaks the password always. Note that it takes different time to create a result of ord() depending whether it's <=100 or > 100 due to caching of small numbers. Such functions should be written in C. -- no

[issue14212] Segfault when using re.finditer over mmap

2012-03-06 Thread Maciej Fijalkowski
New submission from Maciej Fijalkowski : Example to get a segfault attached. Crashes under python3 as well. -- files: x.py messages: 155028 nosy: fijall priority: normal severity: normal status: open title: Segfault when using re.finditer over mmap type: crash versions: Python 2.7 Added

[issue10994] implementation details in sys module

2011-01-25 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: > > Which experts you had in mind? > People who know how the Python implementation works. I'm serious. What semantics would make sense to anyone? Even if you know implementation quite well a single number per object does not provide enoug

[issue10994] implementation details in sys module

2011-01-25 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: I can hardly think about a specification that would potentially help me identify actual sizes. Even as a rough estimation. Which experts you had in mind? -- ___ Python tracker <http://bugs.python.

[issue10994] implementation details in sys module

2011-01-24 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: I suppose wrt getsizeof it's more of "if you provide us with a reasonable expectations, we can implement this" other than anything else. -- ___ Python tracker <http://bugs.pyt

[issue10994] implementation details in sys module

2011-01-24 Thread Maciej Fijalkowski
New submission from Maciej Fijalkowski : sys module documentation (as it is online) has some things that in my opinion should be marked as implementation details, but are not. Feel free to counter why not. Some of them has info it should be used for specialized purposes only, but IMO it&#

[issue10399] AST Optimization: inlining of function calls

2010-11-25 Thread Maciej Fijalkowski
Changes by Maciej Fijalkowski : -- nosy: +fijall ___ Python tracker <http://bugs.python.org/issue10399> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10244] PEP100 has broken links

2010-10-30 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: That is really weird, it definitely doesn't for me. Anyway, closing the ticket then. -- status: open -> closed ___ Python tracker <http://bugs.python.org

[issue10244] PEP100 has broken links

2010-10-30 Thread Maciej Fijalkowski
Maciej Fijalkowski added the comment: Python starship is down, I thought it's permanently down, isn't it? -- ___ Python tracker <http://bugs.python.o

[issue10244] PEP100 has broken links

2010-10-30 Thread Maciej Fijalkowski
New submission from Maciej Fijalkowski : PEP100 (http://www.python.org/dev/peps/pep-0100/) links to python starship. Should it just link to python.org for the newest version of this doc? -- assignee: d...@python components: Documentation messages: 119967 nosy: d...@python, fijall