[issue40297] test_socket.CANTest is broken at HEAD on master

2020-05-22 Thread Karl Ding
Karl Ding added the comment: Related: I've started a thread on Discourse [0] looking into why the tests don't seem to be run on the Buildbot cluster (and what it would take to enable them). Hopefully it gains some traction. [0] https://discuss.python.org/t/what-would-it-t

[issue40291] socket library support for CAN_J1939

2020-05-19 Thread Karl Ding
Karl Ding added the comment: Should this be added to the What's New for 3.9? I see a smaller change that exposes the CAN_RAW_JOIN_FILTERS constant mentioned. I've created https://github.com/python/cpython/pull/20248 if this

[issue40291] socket library support for CAN_J1939

2020-05-19 Thread Karl Ding
Change by Karl Ding : -- pull_requests: +19536 pull_request: https://github.com/python/cpython/pull/20248 ___ Python tracker <https://bugs.python.org/issue40

[issue40297] test_socket.CANTest is broken at HEAD on master

2020-04-15 Thread Karl Ding
Change by Karl Ding : -- keywords: +patch pull_requests: +18894 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19548 ___ Python tracker <https://bugs.python.org/issu

[issue40297] test_socket.CANTest is broken at HEAD on master

2020-04-15 Thread Karl Ding
New submission from Karl Ding : While working on https://bugs.python.org/issue40291, I was trying to run the SocketCAN tests to ensure that my changes weren't causing any regressions. However, I was seeing test failures at HEAD. I'm running the tests like so: # Kernel versio

[issue40291] socket library support for CAN_J1939

2020-04-14 Thread Karl Ding
Change by Karl Ding : -- keywords: +patch pull_requests: +18886 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19538 ___ Python tracker <https://bugs.python.org/issu

[issue40291] socket library support for CAN_J1939

2020-04-14 Thread Karl Ding
New submission from Karl Ding : It would be nice to have support J1939 sockets. Support for J1939 landed as part of the SAE J1939 SocketCAN patches, which are available after the Linux 5.4rc1 kernel. This is another protocol family for SocketCAN, much like the existing support for ISOTP and

[issue29753] Ctypes Packing Bitfields Incorrectly - Linux

2019-05-30 Thread Karl Ding
Karl Ding added the comment: I believe the example can be simplified to the following: class MyStructure(ctypes.Structure): _pack_ = 1 _fields_ = [('A', ctypes.c_uint32, 8)] assert ctypes.sizeof(MyStructure) == 1 Here, ctypes.sizeof retur

[issue37085] Expose additional socket constants for CAN_BCM flags

2019-05-29 Thread Karl Ding
Change by Karl Ding : -- keywords: +patch pull_requests: +13541 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13646 ___ Python tracker <https://bugs.python.org/issu

[issue37085] Expose additional socket constants for CAN_BCM flags

2019-05-28 Thread Karl Ding
New submission from Karl Ding : When reading through the values exposed via the socket library, I noticed that currently, only the SocketCAN BCM opcode enums are exposed via the socket constants. These correspond to the following from the Linux headers: enum