[issue16611] Cookie.py does not parse httponly or secure cookie flags

2013-08-24 Thread Julien Phalip
Julien Phalip added the comment: Thanks for the clarification, that makes perfect sense! -- ___ Python tracker <http://bugs.python.org/issue16611> ___ ___ Pytho

[issue16611] Cookie.py does not parse httponly or secure cookie flags

2013-08-24 Thread Julien Phalip
Julien Phalip added the comment: Thanks for the review and new patch, David! Your approach makes sense and the patch looks good to me. However, regarding backwards-compatibility, is that really a concern? Currently the deserialization process systematically 1) Adds the 'httponly' an

[issue16611] multiple problems with Cookie.py

2013-08-15 Thread Julien Phalip
Julien Phalip added the comment: Updated the patch to use a tuple instead of a list for the cookie flags. -- Added file: http://bugs.python.org/file31307/cookies-httponly-secure-3.diff ___ Python tracker <http://bugs.python.org/issue16

[issue16611] multiple problems with Cookie.py

2013-07-18 Thread Julien Phalip
Julien Phalip added the comment: Thank you for the feedback. I've updated the patch to compile the regular expression at load time. -- Added file: http://bugs.python.org/file30969/cookies-httponly-secure-2.diff ___ Python tracker

[issue16611] multiple problems with Cookie.py

2013-07-18 Thread Julien Phalip
Julien Phalip added the comment: I'm attaching a suggested patch to fix the issues relating to serializing/deserializing the httponly and secure flags. The main idea is that for a flag to be active, it needs to both be set and have the True value. I think this is a much more correct and