Jonas H. added the comment:
pat.match() has 110 nsec.
Feel free to close the issue and PR if you think this isn't worth changing.
--
___
Python tracker
<https://bugs.python.org/is
Jonas H. added the comment:
I agree with your statement in principle. Here are numbers for the slowdown
that's introduced:
Without the change:
./python.exe -m timeit -s 'import re'\n'[re.compile(f"fill_cache{i}") for i
in range(512)]'\n'pat
Change by Jonas H. :
--
keywords: +patch
pull_requests: +27224
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28936
___
Python tracker
<https://bugs.python.org/issu
New submission from Jonas H. :
re.match(p, ...) with a pre-compiled pattern p = re.compile(...) can be much
slower than calling p.match(...). Probably mostly in cases with "easy" patterns
and/or short strings.
The culprit is that re.match -> re._compile can spend a lot of time
Jonas H. added the comment:
The assertion in the patched code, yes. The segfault in the unpatched code, no.
--
___
Python tracker
<https://bugs.python.org/issue34
Jonas H. added the comment:
I don't think this can be tested with Python code, unless you can make sure the
target buffer _PyUnicode_TransformDecimalAndSpaceToASCII operates on is
initialised with garbage bytes.
--
___
Python tracker
&
Jonas H. added the comment:
Here's a Docker image that reproduces the bug.
FROM ubuntu:18.04
RUN apt update && apt install -y python3.7-dbg python3.7-venv python3-venv wget
RUN python3.7 -m venv venv
RUN venv/bin/pip install django
RUN wget https://bugs.python.org/file47688/testp
Jonas H. added the comment:
Sure.
Unpack archive, create new 3.7 venv with Django (latest version is fine),
./manage.py runserver, curl localhost:8000.
--
___
Python tracker
<https://bugs.python.org/issue34
Jonas H. added the comment:
Reduced it to something that seems unicode related?
No extension modules involved. Vanilla Django project with a single url +
template.
See testproj/urls.py and tmpl/index.html
--
Added file: https://bugs.python.org/file47688/testproj.tar.gz
Jonas H. added the comment:
I can reproduce this on Ubuntu 18.04.
INADA, I have a full gdb backtrace with Python 3.7 development build. I'd like
to share it with you privately as I'm concerned it may contain sensible
information. I know that's a bit unconventional; if
Jonas H. added the comment:
Btw my segfault is from Django too, but that may just be a coincidence
--
___
Python tracker
<https://bugs.python.org/issue34
Jonas H. added the comment:
I also have a segfault that goes away with malloc debugging. Not sure if it's
the same issue.
My extension modules are
venv/lib/python3.7/site-packages//_yaml.cpython-37m-darwin.so
venv/lib/python3.7/site-packages//netifaces.cpython-37m-darwin.so
ven
Jonas H. added the comment:
See also
https://stackoverflow.com/questions/19309514/getting-original-line-number-for-exception-in-concurrent-futures
for other people having the same problem
--
___
Python tracker
<https://bugs.python.org/issue32
New submission from Jonas H. :
Use case: Try to get a future's result using
concurrent.futures.Future.result(), and log the full exception if there was any.
Currently, only "excinst" (sys.exc_info()[1]) is provided with the
Future.exception() method.
Proposal: Add new
Jonas H. added the comment:
https://github.com/python/cpython/pull/4589
- Add 3.7 What's New entry
- Fix regression (thanks Tim for the report)
--
___
Python tracker
<https://bugs.python.org/is
Change by Jonas H. :
--
pull_requests: +4513
___
Python tracker
<https://bugs.python.org/issue32071>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jonas H. added the comment:
Ah, the problem isn't that it's running getattr() on test methods, but that it
runs getattr() on all methods.
Former code: attrname.startswith(prefix) and \
callable(getattr(testCaseClass, attrname))
New code: testFunc = getattr(tes
Jonas H. added the comment:
Sure!
--
___
Python tracker
<https://bugs.python.org/issue32071>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Jonas H. added the comment:
Interesting, Victor. I've had a look at the code you mentioned, but I'm afraid
it doesn't really make sense to re-use any of the code.
Here's a new patch, implemented in the loader as suggested by Antoine, and with
tests.
I'm happy t
Jonas H. added the comment:
> > 3) Is the approach of dynamically wrapping 'skip()' around to-be-skipped
> > test cases OK?
> I think this is the wrong approach. A test that isn't selected shouldn't be
> skipped, it should not appear in the output at al
Jonas H. added the comment:
Thanks Antoine. I will need some guidance as to what are the correct places to
make these changes. I'm not quite sure about the abstractions here (runner,
loader, suite, case, etc.)
My PoC (see GitHub link in first post) uses a TestSuite subclass. (The sub
Jonas H. added the comment:
Just to be clear, the current implementation is limited to substring matches.
It doesn't support py.test like "and/or" combinators. (Actually, py.test uses
'eval' to support arbitrary patterns.)
So say we have test case
SomeClass
te
New submission from Jonas H. :
I'd like to add test selection based on parts of the test class/method name to
unittest. Similar to py.test's "-k" option:
https://docs.pytest.org/en/latest/example/markers.html#using-k-expr-to-select-tests-based-on-their-name
Here&
Jonas H. added the comment:
This affects me too.
--
nosy: +jonash
___
Python tracker
<https://bugs.python.org/issue31526>
___
___
Python-bugs-list mailin
Jonas H. added the comment:
I just hit this too. I'd say remove the fileno() method from wrapper objects
like GzipFile. I'm happy to submit a patch.
--
nosy: +jonash
___
Python tracker
<http://bugs.python.o
New submission from Jonas H.:
>From my personal experience, listing all real files and all subdirectories in
>a directory is a very common use case.
Here's a patch that adds the `iterfiles()` and `iterdirs()` methods as a
shortcut for `[f for f in p.iterdir() if f.
New submission from Jonas H.:
The Sphinx docs don't contain any explanation for `local_hostname`.
--
assignee: docs@python
components: Documentation
messages: 190898
nosy: docs@python, jonash
priority: normal
severity: normal
status: open
title: SMTP.local_hostname is undocum
Jonas H. added the comment:
Why does it have a 'seek' method then?
--
___
Python tracker
<http://bugs.python.org/issue12877>
___
___
Python-bugs-l
New submission from Jonas H. :
from subprocess import Popen, PIPE
p = Popen(['ls'], stdout=PIPE)
p.wait()
p.stdout.seek(0)
Traceback (most recent call last):
File "t.py", line 5, in
p.stdout.seek(0)
IOError: [Errno 29] Illegal seek
Python 2.7.2, Arch Linu
Jonas H. added the comment:
Nope. I want an "examples" section, for example from `man git log`:
EXAMPLES
git log --no-merges
Show the whole commit history, but skip any merges
git log v2.6.12.. include/scsi drivers/scsi
Show all commits sin
New submission from Jonas H. :
I'd like to see an `examples` option added to argparse.ArgumentParser as found
in many man pages.
This could also be done using the `epilog` option, but that misses the
"%(proc)s" replacement which makes usage examples like this
Example usage:
Jonas H. added the comment:
Having one page with two objects of the same name, e.g.
.. function:: foo
.. class:: foo
renders to two entries with the same anchor name (#foo). The first entry gets a
link-to-this-paragraph marker, the second one doesn't.
Internal references (from w
Jonas H. added the comment:
> Jonas, I owe you an apology [...]
Thanks Éric, I got a bit worried about getting on your nerves...
Based on Ezio's idea: What happens if we have both a ".. function:: foo" and
".. class:: foo" -- where do :func:`foo` and :class:`f
Jonas H. added the comment:
> So the intersphinx behavior is the "correct" one, but we can't change the
> other now because of compatibility.
Could you be convinced to use that legacy behaviour for intersphinx, too? :-)
--
_
Jonas H. added the comment:
> when you mark up something with a mod, func, class or meth role, Sphinx will
> find the target without paying attention to its type. So changing :func: to
> :class: does not bring anything.
>From a quick test this seems to hold true for links within
Jonas H. added the comment:
What's wrong with the changes I propose with the patch, then? Sorry, I really
don't get it, no matter how hard I try.
--
___
Python tracker
<http://bugs.python.o
Jonas H. added the comment:
> Could you make an effort to accept our word that using :class: instead of
> :func: would bring zero value to the indexing system nor to human readers?
I'm already doing; but I don't see anyone having made a good point against my
preference of
Jonas H. added the comment:
I'm not.
My patch doesn't address the problem of unlinkable methods but wrong type
declarations (read, wrong usage of ".. function::" directives) for builtins
like int, float, bool, list etc. Because the directives change, the roles used
to
Jonas H. added the comment:
Linking a class using a function directive is counter-intuitive. That's why we
need to make use of class directives rather than function directives here.
--
___
Python tracker
<http://bugs.python.org/is
Jonas H. added the comment:
Does that look good to you? If it does, I'll go on using the script
(http://paste.pocoo.org/show/396661/) on the 3.x docs.
--
keywords: +patch
Added file: http://bugs.python.org/file22164/p1.patch
___
Python tr
Jonas H. added the comment:
Shouldn't have used "decent" here, sorry. What I was trying to say is that
there's no "reference-like" documentation for the list datatype (as for dict).
There's more than enough quality documentation about lists but I think the
Jonas H. added the comment:
It doesn't. Sphinx still can't make any links, which btw also means that it's
impossible to reference those methods within the Python documentation.
Also I want to point out that I find the information very hard to find as a
human. The fact that int
Jonas H. added the comment:
> Is this a problem in our markup or a bug in intersphinx?
It's a markup problem -- those types are documented as functions, using the
:func: role/`.. func::` directive.
It's not only a markup mismatch but, strictly speaking, it's *wrong*
docum
Jonas H. added the comment:
Indeed they do; but documentation writers need to know that `int()` and
`float()` are functions, which is counterintuitive. (and a CPython
implementation detail)
--
___
Python tracker
<http://bugs.python.org/issue11
Jonas H. added the comment:
Actually I need to be able to intersphinx (because my documentation work is not
the Python docs :-) but I guess it boils down to the same problem of incomplete
Sphinx module/class indices.
--
___
Python tracker
<h
New submission from Jonas H. :
Various `int` attributes and methods seem undocumented (at least it does not
work to intersphinx them):
* .conjugate
* .denominator
* .imag
* .numerator
* .real
--
assignee: docs@python
components: Documentation
messages: 134926
nosy: docs@python, jonash
New submission from Jonas H. :
Provide a proper `list` method reference (like the one for `dict`,
http://docs.python.org/library/stdtypes.html#dict).
Right now, documentation about lists is spread over multiple topics (.rst
files) and methods are documented in footnotes.
Also, intersphinx
New submission from Jonas H. :
Intersphinx-ing of int, list, float, ... should work with ":class:`int`" (list,
float, ...). Also, intersphinx-ing list methods, e.g. ":meth:`list.insert`",
should work.
--
assignee: docs@python
components: Documentation
message
Jonas H. added the comment:
*push* Any way to get this into the codebase?
--
___
Python tracker
<http://bugs.python.org/issue11258>
___
___
Python-bugs-list m
New submission from Jonas H. :
Either a `BaseException.with_traceback` implementation is missing or the docs
are wrong.
http://docs.python.org/library/exceptions.html?highlight=with_traceback#exceptions.BaseException.with_traceback
python3 -c 'print("with_traceback" in di
Jonas H. added the comment:
Here comes a patch, changing the behaviour to:
./python -q
>>> class C:
... pass
...
>>> (1).__class__ = 1
Traceback (most recent call last):
File "", line 1, in
TypeError: __class__ must be set to a class defined by a class stateme
Jonas H. added the comment:
> the orig impl matches the abi_type at the beginning of the parentheses,
> yours simply ignores the abi_type (that should have caught my eye, but that
> regex looked so much like magic that I didn't try to make sense of it :-))
Same here. :)
The vers
New submission from Jonas H. :
I guess this should be a link.
--
assignee: docs@python
components: Documentation
files: fix-json-link.diff
keywords: patch
messages: 129629
nosy: docs@python, jonash
priority: normal
severity: normal
status: open
title: Fix a link in library/json docs
Jonas H. added the comment:
Humm. Would be great to have the `ldconfig -p` output of such a machine... I
can't get ldconfig to recognize 64-bit libraries on my 32-bit machines, so I
have no output to test against...
--
___
Python tracker
Jonas H. added the comment:
As far as I can tell, it doesn't matter.
We're looking for the part after the => in any case - ignoring the
ABI/architecture information - so the regex would chose the first of those
entries.
--
___
P
Changes by Jonas H. :
Added file:
http://bugs.python.org/file20874/faster-find-library1-py3k-with-escaped-name.diff
___
Python tracker
<http://bugs.python.org/issue11
Jonas H. added the comment:
(might also be related to http://bugs.python.org/issue11063)
--
___
Python tracker
<http://bugs.python.org/issue11258>
___
___
Pytho
Changes by Jonas H. :
Added file: http://bugs.python.org/file20809/faster-find-library2.diff
___
Python tracker
<http://bugs.python.org/issue11258>
___
___
Python-bug
New submission from Jonas H. :
(This applies to all versions of Python I investigated, although the attached
patch is for Python 2.7)
I wondered why `import uuid` took so long, so I did some profiling.
It turns out that `find_library` wastes at lot of time because of this crazy
regular
Changes by Jonas H. :
--
nosy: +jonash
___
Python tracker
<http://bugs.python.org/issue1731717>
___
___
Python-bugs-list mailing list
Unsubscribe:
60 matches
Mail list logo
